Re: [AArch64][TLSLE][3/N] Add UNSPEC_TLSLE
Hi Jiong, It seems to me that you committed patches 1/N, 2/N and 3/N as only 1 commit (rev 225121). Am I right? On 26 June 2015 at 16:39, Marcus Shawcroft marcus.shawcr...@gmail.com wrote: On 20 May 2015 at 12:21, Jiong Wang jiong.w...@arm.com wrote: Add new unspec name UNSPEC_TLSLE, use it for all tlsle pattern. ok for trunk? 2015-05-19 Jiong Wang jiong.w...@arm.com gcc/ * config/aarch64/aarch64.md (UNSPEC_TLSLE): New enumeration. (tlsle): Use new unspec name. (tlsle_mode): Ditto. OK /Marcus
Re: [AArch64][TLSLE][3/N] Add UNSPEC_TLSLE
Christophe Lyon writes: Hi Jiong, It seems to me that you committed patches 1/N, 2/N and 3/N as only 1 commit (rev 225121). Am I right? Yes, 1/2/3 are quite tiny, and seperated for easy review. While I committed them as one patch. On 26 June 2015 at 16:39, Marcus Shawcroft marcus.shawcr...@gmail.com wrote: On 20 May 2015 at 12:21, Jiong Wang jiong.w...@arm.com wrote: Add new unspec name UNSPEC_TLSLE, use it for all tlsle pattern. ok for trunk? 2015-05-19 Jiong Wang jiong.w...@arm.com gcc/ * config/aarch64/aarch64.md (UNSPEC_TLSLE): New enumeration. (tlsle): Use new unspec name. (tlsle_mode): Ditto. OK /Marcus -- Regards, Jiong
Re: [AArch64][TLSLE][3/N] Add UNSPEC_TLSLE
Christophe Lyon writes: On 30 June 2015 at 11:12, Jiong Wang jiong.w...@arm.com wrote: Christophe Lyon writes: Hi Jiong, It seems to me that you committed patches 1/N, 2/N and 3/N as only 1 commit (rev 225121). Am I right? Yes, 1/2/3 are quite tiny, and seperated for easy review. While I committed them as one patch. Thanks for the clarification, I don't think this is standard practice. OK. It's better to add at least links to the patch review at gcc-patches archive so that people can find the background discussion easily. I was following https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00254.html. On 26 June 2015 at 16:39, Marcus Shawcroft marcus.shawcr...@gmail.com wrote: On 20 May 2015 at 12:21, Jiong Wang jiong.w...@arm.com wrote: Add new unspec name UNSPEC_TLSLE, use it for all tlsle pattern. ok for trunk? 2015-05-19 Jiong Wang jiong.w...@arm.com gcc/ * config/aarch64/aarch64.md (UNSPEC_TLSLE): New enumeration. (tlsle): Use new unspec name. (tlsle_mode): Ditto. OK /Marcus -- Regards, Jiong -- Regards, Jiong
Re: [AArch64][TLSLE][3/N] Add UNSPEC_TLSLE
On 30 June 2015 at 11:12, Jiong Wang jiong.w...@arm.com wrote: Christophe Lyon writes: Hi Jiong, It seems to me that you committed patches 1/N, 2/N and 3/N as only 1 commit (rev 225121). Am I right? Yes, 1/2/3 are quite tiny, and seperated for easy review. While I committed them as one patch. Thanks for the clarification, I don't think this is standard practice. On 26 June 2015 at 16:39, Marcus Shawcroft marcus.shawcr...@gmail.com wrote: On 20 May 2015 at 12:21, Jiong Wang jiong.w...@arm.com wrote: Add new unspec name UNSPEC_TLSLE, use it for all tlsle pattern. ok for trunk? 2015-05-19 Jiong Wang jiong.w...@arm.com gcc/ * config/aarch64/aarch64.md (UNSPEC_TLSLE): New enumeration. (tlsle): Use new unspec name. (tlsle_mode): Ditto. OK /Marcus -- Regards, Jiong
Re: [AArch64][TLSLE][3/N] Add UNSPEC_TLSLE
On 20 May 2015 at 12:21, Jiong Wang jiong.w...@arm.com wrote: Add new unspec name UNSPEC_TLSLE, use it for all tlsle pattern. ok for trunk? 2015-05-19 Jiong Wang jiong.w...@arm.com gcc/ * config/aarch64/aarch64.md (UNSPEC_TLSLE): New enumeration. (tlsle): Use new unspec name. (tlsle_mode): Ditto. OK /Marcus
