Re: [PATCH, AArch64] Fix for PR61202
On 20 May 2014 18:37, Carrot Wei car...@google.com wrote: Hi James Thank you for pointing this out. In the new patch I removed the modification of vqdmulh_n_s32 and vqdmulhq_n_s32. Passed dejagnu testing on aarch64 qemu again. OK for trunk, 4.9 and 4.8? 2014-05-20 Guozhi Wei car...@google.com * config/aarch64/arm_neon.h (vqdmulh_n_s16): Change the last operand's constraint. (vqdmulhq_n_s16): Likewise. Thank you. This is OK to commit on trunk, 4.9 and 4.8 /Marcus
Re: [PATCH, AArch64] Fix for PR61202
On 21 May 2014 09:28, Marcus Shawcroft marcus.shawcr...@gmail.com wrote: On 20 May 2014 18:37, Carrot Wei car...@google.com wrote: Hi James Thank you for pointing this out. In the new patch I removed the modification of vqdmulh_n_s32 and vqdmulhq_n_s32. Passed dejagnu testing on aarch64 qemu again. OK for trunk, 4.9 and 4.8? 2014-05-20 Guozhi Wei car...@google.com * config/aarch64/arm_neon.h (vqdmulh_n_s16): Change the last operand's constraint. (vqdmulhq_n_s16): Likewise. Thank you. This is OK to commit on trunk, 4.9 and 4.8 /Marcus Actually, I've jumped the gun by saying OK for 4.8. Please hold off on the 4.8 backport until one of the release maintainers says its OK. Richie can we take this now or do you want us to hold off? Cheers /Marcus
Re: [PATCH, AArch64] Fix for PR61202
On Wed, 21 May 2014, Marcus Shawcroft wrote: On 21 May 2014 09:28, Marcus Shawcroft marcus.shawcr...@gmail.com wrote: On 20 May 2014 18:37, Carrot Wei car...@google.com wrote: Hi James Thank you for pointing this out. In the new patch I removed the modification of vqdmulh_n_s32 and vqdmulhq_n_s32. Passed dejagnu testing on aarch64 qemu again. OK for trunk, 4.9 and 4.8? 2014-05-20 Guozhi Wei car...@google.com * config/aarch64/arm_neon.h (vqdmulh_n_s16): Change the last operand's constraint. (vqdmulhq_n_s16): Likewise. Thank you. This is OK to commit on trunk, 4.9 and 4.8 /Marcus Actually, I've jumped the gun by saying OK for 4.8. Please hold off on the 4.8 backport until one of the release maintainers says its OK. Richie can we take this now or do you want us to hold off? Please wait for 4.8.3 to be released for non-regression fixes or regression fixes that are not against a working 4.8.2. Thanks, Richard.
Re: [PATCH, AArch64] Fix for PR61202
Committed to trunk, 4.9, and waiting for the release of 4.8.3. OK for google/main and google/4.9? thanks Carrot On Wed, May 21, 2014 at 1:34 AM, Richard Biener rguent...@suse.de wrote: On Wed, 21 May 2014, Marcus Shawcroft wrote: On 21 May 2014 09:28, Marcus Shawcroft marcus.shawcr...@gmail.com wrote: On 20 May 2014 18:37, Carrot Wei car...@google.com wrote: Hi James Thank you for pointing this out. In the new patch I removed the modification of vqdmulh_n_s32 and vqdmulhq_n_s32. Passed dejagnu testing on aarch64 qemu again. OK for trunk, 4.9 and 4.8? 2014-05-20 Guozhi Wei car...@google.com * config/aarch64/arm_neon.h (vqdmulh_n_s16): Change the last operand's constraint. (vqdmulhq_n_s16): Likewise. Thank you. This is OK to commit on trunk, 4.9 and 4.8 /Marcus Actually, I've jumped the gun by saying OK for 4.8. Please hold off on the 4.8 backport until one of the release maintainers says its OK. Richie can we take this now or do you want us to hold off? Please wait for 4.8.3 to be released for non-regression fixes or regression fixes that are not against a working 4.8.2. Thanks, Richard.
Re: [PATCH, AArch64] Fix for PR61202
Since it is in trunk and gcc-4_9-branch, there is no need to put into google branches -- will get it automatically after next merge. David On Wed, May 21, 2014 at 8:13 PM, Carrot Wei car...@google.com wrote: Committed to trunk, 4.9, and waiting for the release of 4.8.3. OK for google/main and google/4.9? thanks Carrot On Wed, May 21, 2014 at 1:34 AM, Richard Biener rguent...@suse.de wrote: On Wed, 21 May 2014, Marcus Shawcroft wrote: On 21 May 2014 09:28, Marcus Shawcroft marcus.shawcr...@gmail.com wrote: On 20 May 2014 18:37, Carrot Wei car...@google.com wrote: Hi James Thank you for pointing this out. In the new patch I removed the modification of vqdmulh_n_s32 and vqdmulhq_n_s32. Passed dejagnu testing on aarch64 qemu again. OK for trunk, 4.9 and 4.8? 2014-05-20 Guozhi Wei car...@google.com * config/aarch64/arm_neon.h (vqdmulh_n_s16): Change the last operand's constraint. (vqdmulhq_n_s16): Likewise. Thank you. This is OK to commit on trunk, 4.9 and 4.8 /Marcus Actually, I've jumped the gun by saying OK for 4.8. Please hold off on the 4.8 backport until one of the release maintainers says its OK. Richie can we take this now or do you want us to hold off? Please wait for 4.8.3 to be released for non-regression fixes or regression fixes that are not against a working 4.8.2. Thanks, Richard.
Re: [PATCH, AArch64] Fix for PR61202
On Tue, May 20, 2014 at 07:18:40AM +0100, Carrot Wei wrote: Hi Hi, The last operand of instruction sqdmulh can only be low fp registers, so we should use constraint x. But the intrinsic functions use w. This patch fixed the constrains in these intrinsics. This restriction is only on the _s16 variants of the intrinsics. From the ARMv8 Architecture Reference Manual: Vm Is the name of the second SIMDFP source register, [...] Restricted to V0-V15 when element size Ts is H. The patch is correct (though I can't approve it) for vqdmulh_n_s16 and vqdmulhq_n_s16, but the two hunks for vqdmulh_n_s32 and vqdmulhq_n_s32 should be dropped as they are too restrictive. Thanks, James 2014-05-19 Guozhi Wei car...@google.com * config/aarch64/arm_neon.h (vqdmulh_n_s16): Change the last operand's constraint. (vqdmulh_n_s32): Likewise. (vqdmulhq_n_s16): Likewise. (vqdmulhq_n_s32): Likewise.
Re: [PATCH, AArch64] Fix for PR61202
Hi James Thank you for pointing this out. In the new patch I removed the modification of vqdmulh_n_s32 and vqdmulhq_n_s32. Passed dejagnu testing on aarch64 qemu again. OK for trunk, 4.9 and 4.8? 2014-05-20 Guozhi Wei car...@google.com * config/aarch64/arm_neon.h (vqdmulh_n_s16): Change the last operand's constraint. (vqdmulhq_n_s16): Likewise. On Mon, May 19, 2014 at 11:50 PM, James Greenhalgh james.greenha...@arm.com wrote: On Tue, May 20, 2014 at 07:18:40AM +0100, Carrot Wei wrote: Hi Hi, The last operand of instruction sqdmulh can only be low fp registers, so we should use constraint x. But the intrinsic functions use w. This patch fixed the constrains in these intrinsics. This restriction is only on the _s16 variants of the intrinsics. From the ARMv8 Architecture Reference Manual: Vm Is the name of the second SIMDFP source register, [...] Restricted to V0-V15 when element size Ts is H. The patch is correct (though I can't approve it) for vqdmulh_n_s16 and vqdmulhq_n_s16, but the two hunks for vqdmulh_n_s32 and vqdmulhq_n_s32 should be dropped as they are too restrictive. Thanks, James 2014-05-19 Guozhi Wei car...@google.com * config/aarch64/arm_neon.h (vqdmulh_n_s16): Change the last operand's constraint. (vqdmulh_n_s32): Likewise. (vqdmulhq_n_s16): Likewise. (vqdmulhq_n_s32): Likewise. patch Description: Binary data
