Re: [PATCH, frv-linux] Silence warning

2012-07-23 Thread nick clifton

Hi JBG,


warning: implicit declaration of function ‘frv_ifcvt_machdep_init’
warning: no previous prototype for ‘frv_ifcvt_machdep_init’


oops!


gcc/
2012-07-21  Jan-Benedict Glaw  jbg...@lug-owl.de
* config/frv/frv-protos.h: Update copyright year,
include basic-block.h (for ce_if_block_t).
(frv_ifcvt_machdep_init): Declare.


Approved - please apply.

Cheers
  Nick





Re: [PATCH, frv-linux] Silence warning

2012-07-23 Thread nick clifton

Hi JBG,


2012-07-21  Jan-Benedict Glaw  jbg...@lug-owl.de
* config/frv/frv-protos.h: Update copyright year,
include basic-block.h (for ce_if_block_t).
(frv_ifcvt_machdep_init): Declare.


Approved - please apply.


My key isn't set-up for committing to GCC (only for binutils up to
now.)  Please commit it yourself and I'll apply for
commit-after-approval rights for GCC.


Ok - I have applied a variant of your patch.  I should have noted before 
that including other headers in *-protos.h is frowned upon.  Plus in 
this case it is not necessary since the parameter to
frv_ifcvt_machdep_init is not used.  So I just made it a void * and 
updated frv.c.


Cheers
  Nick

gcc/ChangeLog
2012-07-23  Jan-Benedict Glaw  jbg...@lug-owl.de
Nick Clifton  ni...@redhat.com

* config/frv/frv-protos.h (frv_ifcvt_machdep_init): Prototype.
* config/frv/frv.c (frv_ifcvt_machdep_init): Change type of
(unused) parameter to void *.