Re: [PATCH, rs6000] Modify libgcc's float128 IFUNC resolver functions to use __builtin_cpu_supports()
On 7/10/17 2:52 PM, Peter Bergner wrote: > On 7/10/17 9:48 AM, Segher Boessenkool wrote: >> On Fri, Jul 07, 2017 at 07:14:25PM -0500, Peter Bergner wrote: >>> On 7/7/17 4:13 PM, Peter Bergner wrote: On 7/7/17 10:18 AM, Segher Boessenkool wrote: > On Thu, Jul 06, 2017 at 04:21:48PM -0500, Peter Bergner wrote: >> * config/rs6000/float128-ifunc.c: Don't include auxv.h. >> (have_ieee_hw_p): Delete function. >> (SW_OR_HW) Use __builtin_cpu_supports(). > > Okay for trunk. Thanks! Given Florian wants this in now to fix a Fedora blocker, I have committed this to trunk. We need the fix on GCC 6 and GCC 5 as well, so ok there assuming bootstrapping / regtesting are clean? >>> >>> FYI, the bootstrap and regtesting were clean on both the GCC 7 and >>> GCC 6 release branches. Ok for those branches? >> >> Okay for 7 and 6. If it is a blocker (or you have another reason you >> cannot wait to see if regressions pop up), please make sure you test it >> on many different systems. > > The backports bootstrapped and regtested with no regressions on > powerpc64le-linux and powerpc64-linux, while running the testsuite > in both 32-bit and 64-bit modes. > > I am heading off to Paris on vacation later today, and will return on > the 19th. I will commit this when I return. Backports to GCC 7 and GCC 6 release branches have now been committed. Peter
Re: [PATCH, rs6000] Modify libgcc's float128 IFUNC resolver functions to use __builtin_cpu_supports()
On 7/10/17 9:48 AM, Segher Boessenkool wrote: > On Fri, Jul 07, 2017 at 07:14:25PM -0500, Peter Bergner wrote: >> On 7/7/17 4:13 PM, Peter Bergner wrote: >>> On 7/7/17 10:18 AM, Segher Boessenkool wrote: On Thu, Jul 06, 2017 at 04:21:48PM -0500, Peter Bergner wrote: > * config/rs6000/float128-ifunc.c: Don't include auxv.h. > (have_ieee_hw_p): Delete function. > (SW_OR_HW) Use __builtin_cpu_supports(). Okay for trunk. Thanks! >>> >>> Given Florian wants this in now to fix a Fedora blocker, I have >>> committed this to trunk. We need the fix on GCC 6 and GCC 5 as >>> well, so ok there assuming bootstrapping / regtesting are clean? >> >> FYI, the bootstrap and regtesting were clean on both the GCC 7 and >> GCC 6 release branches. Ok for those branches? > > Okay for 7 and 6. If it is a blocker (or you have another reason you > cannot wait to see if regressions pop up), please make sure you test it > on many different systems. The backports bootstrapped and regtested with no regressions on powerpc64le-linux and powerpc64-linux, while running the testsuite in both 32-bit and 64-bit modes. I am heading off to Paris on vacation later today, and will return on the 19th. I will commit this when I return. Peter
Re: [PATCH, rs6000] Modify libgcc's float128 IFUNC resolver functions to use __builtin_cpu_supports()
On Fri, Jul 07, 2017 at 07:14:25PM -0500, Peter Bergner wrote: > On 7/7/17 4:13 PM, Peter Bergner wrote: > > On 7/7/17 10:18 AM, Segher Boessenkool wrote: > >> On Thu, Jul 06, 2017 at 04:21:48PM -0500, Peter Bergner wrote: > >>> * config/rs6000/float128-ifunc.c: Don't include auxv.h. > >>> (have_ieee_hw_p): Delete function. > >>> (SW_OR_HW) Use __builtin_cpu_supports(). > >> > >> Okay for trunk. Thanks! > > > > Given Florian wants this in now to fix a Fedora blocker, I have > > committed this to trunk. We need the fix on GCC 6 and GCC 5 as > > well, so ok there assuming bootstrapping / regtesting are clean? > > FYI, the bootstrap and regtesting were clean on both the GCC 7 and > GCC 6 release branches. Ok for those branches? Okay for 7 and 6. If it is a blocker (or you have another reason you cannot wait to see if regressions pop up), please make sure you test it on many different systems. Segher
Re: [PATCH, rs6000] Modify libgcc's float128 IFUNC resolver functions to use __builtin_cpu_supports()
On 7/7/17 4:13 PM, Peter Bergner wrote: > On 7/7/17 10:18 AM, Segher Boessenkool wrote: >> On Thu, Jul 06, 2017 at 04:21:48PM -0500, Peter Bergner wrote: >>> * config/rs6000/float128-ifunc.c: Don't include auxv.h. >>> (have_ieee_hw_p): Delete function. >>> (SW_OR_HW) Use __builtin_cpu_supports(). >> >> Okay for trunk. Thanks! > > Given Florian wants this in now to fix a Fedora blocker, I have > committed this to trunk. We need the fix on GCC 6 and GCC 5 as > well, so ok there assuming bootstrapping / regtesting are clean? FYI, the bootstrap and regtesting were clean on both the GCC 7 and GCC 6 release branches. Ok for those branches? Peter
Re: [PATCH, rs6000] Modify libgcc's float128 IFUNC resolver functions to use __builtin_cpu_supports()
On 7/7/17 10:18 AM, Segher Boessenkool wrote: > On Thu, Jul 06, 2017 at 04:21:48PM -0500, Peter Bergner wrote: >> * config/rs6000/float128-ifunc.c: Don't include auxv.h. >> (have_ieee_hw_p): Delete function. >> (SW_OR_HW) Use __builtin_cpu_supports(). > > Okay for trunk. Thanks! Given Florian wants this in now to fix a Fedora blocker, I have committed this to trunk. We need the fix on GCC 6 and GCC 5 as well, so ok there assuming bootstrapping / regtesting are clean? Peter
Re: [PATCH, rs6000] Modify libgcc's float128 IFUNC resolver functions to use __builtin_cpu_supports()
On Thu, Jul 06, 2017 at 04:21:48PM -0500, Peter Bergner wrote: > * config/rs6000/float128-ifunc.c: Don't include auxv.h. > (have_ieee_hw_p): Delete function. > (SW_OR_HW) Use __builtin_cpu_supports(). Okay for trunk. Thanks! Segher
Re: [PATCH, rs6000] Modify libgcc's float128 IFUNC resolver functions to use __builtin_cpu_supports()
On 07/06/2017 11:21 PM, Peter Bergner wrote: > I will note that this patch causes issues in some tests in the GLIBC > testsiute, > which Tulio is working on fixing (it's a GLIBC issue, not a GCC issue), so if > this patch is "ok", I plan on holding off on committing this, until the GLIBC > fix is committed. This issue currently blocks Fedora rawhide development. I would prefer if we could move this forward despite temporary glibc test suite failures. Thanks, Florian
