Re: [PATCH] Fix PR46399 - missing mode promotion for libcall args - updated

2011-05-04 Thread Bernd Schmidt
On 04/18/2011 10:26 AM, Andreas Krebbel wrote:
 If it is not for ABI differences anymore what's the reason for
 handling libcalls differently from normal calls anymore?  Couldn't we
 get rid of all the special handling and deal with them like normal
 calls?

That would be desirable IMO.


Bernd



Re: [PATCH] Fix PR46399 - missing mode promotion for libcall args - updated

2011-04-18 Thread Andreas Krebbel
 The problem is quite real, it's just bitten us with some ARM changes.
 The fact that we don't have types for libcall function args is very
 unfortunate. Maybe that's something we need to change? It would be a
 much better fix, and it might not even be _that_ much work to add an
 optional type field to each optab entry, which could then be passed to
 emit_library_call - if it's nonnull, we'd use the normal
 promote_function_mode hook otherwise ignore the problem as before. This
 would allow us to solve the s390 problem reasonably quickly and lets us
 add more libcall types later.

If it is not for ABI differences anymore what's the reason for
handling libcalls differently from normal calls anymore?  Couldn't we
get rid of all the special handling and deal with them like normal
calls?

Bye,

-Andreas-