Re: [PATCH] arc: add exceptions for PR92860.

2020-06-29 Thread Martin Liška

On 6/27/20 12:59 AM, Jeff Law wrote:

On Wed, 2020-06-24 at 09:43 +0200, Martin Liška wrote:

Hey.

The patch is about addition of some exceptions for arc target that
address:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92860#c26

It's again another example where optimization options influence target
options.

Ready for master?
Martin

gcc/ChangeLog:

PR tree-optimization/92860
* optc-save-gen.awk: Add exceptions for arc target.

It doens't look like you're explicitly handling the OPT_mmillicode case.  Was
that intentional?  Regardless, this patch is OK as-is or with the millicode 
stuff
added.


Yes, it's a target mask and this one are not checked:

#define MASK_MILLICODE_THUNK_SET (1U << 12)

I'm going to install the patch as is.
Martin



jeff








Re: [PATCH] arc: add exceptions for PR92860.

2020-06-26 Thread Jeff Law via Gcc-patches
On Wed, 2020-06-24 at 09:43 +0200, Martin Liška wrote:
> Hey.
> 
> The patch is about addition of some exceptions for arc target that
> address:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92860#c26
> 
> It's again another example where optimization options influence target
> options.
> 
> Ready for master?
> Martin
> 
> gcc/ChangeLog:
> 
>   PR tree-optimization/92860
>   * optc-save-gen.awk: Add exceptions for arc target.
It doens't look like you're explicitly handling the OPT_mmillicode case.  Was
that intentional?  Regardless, this patch is OK as-is or with the millicode 
stuff
added.

jeff
>