Re: [PATCH 3/3] Use startswith in targets.
On Thu, May 13, 2021 at 11:00 AM Martin Liška wrote: > > May I please ping this? OK. Please watch for fallout. Richard. > Martin > > On 3/19/21 10:21 AM, Martin Liska wrote: > > > > gcc/ChangeLog: > > > > * common/config/aarch64/aarch64-common.c (aarch64_parse_extension): > > Use startswith function instead of strncmp. > > * common/config/bfin/bfin-common.c (bfin_handle_option): Likewise. > > * common/config/riscv/riscv-common.c (riscv_subset_list::parse): > > Likewise. > > * config/aarch64/aarch64-sve-builtins-shapes.cc (parse_type): > > Likewise. > > * config/aarch64/aarch64.c (aarch64_process_one_target_attr): > > Likewise. > > * config/alpha/alpha.c (alpha_elf_section_type_flags): Likewise. > > * config/arm/aarch-common.c (arm_md_asm_adjust): Likewise. > > * config/arm/arm.c (arm_file_start): Likewise. > > (arm_valid_target_attribute_rec): Likewise. > > (thumb1_md_asm_adjust): Likewise. > > * config/arm/driver-arm.c (host_detect_local_cpu): Likewise. > > * config/avr/avr.c (STR_PREFIX_P): Likewise. > > (avr_set_current_function): Likewise. > > (avr_handle_addr_attribute): Likewise. > > (avr_asm_output_aligned_decl_common): Likewise. > > (avr_asm_named_section): Likewise. > > (avr_section_type_flags): Likewise. > > (avr_asm_select_section): Likewise. > > * config/c6x/c6x.c (c6x_in_small_data_p): Likewise. > > (c6x_section_type_flags): Likewise. > > * config/darwin-c.c (darwin_cfstring_ref_p): Likewise. > > (darwin_objc_declare_unresolved_class_reference): Likewise. > > (darwin_objc_declare_class_definition): Likewise. > > * config/darwin.c (indirect_data): Likewise. > > (darwin_encode_section_info): Likewise. > > (darwin_objc2_section): Likewise. > > (darwin_objc1_section): Likewise. > > (machopic_select_section): Likewise. > > (darwin_globalize_label): Likewise. > > (darwin_label_is_anonymous_local_objc_name): Likewise. > > (darwin_asm_named_section): Likewise. > > (darwin_asm_output_dwarf_offset): Likewise. > > * config/frv/frv.c (frv_string_begins_with): Likewise. > > (frv_in_small_data_p): Likewise. > > * config/gcn/mkoffload.c (STR): Likewise. > > (main): Likewise. > > * config/i386/i386-builtins.c (get_builtin_code_for_version): > > Likewise. > > * config/i386/i386-options.c (ix86_option_override_internal): > > Likewise. > > * config/i386/i386.c (x86_64_elf_section_type_flags): Likewise. > > (ix86_md_asm_adjust): Likewise. > > * config/i386/intelmic-mkoffload.c (STR): Likewise. > > * config/i386/winnt.c (i386_pe_asm_named_section): Likewise. > > (i386_pe_file_end): Likewise. > > * config/ia64/ia64.c (ia64_in_small_data_p): Likewise. > > (ia64_section_type_flags): Likewise. > > * config/mips/driver-native.c (host_detect_local_cpu): Likewise. > > * config/mips/mips.c (mips_handle_interrupt_attr): Likewise. > > (mips16_stub_function_p): Likewise. > > (mips_function_rodata_section): Likewise. > > * config/msp430/msp430.c (msp430_mcu_name): Likewise. > > (msp430_function_section): Likewise. > > (msp430_section_type_flags): Likewise. > > (msp430_expand_helper): Likewise. > > * config/nios2/nios2.c (nios2_small_section_name_p): Likewise. > > (nios2_valid_target_attribute_rec): Likewise. > > * config/nvptx/mkoffload.c (process): Likewise. > > (STR): Likewise. > > * config/pa/som.h: Likewise. > > * config/pdp11/pdp11.c (pdp11_output_ident): Likewise. > > * config/riscv/riscv.c (riscv_elf_select_rtx_section): Likewise. > > * config/rs6000/rs6000.c (VTABLE_NAME_P): Likewise. > > (rs6000_inner_target_options): Likewise. > > * config/s390/driver-native.c (s390_host_detect_local_cpu): Likewise. > > * config/sparc/driver-sparc.c (host_detect_local_cpu): Likewise. > > * config/vax/vax.c (vax_output_int_move): Likewise. > > * config/vms/vms-ld.c (startswith): Likewise. > > (process_args): Likewise. > > (main): Likewise. > > * config/vms/vms.c: Likewise. > > --- > > gcc/common/config/aarch64/aarch64-common.c| 2 +- > > gcc/common/config/bfin/bfin-common.c | 2 +- > > gcc/common/config/riscv/riscv-common.c| 4 +- > > .../aarch64/aarch64-sve-builtins-shapes.cc| 4 +- > > gcc/config/aarch64/aarch64.c | 2 +- > > gcc/config/alpha/alpha.c | 8 +- > > gcc/config/arm/aarch-common.c | 2 +- > > gcc/config/arm/arm.c | 8 +- > > gcc/config/arm/driver-arm.c | 4 +- > > gcc/config/avr/avr.c | 25 ++-- > > gcc/config/c6x/c6x.c | 14 +- > > gcc/config/darwin-c.c | 9 +- > >
Re: [PATCH 3/3] Use startswith in targets.
May I please ping this? Martin On 3/19/21 10:21 AM, Martin Liska wrote: gcc/ChangeLog: * common/config/aarch64/aarch64-common.c (aarch64_parse_extension): Use startswith function instead of strncmp. * common/config/bfin/bfin-common.c (bfin_handle_option): Likewise. * common/config/riscv/riscv-common.c (riscv_subset_list::parse): Likewise. * config/aarch64/aarch64-sve-builtins-shapes.cc (parse_type): Likewise. * config/aarch64/aarch64.c (aarch64_process_one_target_attr): Likewise. * config/alpha/alpha.c (alpha_elf_section_type_flags): Likewise. * config/arm/aarch-common.c (arm_md_asm_adjust): Likewise. * config/arm/arm.c (arm_file_start): Likewise. (arm_valid_target_attribute_rec): Likewise. (thumb1_md_asm_adjust): Likewise. * config/arm/driver-arm.c (host_detect_local_cpu): Likewise. * config/avr/avr.c (STR_PREFIX_P): Likewise. (avr_set_current_function): Likewise. (avr_handle_addr_attribute): Likewise. (avr_asm_output_aligned_decl_common): Likewise. (avr_asm_named_section): Likewise. (avr_section_type_flags): Likewise. (avr_asm_select_section): Likewise. * config/c6x/c6x.c (c6x_in_small_data_p): Likewise. (c6x_section_type_flags): Likewise. * config/darwin-c.c (darwin_cfstring_ref_p): Likewise. (darwin_objc_declare_unresolved_class_reference): Likewise. (darwin_objc_declare_class_definition): Likewise. * config/darwin.c (indirect_data): Likewise. (darwin_encode_section_info): Likewise. (darwin_objc2_section): Likewise. (darwin_objc1_section): Likewise. (machopic_select_section): Likewise. (darwin_globalize_label): Likewise. (darwin_label_is_anonymous_local_objc_name): Likewise. (darwin_asm_named_section): Likewise. (darwin_asm_output_dwarf_offset): Likewise. * config/frv/frv.c (frv_string_begins_with): Likewise. (frv_in_small_data_p): Likewise. * config/gcn/mkoffload.c (STR): Likewise. (main): Likewise. * config/i386/i386-builtins.c (get_builtin_code_for_version): Likewise. * config/i386/i386-options.c (ix86_option_override_internal): Likewise. * config/i386/i386.c (x86_64_elf_section_type_flags): Likewise. (ix86_md_asm_adjust): Likewise. * config/i386/intelmic-mkoffload.c (STR): Likewise. * config/i386/winnt.c (i386_pe_asm_named_section): Likewise. (i386_pe_file_end): Likewise. * config/ia64/ia64.c (ia64_in_small_data_p): Likewise. (ia64_section_type_flags): Likewise. * config/mips/driver-native.c (host_detect_local_cpu): Likewise. * config/mips/mips.c (mips_handle_interrupt_attr): Likewise. (mips16_stub_function_p): Likewise. (mips_function_rodata_section): Likewise. * config/msp430/msp430.c (msp430_mcu_name): Likewise. (msp430_function_section): Likewise. (msp430_section_type_flags): Likewise. (msp430_expand_helper): Likewise. * config/nios2/nios2.c (nios2_small_section_name_p): Likewise. (nios2_valid_target_attribute_rec): Likewise. * config/nvptx/mkoffload.c (process): Likewise. (STR): Likewise. * config/pa/som.h: Likewise. * config/pdp11/pdp11.c (pdp11_output_ident): Likewise. * config/riscv/riscv.c (riscv_elf_select_rtx_section): Likewise. * config/rs6000/rs6000.c (VTABLE_NAME_P): Likewise. (rs6000_inner_target_options): Likewise. * config/s390/driver-native.c (s390_host_detect_local_cpu): Likewise. * config/sparc/driver-sparc.c (host_detect_local_cpu): Likewise. * config/vax/vax.c (vax_output_int_move): Likewise. * config/vms/vms-ld.c (startswith): Likewise. (process_args): Likewise. (main): Likewise. * config/vms/vms.c: Likewise. --- gcc/common/config/aarch64/aarch64-common.c| 2 +- gcc/common/config/bfin/bfin-common.c | 2 +- gcc/common/config/riscv/riscv-common.c| 4 +- .../aarch64/aarch64-sve-builtins-shapes.cc| 4 +- gcc/config/aarch64/aarch64.c | 2 +- gcc/config/alpha/alpha.c | 8 +- gcc/config/arm/aarch-common.c | 2 +- gcc/config/arm/arm.c | 8 +- gcc/config/arm/driver-arm.c | 4 +- gcc/config/avr/avr.c | 25 ++-- gcc/config/c6x/c6x.c | 14 +- gcc/config/darwin-c.c | 9 +- gcc/config/darwin.c | 141 +- gcc/config/frv/frv.c | 16 +- gcc/config/gcn/mkoffload.c| 10 +- gcc/config/i386/i386-builtins.c | 2 +- gcc/config/i386/i386-options.c| 2 +- gcc/config/i386/i386.c
Re: [PATCH 3/3] Use startswith in targets.
Martin Liska wrote: gcc/config/darwin-c.c | 9 +- gcc/config/darwin.c | 141 + The darwin changes are OK, looks like a nice cleanup, thanks Iain
Re: [PATCH 3/3] Use startswith in targets.
> On Mar 19, 2021, at 5:21 AM, Martin Liska wrote: > > > gcc/ChangeLog: > > ... > * config/pdp11/pdp11.c (pdp11_output_ident): Likewise. pdp11 is ok. Thanks. paul
