Re: [Patch, Fortran+gcc/doc/invoke.texi] PR48864: -Ofast implies -fno-protect parens

2011-05-04 Thread Thomas Koenig

Hi Tobias,


As the example in the PR shows, using -fno-protect parens can make a
huge difference. As -fno-protect is in the spirit of -Ofast, enable it
with that option.

Build on x86-64-linux.
OK for the trunk?


OK.

Out of curiosity: Why do you do

gfc_option.flag_protect_parens = optimize_fast ? 0 : 1;

instead of

gfc_option.flag_protect_parens = optimize_fast;

?

Thanks for the patch!

Thomas


Re: [Patch, Fortran+gcc/doc/invoke.texi] PR48864: -Ofast implies -fno-protect parens

2011-05-04 Thread Tobias Burnus

On 05/04/2011 06:43 PM, Thomas Koenig wrote:

Out of curiosity: Why do you do
   gfc_option.flag_protect_parens = optimize_fast ? 0 : 1;
instead of
  gfc_option.flag_protect_parens = optimize_fast;


I found it more clearer than  = !optimize_fast (note the !), but 
that's seemingly not the case. I thus changed it to the latter.


Committed as Rev. 173385.

Thanks for the review!

Tobias