Re: [Patch Darwin] fix missing __USER_LABEL_PREFIX__ on extended identifiers.

2012-02-15 Thread Mike Stump
On Feb 15, 2012, at 2:21 AM, Iain Sandoe wrote:
 I noticed when working on GAS for darwin that we fail to prepend the user 
 label prefix for extended identifiers.

Does this match the native compiler on the platform?  This is abi changing, and 
we can't do it, unless it mismatches the native compiler?


Re: [Patch Darwin] fix missing __USER_LABEL_PREFIX__ on extended identifiers.

2012-02-15 Thread Iain Sandoe


On 15 Feb 2012, at 17:16, Mike Stump wrote:


On Feb 15, 2012, at 2:21 AM, Iain Sandoe wrote:
I noticed when working on GAS for darwin that we fail to prepend  
the user label prefix for extended identifiers.


Does this match the native compiler on the platform?  This is abi  
changing, and we can't do it, unless it mismatches the native  
compiler?



extended identifiers are not recognized by the system gcc-4.0

for gcc-4.2.1:

$ echo  int \u00c0;  | gcc-4.2 -std=c99 -fextended-identifiers -x c  
- -S -o t.s

$ cat t.s
.section __TEXT,__text,regular,pure_instructions
.section  
__TEXT,__picsymbolstub1,symbol_stubs,pure_instructions,32

.machine ppc7400
.comm _À,4,2
.subsections_via_symbols

---^ .. this is what prompted me to make the fix.

So, this just brings us into line with the current system compiler.

AFAICT: clang does not yet support them.

As for whether it's useful/compatible with earlier tool-chains -  
apparently usable for Darwin 9 [there can't be any instances in system  
components there, since the system compiler is 4.0].


so - apply or not?
Iain


Re: [Patch Darwin] fix missing __USER_LABEL_PREFIX__ on extended identifiers.

2012-02-15 Thread Mike Stump
On Feb 15, 2012, at 9:38 AM, Iain Sandoe wrote:
 So, this just brings us into line with the current system compiler.

Ah, the patch is ok.  Perfect, thanks.