Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On Thu, Jan 28, 2016 at 02:19:09PM +0100, Markus Trippelsdorf wrote: > > Move the boldred class from gcc-6/changes.html to gcc.css. > > Introduce boldcyan and boldmagenta classes and use them in > > gcc-6/changes.html. > > > > Index: gcc.css > > === > > RCS file: /cvs/gcc/wwwdocs/htdocs/gcc.css,v > > retrieving revision 1.25 > > diff -u -r1.25 gcc.css > > --- gcc.css 12 Sep 2011 09:42:59 - 1.25 > > +++ gcc.css 20 Jan 2016 17:26:10 - > > @@ -49,7 +49,11 @@ > >border-width: thin; > >padding: 4px; > > } > > - > > + > > +.boldcyan{ font-weight:bold; color:cyan; } > > This color is unreadable on white background. See the notes for > -Wmisleading-indentation on http://gcc.gnu.org/gcc-6/changes.html It is not so unreadable, and +/- matches the actual color used by gcc, doesn't it? > Also the gcc homepage looks weird. The news column is much too wide and > the "Release Series and Status" to small. Yeah, the home page needs changes, not sure if we want a separate *.css file for it because it has lots of different inline styles and tweaks that need replacement in *.css with the strict setting. Jakub
Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On 2016.01.20 at 18:38 +0100, Gerald Pfeifer wrote: > On Wed, 20 Jan 2016, Jakub Jelinek wrote: > >> Content-Security-Policy: default-src 'self' http: https: > >> > >> So either we get the configuration of the web server changed, or > >> indeed we need to touch all those existing pages. > > At least the warning/error/note styles are something that multiple pages > > are using and going to use in the future, so if that could be defined in > > the main gcc.css, it would be enough. > > Done thusly. With this change, at least gcc-6/changes.html should > be fine again. > > And I can commit working my way backwards through all the other > changes.html pages over the coming couple of days. > > Gerald > > > Move the boldred class from gcc-6/changes.html to gcc.css. > Introduce boldcyan and boldmagenta classes and use them in > gcc-6/changes.html. > > Index: gcc.css > === > RCS file: /cvs/gcc/wwwdocs/htdocs/gcc.css,v > retrieving revision 1.25 > diff -u -r1.25 gcc.css > --- gcc.css 12 Sep 2011 09:42:59 - 1.25 > +++ gcc.css 20 Jan 2016 17:26:10 - > @@ -49,7 +49,11 @@ >border-width: thin; >padding: 4px; > } > - > + > +.boldcyan{ font-weight:bold; color:cyan; } This color is unreadable on white background. See the notes for -Wmisleading-indentation on http://gcc.gnu.org/gcc-6/changes.html Also the gcc homepage looks weird. The news column is much too wide and the "Release Series and Status" to small. -- Markus
Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On Wed, 20 Jan 2016, Manuel López-Ibáñez wrote: >> And I can commit working my way backwards through all the other >> changes.html pages over the coming couple of days. > wwwdocs/htdocs$ find . -name '*.html' | xargs grep --color -e " style *=" > > shows a bit more inline CSS than changes.html, unfortunately. Yes, I know. I'll also take care of the others (may just take some days for the release-specific ones, possibly a tad longer for the few others). Gerald
Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On 20 January 2016 at 17:38, Gerald Pfeifer wrote: > On Wed, 20 Jan 2016, Jakub Jelinek wrote: >>> Content-Security-Policy: default-src 'self' http: https: >>> >>> So either we get the configuration of the web server changed, or >>> indeed we need to touch all those existing pages. >> At least the warning/error/note styles are something that multiple pages >> are using and going to use in the future, so if that could be defined in >> the main gcc.css, it would be enough. > > Done thusly. With this change, at least gcc-6/changes.html should > be fine again. > > And I can commit working my way backwards through all the other > changes.html pages over the coming couple of days. wwwdocs/htdocs$ find . -name '*.html' | xargs grep --color -e " style *=" shows a bit more inline CSS than changes.html, unfortunately.
Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On Wed, 20 Jan 2016, Jakub Jelinek wrote: >> Content-Security-Policy: default-src 'self' http: https: >> >> So either we get the configuration of the web server changed, or >> indeed we need to touch all those existing pages. > At least the warning/error/note styles are something that multiple pages > are using and going to use in the future, so if that could be defined in > the main gcc.css, it would be enough. Done thusly. With this change, at least gcc-6/changes.html should be fine again. And I can commit working my way backwards through all the other changes.html pages over the coming couple of days. Gerald Move the boldred class from gcc-6/changes.html to gcc.css. Introduce boldcyan and boldmagenta classes and use them in gcc-6/changes.html. Index: gcc.css === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc.css,v retrieving revision 1.25 diff -u -r1.25 gcc.css --- gcc.css 12 Sep 2011 09:42:59 - 1.25 +++ gcc.css 20 Jan 2016 17:26:10 - @@ -49,7 +49,11 @@ border-width: thin; padding: 4px; } - + +.boldcyan{ font-weight:bold; color:cyan; } +.boldmagenta { font-weight:bold; color:magenta; } +.boldred { font-weight:bold; color:red; } + /* Classpath versus libgcj merge status page. */ .classpath-only { background-color: #AA; } Index: gcc-6/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/changes.html,v retrieving revision 1.49 diff -u -r1.49 changes.html --- gcc-6/changes.html 19 Jan 2016 22:42:16 - 1.49 +++ gcc-6/changes.html 20 Jan 2016 17:26:10 - @@ -3,11 +3,6 @@ GCC 6 Release Series — Changes, New Features, and Fixes - - .boldred { font-weight:bold; color:red; } - - @@ -80,9 +75,9 @@ In addition, there is now initial support for precise diagnostic locations within strings: -format-strings.c:3:14: warning: field width specifier '*' expects a matching 'int' argument [-Wformat=] +format-strings.c:3:14: warning: field width specifier '*' expects a matching 'int' argument [-Wformat=] printf("%*d"); -^ +^ Diagnostics can now contain "fix-it hints", which are displayed in context underneath the relevant source code. For example: @@ -126,12 +121,12 @@ https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2014-1266";>CVE-2014-1266: sslKeyExchange.c: In function 'SSLVerifySignedServerKeyExchange': -sslKeyExchange.c:631:8: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation] -goto fail; -^~~~ -sslKeyExchange.c:629:4: note: ...this 'if' clause, but it is not -if ((err = SSLHashSHA1.update(&hashCtx, &signedParams)) != 0) -^~ +sslKeyExchange.c:631:8: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation] +goto fail; +^~~~ +sslKeyExchange.c:629:4: note: ...this 'if' clause, but it is not +if ((err = SSLHashSHA1.update(&hashCtx, &signedParams)) != 0) +^~ This warning is enabled by -Wall.
Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On Wed, Jan 20, 2016 at 12:40:08AM +0100, Jakub Jelinek wrote: > On Wed, Jan 20, 2016 at 12:17:36AM +0100, Gerald Pfeifer wrote: > > On Tue, 19 Jan 2016, Jakub Jelinek wrote: > > > Note, we want to tweak gcc-{4.9,5}/changes.html too, and > > > there are more colors than just red in there. > > > > Yes, I just got tired and need to log off now. > > > > > Also, seems the colors disappeared also from e.g. > > > https://gcc.gnu.org/projects/cxx1z.html > > > > Lovely. > > > > It seems gcc.gnu.org enforces a strict Content Security Policy > > (cf. > > http://www.html5rocks.com/en/tutorials/security/content-security-policy/ > > for example) which does not allow for inline CSS styles. > > > > Content-Security-Policy: default-src 'self' http: https: BTW, is that also the reason why very recently the gcc.gnu.org homepage changed layout (the News column is much wider than the Release Series and Status column), at least with Firefox 43.0? The page has: etc. Jakub
Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On Wed, Jan 20, 2016 at 12:17:36AM +0100, Gerald Pfeifer wrote: > On Tue, 19 Jan 2016, Jakub Jelinek wrote: > > Note, we want to tweak gcc-{4.9,5}/changes.html too, and > > there are more colors than just red in there. > > Yes, I just got tired and need to log off now. > > > Also, seems the colors disappeared also from e.g. > > https://gcc.gnu.org/projects/cxx1z.html > > Lovely. > > It seems gcc.gnu.org enforces a strict Content Security Policy > (cf. http://www.html5rocks.com/en/tutorials/security/content-security-policy/ > for example) which does not allow for inline CSS styles. > > Content-Security-Policy: default-src 'self' http: https: > > So either we get the configuration of the web server changed, or > indeed we need to touch all those existing pages. At least the warning/error/note styles are something that multiple pages are using and going to use in the future, so if that could be defined in the main gcc.css, it would be enough. Jakub
Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On Tue, 19 Jan 2016, Jakub Jelinek wrote: > Note, we want to tweak gcc-{4.9,5}/changes.html too, and > there are more colors than just red in there. Yes, I just got tired and need to log off now. > Also, seems the colors disappeared also from e.g. > https://gcc.gnu.org/projects/cxx1z.html Lovely. It seems gcc.gnu.org enforces a strict Content Security Policy (cf. http://www.html5rocks.com/en/tutorials/security/content-security-policy/ for example) which does not allow for inline CSS styles. Content-Security-Policy: default-src 'self' http: https: So either we get the configuration of the web server changed, or indeed we need to touch all those existing pages. Gerald
Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On Tue, Jan 19, 2016 at 11:49:27PM +0100, Gerald Pfeifer wrote: > On Tue, 19 Jan 2016, Jakub Jelinek wrote: > > Perhaps we need to use something other than ... > > and similar, the question is what. It certainly worked well back almost 3 > > years ago when I've added those into gcc-4.9/changes.html. > > And interestingly it still does when I download the page and view > it locally (Firefox 43 or Google Chrome). > > Instead of hardcoding text it makes sense > to use text which is easier (and easier > to tweak, and I just applied the patch below. Note, we want to tweak gcc-{4.9,5}/changes.html too, and there are more colors than just red in there. Also, seems the colors disappeared also from e.g. https://gcc.gnu.org/projects/cxx1z.html which has /* */ Jakub
Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On Tue, 19 Jan 2016, Jakub Jelinek wrote: > Perhaps we need to use something other than ... > and similar, the question is what. It certainly worked well back almost 3 > years ago when I've added those into gcc-4.9/changes.html. And interestingly it still does when I download the page and view it locally (Firefox 43 or Google Chrome). Instead of hardcoding text it makes sense to use text which is easier (and easier to tweak, and I just applied the patch below. Interestingly enough, same result: Looks just fine when viewed locally; https://gcc.gnu.org/gcc-6/changes.html in the browser does not show the color, though it validates. :-( Hmm. Gerald Index: changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/changes.html,v retrieving revision 1.48 diff -u -r1.48 changes.html --- changes.html19 Jan 2016 17:48:53 - 1.48 +++ changes.html19 Jan 2016 22:41:22 - @@ -2,6 +2,10 @@ GCC 6 Release Series — Changes, New Features, and Fixes + + + .boldred { font-weight:bold; color:red; } + fixits.c: In function 'bad_deref': -fixits.c:11:13: error: 'ptr' is a pointer; did you mean to use '->'? - return ptr.x; - ^ - -> +fixits.c:11:13: error: 'ptr' is a pointer; did you mean to use '->'? + return ptr.x; + ^ + -> The C and C++ compilers now offer suggestions for misspelled field names: -spellcheck-fields.cc:52:13: error: 'struct s' has no member named 'colour'; did you mean 'color'? - return ptr->colour; - ^~ +spellcheck-fields.cc:52:13: error: 'struct s' has no member named 'colour'; did you mean 'color'? + return ptr->colour; + ^~ New command-line options have been added for the C and C++ compilers: @@ -135,9 +139,9 @@ The C and C++ compilers now emit saner error messages if merge-conflict markers are present in a source file. -test.c:3:1: error: version control conflict marker in file - <<< HEAD - ^~~ +test.c:3:1: error: version control conflict marker in file + <<< HEAD + ^~~ @@ -454,7 +458,7 @@ provide suggestions for misspelled command line options. $ gcc -static-libfortran test.f95 -gcc: error: unrecognized command line option '-static-libfortran'; did you mean '-static-libgfortran'? +gcc: error: unrecognized command line option '-static-libfortran'; did you mean '-static-libgfortran'? The --enable-default-pie configure option enables generation of PIE by default.
Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On 01/19/2016 10:05 PM, Manuel López-Ibáñez wrote: > Am I the only one who doesn't see the colors at > https://gcc.gnu.org/gcc-6/changes.html#c-family nor > https://gcc.gnu.org/gcc-5/changes.html#fortran ? > > Firefox 43.0.4 says "Content Security Policy: The page's settings blocked the > loading of a resource at self ("default-src https://gcc.gnu.org http: > https:")." This problem also reproduces with Chrome Version "47.0.2526.106 unknown (64-bit)". The error message says: "Refused to apply inline style because it violates the following Content Security Policy directive: "default-src 'self' http: https:". Either the 'unsafe-inline' keyword, a hash ('sha256-8f935d27GvUutRyY9yWScUMiFUk4WTdZURISiYfPOeQ='), or a nonce ('nonce-...') is required to enable inline execution. Note also that 'style-src' was not explicitly set, so 'default-src' is used as a fallback." I think, this can be fixed by replacing 'style="color:red"' with 'class="..."' and adding the corresponding CSS class to the stylesheet. -- Regards, Mikhail Maltsev
Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On Tue, Jan 19, 2016 at 07:42:53PM +, Manuel López-Ibáñez wrote: > On 19 January 2016 at 19:31, Mike Stump wrote: > > On Jan 19, 2016, at 11:05 AM, Manuel López-Ibáñez > > wrote: > >> > >> Am I the only one who doesn't see the colors at > >> https://gcc.gnu.org/gcc-6/changes.html#c-family nor > >> https://gcc.gnu.org/gcc-5/changes.html#fortran ? > > > > Yes. The darkslategrey of the headings is very close to black, but the > > links should be blue. > > Those colors are fine but the example diagnostics should also have > colors. They had when I added them some months ago. Perhaps we need to use something other than ... and similar, the question is what. It certainly worked well back almost 3 years ago when I've added those into gcc-4.9/changes.html. Jakub
Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On 19 January 2016 at 19:31, Mike Stump wrote: > On Jan 19, 2016, at 11:05 AM, Manuel López-Ibáñez > wrote: >> >> Am I the only one who doesn't see the colors at >> https://gcc.gnu.org/gcc-6/changes.html#c-family nor >> https://gcc.gnu.org/gcc-5/changes.html#fortran ? > > Yes. The darkslategrey of the headings is very close to black, but the links > should be blue. Those colors are fine but the example diagnostics should also have colors. They had when I added them some months ago.
Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On Jan 19, 2016, at 11:05 AM, Manuel López-Ibáñez wrote: > > Am I the only one who doesn't see the colors at > https://gcc.gnu.org/gcc-6/changes.html#c-family nor > https://gcc.gnu.org/gcc-5/changes.html#fortran ? Yes. The darkslategrey of the headings is very close to black, but the links should be blue. > Firefox 43.0.4 says "Content Security Policy: The page's settings blocked the > loading of a resource at self ("default-src https://gcc.gnu.org http: > https:").” Just hit clear and then reload, and see if it comes back. Don’t think it will.
Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On 19/01/16 17:08, Gerald Pfeifer wrote: On Fri, 15 Jan 2016, David Malcolm wrote: Here's an updated version of the above, which the W3C validator reports as being clean (fixing various "&" and "<" and a missing end-tag). Nice - and a lot of nice changes you implemented since GCC 5! Am I the only one who doesn't see the colors at https://gcc.gnu.org/gcc-6/changes.html#c-family nor https://gcc.gnu.org/gcc-5/changes.html#fortran ? Firefox 43.0.4 says "Content Security Policy: The page's settings blocked the loading of a resource at self ("default-src https://gcc.gnu.org http: https:")." Cheers, Manuel.
Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)
On Fri, 15 Jan 2016, David Malcolm wrote: > Here's an updated version of the above, which the W3C validator > reports as being clean (fixing various "&" and "<" and a missing > end-tag). Nice - and a lot of nice changes you implemented since GCC 5! > OK to commit? Yep. I was going to flag "misspelled" as being misspelt, but my dictionary tells me you can actually say both. ;-) Gerald