Re: gcc/DATESTAMP wasn't updated since 20240507
Richard Biener writes: > On Thu, 9 May 2024, Jakub Jelinek wrote: > >> On Thu, May 09, 2024 at 12:14:43PM +0200, Jakub Jelinek wrote: >> > On Thu, May 09, 2024 at 12:04:38PM +0200, Rainer Orth wrote: >> > > I just noticed that gcc/DATESTAMP wasn't updated yesterday and today, >> > > staying at 20240507. >> > >> > I think it is because of the r15-268 commit, we do support >> > This reverts commit ... >> > when the referenced commit contains a ChangeLog message, but here >> > it doesn't, as it is a revert commit. >> >> Indeed and also the r15-311 commit. >> Please don't Revert Revert, we don't really support that, had to fix it all >> by hand. > > I do wonder if we can run the ChangeLog processing checks as part of > the pre-commit hook and reject such pushes. It seems we have two > implementations, one in the pre-commit hook and the processing itself > rather than having a single implementation that can run in two modes? Unfortunately, the datestamp is again stuck at 20240509. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: gcc/DATESTAMP wasn't updated since 20240507
On Thu, 9 May 2024, Jakub Jelinek wrote: > On Thu, May 09, 2024 at 12:14:43PM +0200, Jakub Jelinek wrote: > > On Thu, May 09, 2024 at 12:04:38PM +0200, Rainer Orth wrote: > > > I just noticed that gcc/DATESTAMP wasn't updated yesterday and today, > > > staying at 20240507. > > > > I think it is because of the r15-268 commit, we do support > > This reverts commit ... > > when the referenced commit contains a ChangeLog message, but here > > it doesn't, as it is a revert commit. > > Indeed and also the r15-311 commit. > Please don't Revert Revert, we don't really support that, had to fix it all > by hand. I do wonder if we can run the ChangeLog processing checks as part of the pre-commit hook and reject such pushes. It seems we have two implementations, one in the pre-commit hook and the processing itself rather than having a single implementation that can run in two modes? Sorry for the trouble. Richard.
Re: gcc/DATESTAMP wasn't updated since 20240507
On Thu, May 09, 2024 at 12:14:43PM +0200, Jakub Jelinek wrote: > On Thu, May 09, 2024 at 12:04:38PM +0200, Rainer Orth wrote: > > I just noticed that gcc/DATESTAMP wasn't updated yesterday and today, > > staying at 20240507. > > I think it is because of the r15-268 commit, we do support > This reverts commit ... > when the referenced commit contains a ChangeLog message, but here > it doesn't, as it is a revert commit. Indeed and also the r15-311 commit. Please don't Revert Revert, we don't really support that, had to fix it all by hand. Jakub
Re: gcc/DATESTAMP wasn't updated since 20240507
On Thu, May 09, 2024 at 12:04:38PM +0200, Rainer Orth wrote: > I just noticed that gcc/DATESTAMP wasn't updated yesterday and today, > staying at 20240507. I think it is because of the r15-268 commit, we do support This reverts commit ... when the referenced commit contains a ChangeLog message, but here it doesn't, as it is a revert commit. Jakub
