Re: move default_tree_printer out of toplev.c

2012-04-25 Thread Richard Guenther 
On Tue, 24 Apr 2012, Manuel López-Ibáñez wrote:

 It seems an obvious cleanup to me.
 
 OK?
 
 2012-04-24  Manuel López-Ibáñez  m...@gcc.gnu.org
 
 gcc/
   * tree-pretty-print.h (default_tree_printer): Do not declare.
   * tree-diagnostic.c: Include tree-pretty-print.h, tree-pass.h and
   intl.h.
   (default_tree_diagnostic_starter): Make static.
   (default_tree_printer): Move to here. Make static.
   (tree_diagnostics_defaults): New.
   * tree-diagnostic.h (default_tree_diagnostic_starter): Do not declare.
   * tree.c (free_lang_data): Use tree_diagnostics_defaults.

Bogus changelog - you changed general_init.

   * toplev.c: Do not include tree-pass.h.
   (default_tree_printer): Move from here.
   (general_init): Use tree_diagnostics_defaults.

Otherwise ok.

Thanks,
Richard.

Re: move default_tree_printer out of toplev.c

2012-04-25 Thread Manuel López-Ibáñez 
On 25 April 2012 10:27, Richard Guenther rguent...@suse.de wrote:
 On Tue, 24 Apr 2012, Manuel López-Ibáñez wrote:

 It seems an obvious cleanup to me.

 OK?

 2012-04-24  Manuel López-Ibáñez  m...@gcc.gnu.org

 gcc/
       * tree-pretty-print.h (default_tree_printer): Do not declare.
       * tree-diagnostic.c: Include tree-pretty-print.h, tree-pass.h and
       intl.h.
       (default_tree_diagnostic_starter): Make static.
       (default_tree_printer): Move to here. Make static.
       (tree_diagnostics_defaults): New.
       * tree-diagnostic.h (default_tree_diagnostic_starter): Do not declare.
       * tree.c (free_lang_data): Use tree_diagnostics_defaults.

 Bogus changelog - you changed general_init.

Not sure what you mean. I changed tree.c (free_lang_data) and toplev.c
(general_init). to use tree_diagnostics_defaults. What should I have
said in the Changelog?

Cheers,

Manuel.

Re: move default_tree_printer out of toplev.c

2012-04-25 Thread Richard Guenther 
On Wed, 25 Apr 2012, Manuel López-Ibáñez wrote:

 On 25 April 2012 10:27, Richard Guenther rguent...@suse.de wrote:
  On Tue, 24 Apr 2012, Manuel López-Ibáñez wrote:
 
  It seems an obvious cleanup to me.
 
  OK?
 
  2012-04-24  Manuel López-Ibáñez  m...@gcc.gnu.org
 
  gcc/
        * tree-pretty-print.h (default_tree_printer): Do not declare.
        * tree-diagnostic.c: Include tree-pretty-print.h, tree-pass.h and
        intl.h.
        (default_tree_diagnostic_starter): Make static.
        (default_tree_printer): Move to here. Make static.
        (tree_diagnostics_defaults): New.
        * tree-diagnostic.h (default_tree_diagnostic_starter): Do not 
  declare.
        * tree.c (free_lang_data): Use tree_diagnostics_defaults.
 
  Bogus changelog - you changed general_init.
 
 Not sure what you mean. I changed tree.c (free_lang_data) and toplev.c
 (general_init). to use tree_diagnostics_defaults. What should I have
 said in the Changelog?

Oops.  Misread the patch.

Sorry for the noise,
Richard.

Re: move default_tree_printer out of toplev.c

2012-04-24 Thread Jason Merrill 

OK.

Jason