Re: Remove tilegx port

[Jeff Law via Gcc-patches]

On 9/10/2021 5:50 AM, Richard Biener via Libc-alpha wrote:

On Fri, Apr 27, 2018 at 9:32 PM Jeff Law  wrote:

On 04/27/2018 11:42 AM, Richard Biener wrote:

On April 27, 2018 7:26:19 PM GMT+02:00, Jeff Law  wrote:

On 04/27/2018 09:36 AM, Joseph Myers wrote:

Since tile support has been removed from the Linux kernel for 4.17,
this patch removes the (unmaintained) port to tilegx from glibc (the
tilepro support having been previously removed).  This reflects the
general principle that a glibc port needs upstream support for the
architecture in all the components it build-depends on (so binutils,
GCC and the Linux kernel, for the normal case of a port supporting

the

Linux kernel but no other OS), in order to be maintainable.

Apart from removal of sysdeps/tile and sysdeps/unix/sysv/linux/tile
(omitted from the diffs below), there are updates to various comments
referencing tile for which removal of those references seemed
appropriate.  The configuration is removed from README and from
build-many-glibcs.py.  contrib.texi keeps mention of removed
contributions, but I updated Chris Metcalf's entry to reflect that he
also contributed the non-removed support for the generic Linux kernel
syscall interface.  __ASSUME_FADVISE64_64_NO_ALIGN support is

removed,

as it was only used by tile.

Given tilegx/tilepro removal from the kernel and glibc, should we go
ahead and deprecate them in GCC?  The only tilegx/tilepro
configurations
are -linux.

Makes sense to me. Let's deprecate it for GCC 8 and remove from trunk.

Richard.


Jeff

Here's what I committed to the trunk and the release branch.  I'll
find/update the appropriate web page momentarily.

It's been deprecated since GCC 8 now but the port is still on trunk,
guarded by --enable-obsolete - is it time to remove it?

Definitely.  Folks have had years to complain.

If you wanted to add cr16 to the deprecated ports list, I'd fully 
support that as well.  It hasn't built since dropping cc0 and there 
doesn't appear to be anyone interested in making it work.


jeff

Re: Remove tilegx port

[Richard Biener via Gcc-patches]

On Fri, Apr 27, 2018 at 9:32 PM Jeff Law  wrote:
>
> On 04/27/2018 11:42 AM, Richard Biener wrote:
> > On April 27, 2018 7:26:19 PM GMT+02:00, Jeff Law  wrote:
> >> On 04/27/2018 09:36 AM, Joseph Myers wrote:
> >>> Since tile support has been removed from the Linux kernel for 4.17,
> >>> this patch removes the (unmaintained) port to tilegx from glibc (the
> >>> tilepro support having been previously removed).  This reflects the
> >>> general principle that a glibc port needs upstream support for the
> >>> architecture in all the components it build-depends on (so binutils,
> >>> GCC and the Linux kernel, for the normal case of a port supporting
> >> the
> >>> Linux kernel but no other OS), in order to be maintainable.
> >>>
> >>> Apart from removal of sysdeps/tile and sysdeps/unix/sysv/linux/tile
> >>> (omitted from the diffs below), there are updates to various comments
> >>> referencing tile for which removal of those references seemed
> >>> appropriate.  The configuration is removed from README and from
> >>> build-many-glibcs.py.  contrib.texi keeps mention of removed
> >>> contributions, but I updated Chris Metcalf's entry to reflect that he
> >>> also contributed the non-removed support for the generic Linux kernel
> >>> syscall interface.  __ASSUME_FADVISE64_64_NO_ALIGN support is
> >> removed,
> >>> as it was only used by tile.
> >> Given tilegx/tilepro removal from the kernel and glibc, should we go
> >> ahead and deprecate them in GCC?  The only tilegx/tilepro
> >> configurations
> >> are -linux.
> >
> > Makes sense to me. Let's deprecate it for GCC 8 and remove from trunk.
> >
> > Richard.
> >
> >> Jeff
> >
>
> Here's what I committed to the trunk and the release branch.  I'll
> find/update the appropriate web page momentarily.

It's been deprecated since GCC 8 now but the port is still on trunk,
guarded by --enable-obsolete - is it time to remove it?

Richard.

> jeff

Re: Remove tilegx port

[Jeff Law]

On 04/27/2018 11:42 AM, Richard Biener wrote:
> On April 27, 2018 7:26:19 PM GMT+02:00, Jeff Law  wrote:
>> On 04/27/2018 09:36 AM, Joseph Myers wrote:
>>> Since tile support has been removed from the Linux kernel for 4.17,
>>> this patch removes the (unmaintained) port to tilegx from glibc (the
>>> tilepro support having been previously removed).  This reflects the
>>> general principle that a glibc port needs upstream support for the
>>> architecture in all the components it build-depends on (so binutils,
>>> GCC and the Linux kernel, for the normal case of a port supporting
>> the
>>> Linux kernel but no other OS), in order to be maintainable.
>>>
>>> Apart from removal of sysdeps/tile and sysdeps/unix/sysv/linux/tile
>>> (omitted from the diffs below), there are updates to various comments
>>> referencing tile for which removal of those references seemed
>>> appropriate.  The configuration is removed from README and from
>>> build-many-glibcs.py.  contrib.texi keeps mention of removed
>>> contributions, but I updated Chris Metcalf's entry to reflect that he
>>> also contributed the non-removed support for the generic Linux kernel
>>> syscall interface.  __ASSUME_FADVISE64_64_NO_ALIGN support is
>> removed,
>>> as it was only used by tile.
>> Given tilegx/tilepro removal from the kernel and glibc, should we go
>> ahead and deprecate them in GCC?  The only tilegx/tilepro
>> configurations
>> are -linux.
> 
> Makes sense to me. Let's deprecate it for GCC 8 and remove from trunk. 
> 
> Richard. 
> 
>> Jeff
> 

Here's what I committed to the trunk and the release branch.  I'll
find/update the appropriate web page momentarily.

jeff
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 4db67b8d069..f81b09f8739 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,7 @@
+2018-04-27  Jeff Law  
+
+   * config.gcc: Mark tile* targets as deprecated/obsolete.
+
 2018-04-27  Richard Biener  
 
* config/aarch64/aarch64.c: Simplify ap.__stack advance and
diff --git a/gcc/config.gcc b/gcc/config.gcc
index e58494c1c17..a5defb0f005 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -237,6 +237,7 @@ md_file=
 # Obsolete configurations.
 case ${target} in
   powerpc*-*-*spe* \
+  | tile*-*-*  \
  )
 if test "x$enable_obsolete" != xyes; then
   echo "*** Configuration ${target} is obsolete." >&2

Re: Remove tilegx port

[Richard Biener]

On April 27, 2018 7:26:19 PM GMT+02:00, Jeff Law  wrote:
>On 04/27/2018 09:36 AM, Joseph Myers wrote:
>> Since tile support has been removed from the Linux kernel for 4.17,
>> this patch removes the (unmaintained) port to tilegx from glibc (the
>> tilepro support having been previously removed).  This reflects the
>> general principle that a glibc port needs upstream support for the
>> architecture in all the components it build-depends on (so binutils,
>> GCC and the Linux kernel, for the normal case of a port supporting
>the
>> Linux kernel but no other OS), in order to be maintainable.
>> 
>> Apart from removal of sysdeps/tile and sysdeps/unix/sysv/linux/tile
>> (omitted from the diffs below), there are updates to various comments
>> referencing tile for which removal of those references seemed
>> appropriate.  The configuration is removed from README and from
>> build-many-glibcs.py.  contrib.texi keeps mention of removed
>> contributions, but I updated Chris Metcalf's entry to reflect that he
>> also contributed the non-removed support for the generic Linux kernel
>> syscall interface.  __ASSUME_FADVISE64_64_NO_ALIGN support is
>removed,
>> as it was only used by tile.
>Given tilegx/tilepro removal from the kernel and glibc, should we go
>ahead and deprecate them in GCC?  The only tilegx/tilepro
>configurations
>are -linux.

Makes sense to me. Let's deprecate it for GCC 8 and remove from trunk. 

Richard. 

>Jeff

Re: Remove tilegx port

[Jeff Law]

On 04/27/2018 09:36 AM, Joseph Myers wrote:
> Since tile support has been removed from the Linux kernel for 4.17,
> this patch removes the (unmaintained) port to tilegx from glibc (the
> tilepro support having been previously removed).  This reflects the
> general principle that a glibc port needs upstream support for the
> architecture in all the components it build-depends on (so binutils,
> GCC and the Linux kernel, for the normal case of a port supporting the
> Linux kernel but no other OS), in order to be maintainable.
> 
> Apart from removal of sysdeps/tile and sysdeps/unix/sysv/linux/tile
> (omitted from the diffs below), there are updates to various comments
> referencing tile for which removal of those references seemed
> appropriate.  The configuration is removed from README and from
> build-many-glibcs.py.  contrib.texi keeps mention of removed
> contributions, but I updated Chris Metcalf's entry to reflect that he
> also contributed the non-removed support for the generic Linux kernel
> syscall interface.  __ASSUME_FADVISE64_64_NO_ALIGN support is removed,
> as it was only used by tile.
Given tilegx/tilepro removal from the kernel and glibc, should we go
ahead and deprecate them in GCC?  The only tilegx/tilepro configurations
are -linux.

Jeff