Re: [Geany-devel] Why Geany doesn't use exactly what is set in marker_search?

2011-09-09 Thread Lex Trotman
On 9 September 2011 15:52, Matthew Brush mbr...@codebrainz.ca wrote:
 On 09/08/2011 10:20 PM, Jean-Philippe Fleury wrote:

 Lex Trotman a écrit le 2011-09-09 00:13 :

 The markings used for mark-all searches are applied with hard coded
 alpha of 60 out of 256.


 Is that from before the color schemes support?

Que? I was referring to line 673 as you noted below.


 Thanks for your answer.

 About marker_translucency, we can read in the the manual:

 Translucency for the line marker (first argument) and the search
 marker (second argument). Values between 0 and 256 are accepted.

 How marker_translucency is applied to search marker if there's already
 a hard coded value? I tried to change values of marker_translucency,
 but it doesn't seem to change anything.


 I guess it just ignores it currently?  Seems like a bug to me.

No it applies to something else, see my other post.  But the manual
could be clearer, too many things called markers.


 FWIW, it's hardcoded here:
 http://git.geany.org/geany/tree/src/highlighting.c#n673

See lines 680  686 for where marker_translucency is used.

Cheers
Lex


 Cheers,
 Matthew Brush
 ___
 Geany-devel mailing list
 Geany-devel@uvena.de
 https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel

___
Geany-devel mailing list
Geany-devel@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel


Re: [Geany-devel] Why Geany doesn't use exactly what is set in marker_search?

2011-09-09 Thread Matthew Brush

On 09/08/2011 10:55 PM, Lex Trotman wrote:


You have marking search matches and markers confused.  Markers are the
little yellow arrow and the plus sign that appear in the margin.
Those are what is affected by the marker_translucency setting, not the
marked search matches, which is what you were comparing to gedit.  The
two values of marker_translucency are used for the arrow and the plus
respectively.  It would appear that the manual is a bit confusing
here.



Ah! thanks for clearing that up.


Just for your information, marked search matches are alpha blended
rather than just setting a background so that the text is more likely
to remain legible.  Setting a background would require you to then
check and change all highlighting that used colours close to the new
background.  In contrast so long as foreground and background are
different, alpha blending will change both so it is a likely that the
text is still visible.



This could be settable and defaulted to 60 in filetypes.common.

Something like this maybe?

# colour, fill alpha, border alpha and whether the
# inidicator is drawn over (true) or under (false) text
search_indicator=0x00;60;60;true

Maybe it's not worth coding though.

Cheers,
Matthew Brush
___
Geany-devel mailing list
Geany-devel@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel


Re: [Geany-devel] Why Geany doesn't use exactly what is set in marker_search?

2011-09-09 Thread Lex Trotman
On 9 September 2011 16:54, Matthew Brush mbr...@codebrainz.ca wrote:
 On 09/08/2011 10:55 PM, Lex Trotman wrote:

 You have marking search matches and markers confused.  Markers are the
 little yellow arrow and the plus sign that appear in the margin.
 Those are what is affected by the marker_translucency setting, not the
 marked search matches, which is what you were comparing to gedit.  The
 two values of marker_translucency are used for the arrow and the plus
 respectively.  It would appear that the manual is a bit confusing
 here.


 Ah! thanks for clearing that up.

 Just for your information, marked search matches are alpha blended
 rather than just setting a background so that the text is more likely
 to remain legible.  Setting a background would require you to then
 check and change all highlighting that used colours close to the new
 background.  In contrast so long as foreground and background are
 different, alpha blending will change both so it is a likely that the
 text is still visible.


 This could be settable and defaulted to 60 in filetypes.common.

 Something like this maybe?

        # colour, fill alpha, border alpha and whether the
        # inidicator is drawn over (true) or under (false) text
        search_indicator=0x00;60;60;true

 Maybe it's not worth coding though.

IMHO not really.

Cheers
Lex
___
Geany-devel mailing list
Geany-devel@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel


Re: [Geany-devel] Why Geany doesn't use exactly what is set in marker_search?

2011-09-09 Thread Dimitar Zhekov
On Fri, 09 Sep 2011 10:55:33 -0400
Jean-Philippe Fleury cont...@jpfleury.net wrote:

 Thanks for these precisions. However, I'm still not able to make 
 marker_translucency have any effect. See the attached screenshot. 
 There are 4 different settings for marker_translucency, but the little 
 yellow arrow and the plus sign appearing in the margin don't change.

With the Markers Margin hidden, you don't have arrow or plus, so the
entire line is highlighted instead, with background = 2nd argument of
marker_line and transluency = 1st argument of marker_translucency.
Blending the arrow or plus sign would a bit pointless.

 For each modification, I closed Geany and opened it again to be sure it
 was using new settings in my .conf.

If you open the standard geany.conf in Geany, the changes are applied
immediately on Save. At least the highlighting.

-- 
E-gards: Jimmy
___
Geany-devel mailing list
Geany-devel@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel


Re: [Geany-devel] Why Geany doesn't use exactly what is set in marker_search?

2011-09-09 Thread Dimitar Zhekov
On Fri, 9 Sep 2011 20:44:53 +0300
Dimitar Zhekov dimitar.zhe...@gmail.com wrote:

 With the Markers Margin hidden, you don't have arrow or plus, so the
 background = 2nd argument of marker_line and transluency = 1st argument
 of marker_translucency.

The above for the line marker (arrow) only. The marked lines (plus)
have background = 2nd arguments of marker_mark and marker_translucency.

-- 
E-gards: Jimmy
___
Geany-devel mailing list
Geany-devel@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel


Re: [Geany-devel] Why Geany doesn't use exactly what is set in marker_search?

2011-09-09 Thread Lex Trotman
On 10 September 2011 04:22, Jean-Philippe Fleury cont...@jpfleury.net wrote:
 Dimitar Zhekov a écrit le 2011-09-09 13:44 :

 With the Markers Margin hidden, you don't have arrow or plus, so the
 entire line is highlighted instead, with background = 2nd argument of
 marker_line and transluency = 1st argument of marker_translucency.
 Blending the arrow or plus sign would a bit pointless.

 Thanks. It could be added in the manual (applied when markers margin is
 hidden).

Yes, and the confusion over the use of the second value could be fixed.


 Unfortunately, I'm still not able to make marker_translucency have any
 effect, even when markers margin is hidden. See the attached screenshot. The
 entire line is highlighted, but the first argument of marker_translucency
 is not used.

Works for me, see attached with

marker_line = 0x00;0x00
marker_translucency=200;200

I'm not sure what else to suggest.

Cheers
Lex


 Regards,

 Jean-Philippe

 ___
 Geany-devel mailing list
 Geany-devel@uvena.de
 https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel


attachment: Screenshot-1.png___
Geany-devel mailing list
Geany-devel@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel