Re: [Geany-devel] Request: multithreaded tag generation?
On Mon, May 7, 2012 at 7:09 PM, Nick Treleaven nick.trelea...@btinternet.com wrote: On 07/11/2011 15:35, Harold Aling wrote: I recently switched from GeanyPRJ to Gproject. Since Gproject doesn't support multiple open projects I have to switch between projects, but it takes up to 4 minutes to close one project and open another. A project consists of roughly 1000-2000 php-related files. The Generate tags for all project files causes this massive delay, but I really need that feature. At work I have a 2-core CPU, where 1 is completely idle and on my desktop at home there are 5 cores are doing nothing while generating tags. Can't they be utilized to speed up the tag generation? As a workaround I wonder if the plugin could generate a temporary global tags file (with geany -g). This would be a separate thread. Then tell Geany to load the tags file - this is faster in Geany Git as it avoids resorting all global tags. We would need to add a way to remove global tags though, but this is probably straightforward. Nick I just tried another workaround: I moved all my multisite projects into ~/checkout and only made symlinks for all projects I'm currently working on to prevent huge codebases. Just like sites-available and sites-enabled in Apache configuration ... $ cat /var/www/drupal7/D7.geany | grep base_path base_path=/var/www/drupal7 $ ls -la /var/www/drupal7/sites/ | grep example lrwxrwxrwx 1 harold harold 27 Jul 2 15:34 example - /home/harold/checkout/example ... only to discover that GProject doesn't follow symlinks :( -H- ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
[Geany-devel] Crash when pasting a Zero-width space
A collegue of mine needed a zero-width space[1] for a breaking a word at a specific place in the menu of a website, so I copy/pasted mA (last character of first line, first character of next line) from the Wikipedia example, pasted it in Geany and deleted the m and the A so that there would only be a zero-width space left to copy by using ctrl-a, ctrl-c. Geany however crashed when there was only a zero-width space left in the document ;) Dunno if this is worth looking at, though ;) Cheers! Harold [1] http://en.wikipedia.org/wiki/Zero-width_space ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Crash when pasting a Zero-width space
On Tue, Jun 26, 2012 at 11:33 AM, Lex Trotman ele...@gmail.com wrote: On 26 June 2012 19:18, Harold Aling ge...@sait.nl wrote: A collegue of mine needed a zero-width space[1] for a breaking a word at a specific place in the menu of a website, so I copy/pasted mA (last character of first line, first character of next line) from the Wikipedia example, pasted it in Geany and deleted the m and the A so that there would only be a zero-width space left to copy by using ctrl-a, ctrl-c. Geany however crashed when there was only a zero-width space left in the document ;) Dunno if this is worth looking at, though ;) What version and platform? Latest git on Linux is perfectly happy with pasting and deleting the way you did, and is also happy with ctrl+shift+u200benter. Cheers Lex Ubuntu 12.04, 64bit, Geany 1.22 (git = 249f9bc) - too bad I can't copy/paste this from the GUI Will update to latest -dev and try again! -H- ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Crash when pasting a Zero-width space
On Tue, Jun 26, 2012 at 11:39 AM, Harold Aling ge...@sait.nl wrote: On Tue, Jun 26, 2012 at 11:33 AM, Lex Trotman ele...@gmail.com wrote: On 26 June 2012 19:18, Harold Aling ge...@sait.nl wrote: A collegue of mine needed a zero-width space[1] for a breaking a word at a specific place in the menu of a website, so I copy/pasted mA (last character of first line, first character of next line) from the Wikipedia example, pasted it in Geany and deleted the m and the A so that there would only be a zero-width space left to copy by using ctrl-a, ctrl-c. Geany however crashed when there was only a zero-width space left in the document ;) Dunno if this is worth looking at, though ;) What version and platform? Latest git on Linux is perfectly happy with pasting and deleting the way you did, and is also happy with ctrl+shift+u200benter. Cheers Lex Ubuntu 12.04, 64bit, Geany 1.22 (git = 249f9bc) - too bad I can't copy/paste this from the GUI Will update to latest -dev and try again! Updated to Geany 1.23 (git = 40da14b) 1. Create a new document (ctrl-n) 2. Copy/paste mA (already has a zero-width space in the middle) 3. Press 'home' 4. Press 'delete' 5. Crash - 100% CPU Geany also counts that character as 3 positions instead of 1. -H- ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Crash when pasting a Zero-width space
On Tue, Jun 26, 2012 at 12:05 PM, Lex Trotman ele...@gmail.com wrote: On 26 June 2012 20:01, Thomas Martitz thomas.mart...@student.htw-berlin.de wrote: Am 26.06.2012 11:53, schrieb Harold Aling: Updated to Geany 1.23 (git = 40da14b) 1. Create a new document (ctrl-n) 2. Copy/paste mA (already has a zero-width space in the middle) 3. Press 'home' 4. Press 'delete' 5. Crash - 100% CPU Works for me. No crash and no 100% CPU usage. Geany also counts that character as 3 positions instead of 1. Depending on your POV, this is the correct behavior (the pos field actually shows the byte offset since the start of the file, hence it's 0-based also). Yes, the column count only counts it as one though pos counts as 3. Pos is bytes, thats a scintilla definition. I would guess its something about the Ubuntu specials, just for comparison 08:47:15: Geany INFO : Geany 1.23 (git = 8187268), en_AU.UTF-8 08:47:15: Geany INFO : GTK 2.24.10, GLib 2.30.2 (From the help-debug messages GUI :) Whats yours say? 11:59:08: Geany INFO: Geany 1.23 (git = 40da14b), en_US.UTF-8 11:59:08: Geany INFO: GTK 2.24.10, GLib 2.32.3 -H- ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Request: multithreaded tag generation?
Small update as I just dist-upgraded to the latest Xubuntu and recompiled Geany and Geany-plugins from git. Opening Geany now takes 8 minutes and 41 seconds. 15:30:02: This is Geany 1.22 (git = 249f9bc). 15:38:43: Project Q7 opened. -H- ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Request: multithreaded tag generation?
Is there any way I could reproduce it here? If you find some test case with e.g. some open source project I could download and test the tag generation time, I'm sure I can get to the same times as GeanyPrj - there's no reason why GProject should be slower. Jiri, I seem to have missed this request ;) I just tried to reproduce my enormous load-times by starting with an empty Drupal 7 download and adding modules and current subsites/projects. With every extra site I copied, Geany/Gprojects takes exponentially long to open until we reach the 8 minute mark again. I work on several projects each week but I'll guess I have to delete as much files as possible to be able to start/close Geany within a couple of minutes, which still seems rather long for my 1-year-old desktop. -H- ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Porting themes (Was: Re: Request: multithreaded tag generation?)
Matthew, On Tue, Jan 3, 2012 at 17:29, Matthew Brush mbr...@codebrainz.ca wrote: I'll add your changes to geany-themes shortly, thanks! Can you define 'shortly'? :D Just checked out a fresh copy of geany-themes, expecting to find my changed dark.conf in it... -H- ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Request: multithreaded tag generation?
On Fri, Nov 11, 2011 at 22:13, Jiří Techet tec...@gmail.com wrote: Hi Harold, On Mon, Nov 7, 2011 at 16:35, Harold Aling ge...@sait.nl wrote: Dear Geany Devs, I recently switched from GeanyPRJ to Gproject. Since Gproject doesn't support multiple open projects I have to switch between projects, but it takes up to 4 minutes to close one project and open another. A project consists of roughly 1000-2000 php-related files. How much of this time is spent by opening the project and how much by closing? What time did the same take with granyprj? Just had a little time to check loading times with GeanyPRJ versus GProject. Starting Geany with 1 file open in a Drupal project with GProject enabled: 4 minutes and 1 second. Starting Geany with the same file with GeanyPRJ enabled: 23 seconds. Quitting Geany with an open Drupal project with GProject enabled: about 4 minutes. Quitting Geany with the same Drupal project with GeanyPRJ enabled: almost instant. The second time I opened the project with GProject, it only took 3 minutes, so it has some caching benefits. I'm reverting to GeanyPRJ! Too bad it causes a lag while typing, but that's way better than having to wait 4 minutes to start or quit Geany... Cheers! Harold ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Request: multithreaded tag generation?
Best whishes for all!!! On Wed, Dec 7, 2011 at 13:39, Harold Aling ge...@sait.nl wrote: On Fri, Nov 11, 2011 at 22:13, Jiří Techet tec...@gmail.com wrote: Hi Harold, On Mon, Nov 7, 2011 at 16:35, Harold Aling ge...@sait.nl wrote: Dear Geany Devs, I recently switched from GeanyPRJ to Gproject. Since Gproject doesn't support multiple open projects I have to switch between projects, but it takes up to 4 minutes to close one project and open another. A project consists of roughly 1000-2000 php-related files. How much of this time is spent by opening the project and how much by closing? Opening Geany takes 4 minutes with 2 Drupal projects active. :( To start 2012 I decided to update my Geany and Geany-plugins installs to the latest dev, which caused my colorscheme[1] to display distorted. (white background except for the active line) Restarting Geany takes more than 8 minutes so troubleshooting with my current configuration is quite the pain in the behind. I'm going to give up on Gproject and either try GeanyPRJ again or ditch project support altogether. This simply doesn't work. Cheers! Harold [1] http://code.google.com/p/geany-dark-scheme/ ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Request: multithreaded tag generation?
On Tue, Jan 3, 2012 at 12:10, Lex Trotman ele...@gmail.com wrote: On Tue, Jan 3, 2012 at 9:00 PM, Harold Aling ge...@sait.nl wrote: Best whishes for all!!! On Wed, Dec 7, 2011 at 13:39, Harold Aling ge...@sait.nl wrote: On Fri, Nov 11, 2011 at 22:13, Jiří Techet tec...@gmail.com wrote: Hi Harold, On Mon, Nov 7, 2011 at 16:35, Harold Aling ge...@sait.nl wrote: Dear Geany Devs, I recently switched from GeanyPRJ to Gproject. Since Gproject doesn't support multiple open projects I have to switch between projects, but it takes up to 4 minutes to close one project and open another. A project consists of roughly 1000-2000 php-related files. How much of this time is spent by opening the project and how much by closing? Opening Geany takes 4 minutes with 2 Drupal projects active. :( To start 2012 I decided to update my Geany and Geany-plugins installs to the latest dev, which caused my colorscheme[1] to display distorted. (white background except for the active line) Hi Harold, The latest development version of Geany has some changes in the way colour schemes work which means that some older themes may no longer work as they had. Unfortunately sometimes backward incompatible changes have to be made to continue moving forward. I understand the reason, but what I don't understand is how to port my old theme settings to the new system. Copying filetypes.php to ~/.config/geany/filedefs and editing [styling] does not work and I can't seem to find any documentation on how to fix this. 'geany-dark-scheme' seems to be abandoned as the last release was in March 2010... Any pointers on how I can re-enable my scheme for .php files? Restarting Geany takes more than 8 minutes so troubleshooting with my current configuration is quite the pain in the behind. You can use the -c option to create a new configuration directory and debug your colour schemes there. That way you can have no files and no tags during fixing but not lose your setup. I already disabled project support, so I can restart Geany without having to fetch coffee for all my collegues ;) I'm a big advocate on using Geany as editor here at work, but even Eclipse is faster and less resource-happy with tag generation. 4 minutes to open or close an application is not really acceptable for many users, including myself. I'm going to give up on Gproject and either try GeanyPRJ again or ditch project support altogether. This simply doesn't work. The standard Geany project support doesn't provide some of the nice features of these plugins, but it also doesn't tag parse your whole directory tree each startup, so performance should be ok. Tag generation is the only reason I (have to) use a project plugin. -H- ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Request: multithreaded tag generation?
On Fri, Nov 11, 2011 at 22:13, Jiří Techet tec...@gmail.com wrote: Hi Harold, On Mon, Nov 7, 2011 at 16:35, Harold Aling ge...@sait.nl wrote: Dear Geany Devs, I recently switched from GeanyPRJ to Gproject. Since Gproject doesn't support multiple open projects I have to switch between projects, but it takes up to 4 minutes to close one project and open another. A project consists of roughly 1000-2000 php-related files. How much of this time is spent by opening the project and how much by closing? Opening Geany takes 4 minutes with 2 Drupal projects active. :( What time did the same take with granyprj? Far less, but it's quite hectic here atm, so I can't do any comparisons... Haven't forgot about this though! -H- ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
[Geany-devel] Request: multithreaded tag generation?
Dear Geany Devs, I recently switched from GeanyPRJ to Gproject. Since Gproject doesn't support multiple open projects I have to switch between projects, but it takes up to 4 minutes to close one project and open another. A project consists of roughly 1000-2000 php-related files. The Generate tags for all project files causes this massive delay, but I really need that feature. At work I have a 2-core CPU, where 1 is completely idle and on my desktop at home there are 5 cores are doing nothing while generating tags. Can't they be utilized to speed up the tag generation? Cheers! Harold ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Request: multithreaded tag generation?
On Mon, Nov 7, 2011 at 17:11, Thomas Martitz thomas.mart...@student.htw-berlin.de wrote: Am 07.11.2011 17:06, schrieb Colomban Wendling: Hi, Le 07/11/2011 16:35, Harold Aling a écrit : Dear Geany Devs, I recently switched from GeanyPRJ to Gproject. Since Gproject doesn't support multiple open projects I have to switch between projects, but it takes up to 4 minutes to close one project and open another. A project consists of roughly 1000-2000 php-related files. The Generate tags for all project files causes this massive delay, but I really need that feature. At work I have a 2-core CPU, where 1 is completely idle and on my desktop at home there are 5 cores are doing nothing while generating tags. Can't they be utilized to speed up the tag generation? TL;DR: it's really not that easy. What if the indexing is done as is, but on the background with an indicator in the statusbar? -H- ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Geany Plugin Names
On Wed, Nov 2, 2011 at 15:27, Johann SAUNIER jsaunier.de...@gmail.com wrote: Unfortunately I have to admit that GeanyPRJ is indeed quite broken and lags the whole interface when enabled on a recent build of Geany. What do you mean by broken ? I must admit that I don't look closely at it as far as it works as expected :) Since 'Symbol list update frequency' (aka real time symbol parsing) got in, GeanyPRJ lags every freq miliseconds. Geany stops taking input every cycle until the cycle is done. Secondly: saving a file takes 1-2 seconds. Gproject is able to do the same (plus more) without any lags. Both plugins index in a single thread, which is a pity for multi-core PC's as it takes quite a while to open a project and index all tags. I changed from geanyprj to gproject 1-2 days ago and I'll probably never look back! -H- ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [RFC] Geany Plugin Names
On Tue, Nov 1, 2011 at 09:46, Thomas Martitz thomas.mart...@student.htw-berlin.de wrote: Am 29.10.2011 08:09, schrieb Lex Trotman: Although in my, probably poorly informed, opinion, gproject seems to encompass most of geanyprj Did anyone heck if geanyprj even works (as intended)? IIUC it's largely unmaintained since a very long time. If it turns out broken it should just be dropped. Unfortunately I have to admit that GeanyPRJ is indeed quite broken and lags the whole interface when enabled on a recent build of Geany. Does Gproject index a whole tree so that symbol and calltip autocomplete work? I can't seem to find how to enable that, so I guess not... :( Harold ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Performance issues?
On Tue, Mar 29, 2011 at 00:04, Lex Trotman ele...@gmail.com wrote: Agreed. However the patch would *always* disable updating parent, what we probably don't want (though, not really sure what it'd change). So I have modified it and committed it to SVN (r5642). Ok, oh well, as above, I'm not sure it has any consequences, lets test it and see. Ah, that is something I can help with! I'll update to the latest rev first thing tomorrow morning... -tnx!- Harold ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Performance issues?
On Wed, Mar 23, 2011 at 13:49, Lex Trotman ele...@gmail.com wrote: By reading the code I think you mean editor preferences, completions tab, symbol list update frequency set to zero. Yup, that fixed the lag! But it also diabled the real-time parser, which was a welcome addition. Can this be fixed somehow? Thats a bit harder, probably Yura, the plugin writer will need to take a look at the problem I'd say. Could it be that the real-time parser reparses all files in the project instead of just the current file? In the mean time, I'll just disable the real time parsing. -H- ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Performance issues?
On Wed, Mar 23, 2011 at 14:12, Colomban Wendling lists@herbesfolles.org wrote: In the mean time, I'll just disable the real time parsing. You can try increasing the minimal delay between two updates to reduce the lag (the very preference you set to 0). Doing so will reduce the realtimeness of the tag parsing, but should improve the performances. Maybe the default delay of 250ms should be changed to a longer one, 250 being too aggressive... Even when not triggered that often, the lag is really annoying... Reminds me of the Eclipse editor an ex-collegue of mine used: the ultimate test for blind typing! Eclipse was always one word behind... ;) I use geany for it's speed and simplicity, a lag doesn't fit in that description. -H- ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Performance issues?
On Wed, Mar 23, 2011 at 14:50, Lex Trotman ele...@gmail.com wrote: Even when not triggered that often, the lag is really annoying... Reminds me of the Eclipse editor an ex-collegue of mine used: the ultimate test for blind typing! Eclipse was always one word behind... ;) Its very mean saying Geany is like Eclipse [tantrum] :-( I didn't say that! I said the lag introduced by geanyprj reminded me of a laggy Eclipse which was really slow on it's own, even without the aid of a plugin ;) I use geany for it's speed and simplicity, a lag doesn't fit in that description. Sigh, plugin systems are great because they allow anyone to add functionality that they want. Sigh, plugin systems are a problem because they allow anyone to add functionality any way they want. :-) The Geany team doesn't have the resources to manage all the plugins and ensure that they fit the philosophy or how well they are implemented and maintained. But Geany still gets the blame :-( That is indeed the downside of plugins, but I can't imagine Geany without it. -H- ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
[Geany-devel] Feature request: Comment selection
Drea devs,
In my new job I'm also working with css files and html-templating with
inline php. I just instinctly selected a bit of css and pressed ctrl-e
to comment that, but the whole line got commented instead.
A simple line of css:
.front #content .element-count-2 #block-block-1 { width: 250px; height: 135px;}
Select the width statement:
.front #content .element-count-2 #block-block-1 { [width: 250px;]
height: 135px;}
Press ctrl-e
Expected result:
.front #content .element-count-2 #block-block-1 { /* [width: 250px;]
*/ height: 135px;}
Actual result:
/*
.front #content .element-count-2 #block-block-1 { [width: 250px;]
height: 135px;}
*/
Looks to me like a nice Geany addition! ;)
-H-
___
Geany-devel mailing list
Geany-devel@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
[Geany-devel] Movement keys not working in VTE without loaded file(s)
Dear Geany devs, In Geany 0.19.1 the Movement keys are non-functional in the VTE terminal when you don't have any documents open. I haven't tried Geany 0.20 yet but a quick Google search found nothing regarding this bug... Cheers! Harold ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Movement keys not working in VTE without loaded file(s)
On Tue, Feb 15, 2011 at 13:37, Lex Trotman ele...@gmail.com wrote: On 15 February 2011 22:03, Harold Aling ge...@sait.nl wrote: Dear Geany devs, In Geany 0.19.1 the Movement keys are non-functional in the VTE terminal when you don't have any documents open. I haven't tried Geany 0.20 yet but a quick Google search found nothing regarding this bug... Works on 0.20 on Linux, what platform are you on? Geany 0.19.1 on Ubuntu 10.10. The home and end keys are disfunctional, pg up/pg down and other keys work fine. -H- ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [Patch] - Improve PHP parser (call tips)
2010/3/7 Enrico Tröger enrico.troe...@uvena.de:
On Fri, 5 Mar 2010 12:21:25 -0800 (PST), Can wrote:
Hi,
The following patch adds call tips for functions in PHP code.
The regex pattern for function parameters is not optimal, but should
work for most cases. When you have a problem, send the relevant
function definition so that I can improve the patch.
Awesome (though I still think it'd be better in thelong term to write
a C-based, real parser insteaf of fiddling with regexps).
...
For the meantime, committed.
I just found a 'bug' in the code:
function my_func($var1, $var2 = array(), $var3 = NULL) { ... } only
shows my_func($var1, $var2 = array()
So it stops at the first ) it finds instead of the real closing ).
-H-
___
Geany-devel mailing list
Geany-devel@uvena.de
http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Include auto_brace_check_dup patch?
2010/1/12 Enrico Tröger enrico.troe...@uvena.de: Good point. If I don't forget it, I'll commit the patch later this week (probably at the weekend), so it gets a more wider testing and ideally a followup patch to fix the remaining issues. Enrico, What's the status of this patch? I just checked svn and it seems it's not included yet... -tnx!- ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
[Geany-devel] Include auto_brace_check_dup patch?
Dear Geany devs, Some time ago I received the attached patch though this list (from Enrico?). I really love the added functionality to prevent duplicate automatically added quotes and brackets. Can this be added to Geany itself? Ideally this would be activated with a checkbox in prefs editor completions. -tnx!- Harold geany_auto_brace_check_dup.patch Description: Binary data ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
[Geany-devel] Fwd: PHP constants are not listed in symbol list (patch attached)
Dear Geany devs,
I've sent the email below to the wrong mailinglist, so here it is again! ;)
My apologies for those who receive this email twice...
-H-
-- Forwarded message --
From: Harold Aling ge...@sait.nl
Date: Thu, Nov 12, 2009 at 17:16
Subject: PHP constants are not listed in symbol list (patch attached)
To: Geany general discussion list ge...@uvena.de
Dear Geany devs,
I've updated Geany to the latest svn (r4424) and noticed that php
constants didn't show up in the symbol list.
I then baldly opened 'php.c' and started hacking in the regexes to get
them working again. In 'actionscript.c' the constants were part of
m,macro,macros so I decided to change that in php.c too. Constants
were showing again! ;)
I also remove a duplicate regex and also added one in my patch to show
constants in a const NAME = 'value'; notation so all constants are
correctly parsed from this example:
?php
abstract class test {
const TEST = 'test';
}
define('TEST2', 'test');
?
Cheers!
Harold
Index: tagmanager/php.c
===
--- tagmanager/php.c (revision 4424)
+++ tagmanager/php.c (working copy)
@@ -72,12 +72,12 @@
{
addTagRegex(language, ^[ \t]*((final|abstract)[ \t]+)*class[ \t]+([ ALPHA _][ ALNUM _]*),
\\3, c,class,classes, NULL);
- addTagRegex(language, ^[ \t]*((final|abstract)[ \t]+)*class[ \t]+([ ALPHA _][ ALNUM _]*),
- \\3, c,class,classes, NULL);
addTagRegex(language, ^[ \t]*interface[ \t]+([ ALPHA _][ ALNUM _]*),
\\1, i,interface,interfaces, NULL);
addTagRegex(language, ^[ \t]*define[ \t]*\\([ \t]*['\]?([ ALPHA _][ ALNUM _]*),
- \\1, d,define,constant definitions, NULL);
+ \\1, m,macro,macros, NULL);
+ addTagRegex(language, ^[ \t]*const[ \t]*([ ALPHA _][ ALNUM _]*)[ \t]*[=;],
+ \\1, m,macro,macros, NULL);
addTagRegex(language, ^[ \t]*((public|protected|private|static)[ \t]+)*function[ \t]+?[ \t]*([ ALPHA _][ ALNUM _]*),
\\3, f,function,functions, NULL);
addTagRegex(language, ^[ \t]*(\\$|::\\$|\\$this-)([ ALPHA _][ ALNUM _]*)[ \t]*=,
___
Geany-devel mailing list
Geany-devel@uvena.de
http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
