Re: [Geany-devel] [Patch] - Fix keyboard accelerator on Resave Missing File dialog.
On Thu, 4 Mar 2010 08:15:44 +1100, Lex wrote: On 2 March 2010 22:41, Eugene Arshinov earshi...@gmail.com wrote: On Tue, 2 Mar 2010 13:07:55 +1100% Lex Trotman ele...@gmail.com wrote: On 2 March 2010 09:53, Can Koy can...@ymail.com wrote: OK, you send a patch then. Well, since the question is Try to resave the file? I'd suggest that GTK_STOCK_YES and GTK_STOCK_NO be used since they are a more direct answer to the question than apply/cancel are. And that makes the mnemonics different. What do others think? I completely agree. Yes/no is more natural in this case. Best regards, Eugene. Nick pointed out in another post that this is contrary to the Gnome HIG and it requires reading the text to answer correctly. He suggests that the accept/yes should be _Save to indicate what should be done. This agrees with the example save alert given in the HIG which has: Close _without saving, _Cancel and _Save as the buttons. Done. The HIG also points out that the question should be in the primary text, the secondary text is for extra information. So I suggest that there be no secondary text and primary text be File \%s\ was not found on disk,\ntry to resave? Done. I think this way it should be best. If not, complain :). Regards, Enrico -- Get my GPG key from http://www.uvena.de/pub.asc pgp3TLJQivrht.pgp Description: PGP signature ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [Patch] - Fix keyboard accelerator on Resave Missing File dialog.
From: Lex Trotman ele...@gmail.com To: Geany development list geany-devel@uvena.de Sent: Tue, March 2, 2010 4:28:34 AM Subject: Re: [Geany-devel] [Patch] - Fix keyboard accelerator on Resave Missing File dialog. Can, BTW I have never even seen this dialog, so for finding it, and noticing the inconsistency, and trying to do something about it you deserve thanks for the effort. Lex, I'm not searching for things to fix/improve in Geany per se. As I've stated in my introduction mail, I've opted for fulfilling my needs which are mostly about keyboard usage; I favor keep-hands-on-keyboard scheme while editing. That dialog appears when the file corresponding to a document is renamed or deleted outside Geany. Thanks, bye. ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [Patch] - Fix keyboard accelerator on Resave Missing File dialog.
On Tue, 2 Mar 2010 13:07:55 +1100% Lex Trotman ele...@gmail.com wrote: On 2 March 2010 09:53, Can Koy can...@ymail.com wrote: OK, you send a patch then. Well, since the question is Try to resave the file? I'd suggest that GTK_STOCK_YES and GTK_STOCK_NO be used since they are a more direct answer to the question than apply/cancel are. And that makes the mnemonics different. What do others think? I completely agree. Yes/no is more natural in this case. Best regards, Eugene. ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
[Geany-devel] [Patch] - Fix keyboard accelerator on Resave Missing File dialog.
This patch fixes keyboard accelerator on Resave Missing File dialog. From 842a01d51bf215e98d46a97951c7e68f82759858 Mon Sep 17 00:00:00 2001 From: Can Koy can...@ymail.com Date: Mon, 1 Mar 2010 20:08:57 +0200 Subject: [PATCH 3/3] Fix keyboard accelerator on Resave Missing File dialog. --- src/document.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/document.c b/src/document.c index 29a4c41..8cc6e62 100644 --- a/src/document.c +++ b/src/document.c @@ -2954,7 +2954,7 @@ static gboolean monitor_resave_missing_file(GeanyDocument *doc) gint ret; ret = dialogs_show_prompt(NULL, - GTK_STOCK_CLOSE, GTK_RESPONSE_CLOSE, + _(Cl_ose), GTK_RESPONSE_CLOSE, GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL, GTK_STOCK_SAVE, GTK_RESPONSE_ACCEPT, _(Try to resave the file?), -- 1.6.3.3 ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [Patch] - Fix keyboard accelerator on Resave Missing File dialog.
On 2 March 2010 05:25, Can Koy can...@ymail.com wrote: This patch fixes keyboard accelerator on Resave Missing File dialog. I have a couple of problems with this patch, sorry if they applied to some of your previous ones but I didn't have time to look at them before. 1. Terminology only, this is changing the mnemonic, not the keyboard accelerator, although the GTK docs are not totally consistent about it :-) A mnemonic is the character you type (usually with Alt) to activate a visible menu or dialog item and must be unique only within a single menu or dialog, a keyboard accelerator is a keycode (like ctrl-shift-w) that activates functionality directly, visible or not and must be globally unique within Geany. 2. The standard mnemonic for close is always 'c' which is adhered to in most applications and other Geany dialogs, but this patch is changing this one from the standard, this is not good user interface practice, if 'c' clashes then the other should be changed, its 'closes' mnemonic 3. by changing it from the stock item there is no icon associated with the button, again non-standard and won't match the other buttons Cheers Lex ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [Patch] - Fix keyboard accelerator on Resave Missing File dialog.
OK, you send a patch then. --- On Mon, 3/1/10, Lex Trotman ele...@gmail.com wrote: From: Lex Trotman ele...@gmail.com Subject: Re: [Geany-devel] [Patch] - Fix keyboard accelerator on Resave Missing File dialog. To: Geany development list geany-devel@uvena.de Date: Monday, March 1, 2010, 9:55 PM On 2 March 2010 05:25, Can Koy can...@ymail.com wrote: This patch fixes keyboard accelerator on Resave Missing File dialog. I have a couple of problems with this patch, sorry if they applied to some of your previous ones but I didn't have time to look at them before. 1. Terminology only, this is changing the mnemonic, not the keyboard accelerator, although the GTK docs are not totally consistent about it :-) A mnemonic is the character you type (usually with Alt) to activate a visible menu or dialog item and must be unique only within a single menu or dialog, a keyboard accelerator is a keycode (like ctrl-shift-w) that activates functionality directly, visible or not and must be globally unique within Geany. 2. The standard mnemonic for close is always 'c' which is adhered to in most applications and other Geany dialogs, but this patch is changing this one from the standard, this is not good user interface practice, if 'c' clashes then the other should be changed, its 'closes' mnemonic 3. by changing it from the stock item there is no icon associated with the button, again non-standard and won't match the other buttons Cheers Lex ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel -Inline Attachment Follows- ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
