Re: [Geany-devel] Creating ~/.config/geany/filedefs/filetypes.* files - Re: ANN: Configurable build beta in trunk
On Thu, 3 Sep 2009 13:44:29 +1000 Lex Trotman ele...@gmail.com wrote: SVN version should now only save config files when needed. I now vaguely remember knowing about the problem, certainly I had made the function that reads the build commands dialog return a bool true if anything changed. But I did nothing with it (TODO list failure?), so now its used. Great, thanks :) Regards, Nick ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Creating ~/.config/geany/filedefs/filetypes.* files - Re: ANN: Configurable build beta in trunk
Nick, Enrico, SVN version should now only save config files when needed. I now vaguely remember knowing about the problem, certainly I had made the function that reads the build commands dialog return a bool true if anything changed. But I did nothing with it (TODO list failure?), so now its used. Cheers Lex ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Creating ~/.config/geany/filedefs/filetypes.* files - Re: ANN: Configurable build beta in trunk
On Tue, 1 Sep 2009 15:39:09 +0100, Nick wrote: On Tue, 1 Sep 2009 15:37:51 +0100 Nick Treleaven nick.trelea...@btinternet.com wrote: I just noticed that all user filetypes files are always created and saved, just by quitting Geany. The previous behaviour was to only create/save a filetypes file if the user had pressed OK in the Build Commands dialog *for that filetype*. Could this be implemented? Yes. I think it should be, but its mildly non-trivial. It would require extra fields in GeanyFiletypesPrivate (? and GeanyFiletype ?) to record if any of the regexes are changed so that writting of the file can be prevented only if the regex isn't changed. And the dialogs need additions to set them. That's not necessary IMO - surely if the dialog is never shown or Cancel is pressed, nothing is changed? We could just set a private flag for the filetype if OK was clicked. Obviously this way you may get a false positive if the user didn't change anything and just pressed OK but this makes it much easier to implement and avoids a lot of unnecessary files on disk. I fully agree here. The previous behaviour where only real changes were written into user config files were better. Regards, Enrico -- Get my GPG key from http://www.uvena.de/pub.asc pgpo1EjlYqS1J.pgp Description: PGP signature ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Creating ~/.config/geany/filedefs/filetypes.* files - Re: ANN: Configurable build beta in trunk
2009/9/2 Enrico Tröger enrico.troe...@uvena.de: On Tue, 1 Sep 2009 15:39:09 +0100, Nick wrote: On Tue, 1 Sep 2009 15:37:51 +0100 Nick Treleaven nick.trelea...@btinternet.com wrote: I just noticed that all user filetypes files are always created and saved, just by quitting Geany. The previous behaviour was to only create/save a filetypes file if the user had pressed OK in the Build Commands dialog *for that filetype*. Could this be implemented? Yes. I think it should be, but its mildly non-trivial. As I said above, it should be implemented!! It would require extra fields in GeanyFiletypesPrivate (? and GeanyFiletype ?) to record if any of the regexes are changed so that writting of the file can be prevented only if the regex isn't changed. And the dialogs need additions to set them. That's not necessary IMO - surely if the dialog is never shown or Cancel is pressed, nothing is changed? We could just set a private flag for the filetype if OK was clicked. Obviously this way you may get a false positive if the user didn't change anything and just pressed OK but this makes it much easier to implement and avoids a lot of unnecessary files on disk. If this is ok, then happy to use simpler solution :-) I fully agree here. The previous behaviour where only real changes were written into user config files were better. Regards, Enrico -- Get my GPG key from http://www.uvena.de/pub.asc ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
