[Gegl-developer] Mysterious GEGL git behaviour; removing gegl-sampler-sharp.[ch] also removes test XML files
I am in the process of creating a patch to add various GSoC 2009 samplers. I also want to remove the deprecated samples YAFR and sharp. Removing gegl-sampler-yafr.* did not have any side-effect. However, removing gegl-sampler-sharp.* also resulted in the gallery xml files being removed (all the OpenRaster*.xml files) even though there appears to be no explicit reference to the sharp sampler in the gallery or below. Can anyone provide an explanation or workaround? Should I just provide the patch even though it removes the OpenRaster*.xml files? Adam Turcotte ___ Gegl-developer mailing list Gegl-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer
[Gegl-developer] GSoC: Three new patches
Hello. I have recently posted three patches to Bugzilla: I have created a new sampler (Nohalobox) [Bug 588016]. I have rewritten gegl_buffer_void () and left in the existing code so the z==0 case can be properly handled [Bug 587631]. I have made some small bug fixes to gegl-buffer.c [Bug 552658]. Improvements to Nohalobox are coming shortly. Adam Turcotte ___ Gegl-developer mailing list Gegl-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer
Re: [Gegl-developer] Passing parameter to sampler from XML file
On Tue, Jul 7, 2009 at 11:31 AM, Øyvind Kolåsislew...@gmail.com wrote: I would feel more comfortable if this parameter was not exposed, but rather that sane presets were added and given names. In most cases the additional properties of for instance a displacement map operation might be visual and conceptual clutter getting in the users way. When it comes to naming it; I think perhaps smoothing is a good candidate. I decided to tentatively implement this using a type field as with cubic. However, It appears to me that type is never actually set to anything other than cubic during initialization. How can I actually specify the type that I want to use? Adam Turcotte ___ Gegl-developer mailing list Gegl-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer
Re: [Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers
On Mon, Jun 29, 2009 at 4:47 PM, Martin Nordholtsense...@gmail.com wrote: It'll be fine to put it in gegl-matrix.c I have added the typedef, but now I have the issue of adding this GeglMatrix2 as a property of the sampler. I notice that there are g_object_class_install_property ( ) lines that use g_param_spec_pointer () and g_param_spec_object () to specify a GParamSpec. What is the correct method call for a GeglMatrix2? Adam Turcotte ___ Gegl-developer mailing list Gegl-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer
[Gegl-developer] Use of Static Arrays in Nohalo Level 2
I will be implementing Nohalo Level 2 for GEGL. This basically involves computing double-density pixel data (with a specialized version of Nohalo Level 1 minus the finishing bilinear) and then running a slightly modified version of Nohalo Level 1. The simplest way of implementing this is by having a small persistent array or buffer storing double-density pixel data locally so that the required values from Level 1 are not recomputed over and over. I originally thought that I could simply use GeglBuffers for this purpose, but the GeglBuffer code seems fairly complicated. Instead, I believe that small static arrays could be a better choice. For example, a 64x64 double-density data array can be computed with the buffer data corresponding to a context_rect/fetch_rectangle of size 35x35. When the currently stored static array does not contain the Level 1 data needed to compute the Level 2 value at the current location, it would simply be recomputed, much like they are in gegl_sampler_get_ptr (in gegl-sampler.c). Does anyone have a more elegant solution? Any objection to the use of static arrays for this purpose? Adam Turcotte ___ Gegl-developer mailing list Gegl-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer
Re: [Gegl-developer] API change for samplers to pass inverse Jacobian data to samplers
On Mon, Jun 29, 2009 at 3:44 PM, Martin Nordholtsense...@gmail.com wrote: Since GeglMatrix3 exists, GeglMatrix2 also should exist for consistency. Should GeglMatrix2 also reside within gegl-matrix.c, or should it be separate? I can quickly create GeglMatrix2 for the purposes of passing Jacobian information. Adam Turcotte ___ Gegl-developer mailing list Gegl-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer
[Gegl-developer] Cleaning up gegl_buffer_void
it. Also, there was no reason to increment bufy if the break happens, as it is reset to 0 at the beginning of the for-loop, so I swapped the order. z 0 --- - All the if-statements are automatically TRUE, so I removed them. - The last two if-statements lead to BREAKs, meaning that the while-loops NEVER actually loop, so I replaced the while-loops with if-statements. - Since the while-loops are now if-statements, bufx and bufy are never incremented, so they are ALWAYS 0 and have therefore been removed. Since they are 0, we only ever compare width and height to 0. Also, since they are the only reason we compute offsety and offsetx, those variables have been removed. - The only line that actually seems to perform an action is gegl_tile_source_command. So if width = 0 it never executes, and if height =0, it REALLY never executes because it never even checks if width 0. Because of this, the entire for-loop is useless unless they're both positive, so this check has been moved around the for-loop. Adam Turcotte ___ Gegl-developer mailing list Gegl-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer
