date:20170113

Re: [gem5-dev] changeset in gem5: syscall_emul: add support for x86 statfs syst...

2017-01-13 Thread Andreas Hansson

Hi Tony,

As a way of avoiding breakage, how about using OpenBSD (or similar) on a
VM in VirtualBox. It does not cost any $$ and Bjoern may even be able to
help set it up(?). It would be good to have such a setup available for
anyone who’s patches are likely to cause problems on BSD (i.e. anything
involving syscalls). If it works there, OSX should be fine. For now it
would be good to get things building again, even if that means reverting
temporarily. Makes sense?

I do not know how to best solve the bigger issue of “forking” the
functionality based on the underlying OS. Do we really need to have the
bits that would not work on BSD? If so, then perhaps just a
syscall_linux.cc/hh and then a single ifdef?

Andreas


On 12/01/2017, 17:01, "gem5-dev on behalf of Gutierrez, Anthony"
 wrote:

>We do not have access to BSD or OSX, so unless somebody can give Brandon
>access to such a machine he would have no way to test any potential fix.
>
>From a high level, the only easy solution I see is to guard OS-specific
>code with #ifdefs or something similar. It seems that if we are going to
>support more advanced OS features and syscalls in SE mode a fundamental
>refactoring of SE code may be necessary, and will require help from
>everybody. Brandon has already done a lot down this path, adding support
>for dynamic linking, pthreads, and has done a lot of refactoring here.
>
>Could somebody who is more familiar with BSD, and has access, try to come
>up with a fix? Brandon is merely adding a feature here, and the fact that
>it breaks support for some other feature is an artifact of the simulator
>design, and I don't want to put the onus on individual contributors to
>fix fundamental flaws when adding useful features. Hopefully we can come
>up with a solution as a community.
>
>-Original Message-
>From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Andreas
>Hansson
>Sent: Thursday, January 12, 2017 12:45 AM
>To: gem5 Developer List ; Potter, Brandon
>
>Cc: gem5-...@m5sim.org
>Subject: Re: [gem5-dev] changeset in gem5: syscall_emul: add support for
>x86 statfs syst...
>
>Hi Brandon,
>
>Could you have a look at this and come up with some form of solution so
>that gem5 compiles on BSD and OSX as well?
>
>Thanks,
>
>Andreas
>
>On 22/12/2016, 10:30, "gem5-dev on behalf of Bjoern A. Zeeb"
>
>wrote:
>
>>On 15 Dec 2016, at 18:17, Brandon Potter wrote:
>>
>>> changeset deaf82fd2e7c in /z/repo/gem5
>>> details: http://repo.gem5.org/gem5?cmd=changeset;node=deaf82fd2e7c
>>> description:
>>> syscall_emul: add support for x86 statfs system calls
>>>
>>
>>Does this compile on anything but Linux?   statfs.h doesn’t exists
>>elsewhere I guess?   statfs is historic and still more or less OS
>>specific.
>>
>>Did you actually implement statfs, or is this statvfs as in
>>http://pubs.opengroup.org/onlinepubs/95399/basedefs/sys/statvfs.h.h
>>tml
>>
>>?   Not sure what the linux syscall does there?
>>
>>
>>
>>> diffstat:
>>>
>>>  src/arch/x86/linux/linux.hh   |  18 ++
>>>  src/arch/x86/linux/process.cc |   2 +-
>>>  src/sim/syscall_emul.hh   |  32 ++--
>>>  3 files changed, 49 insertions(+), 3 deletions(-)
>>>
>>> diffs (110 lines):
>>>
>>> diff -r 104a404d426e -r deaf82fd2e7c src/arch/x86/linux/linux.hh
>>> --- a/src/arch/x86/linux/linux.hhThu Dec 15 13:14:41 2016 -0500
>>> +++ b/src/arch/x86/linux/linux.hhThu Dec 15 13:16:03 2016 -0500
>>> @@ -67,6 +67,24 @@
>>>  int64_t unused0[3];
>>>  } tgt_stat64;
>>>
>>> +typedef struct {
>>> +long val[2];
>>> +} tgt_fsid;
>>> +
>>> +typedef struct {
>>> +long f_type;
>>> +long f_bsize;
>>> +long f_blocks;
>>> +long f_bfree;
>>> +long f_bavail;
>>> +long f_files;
>>> +long f_ffree;
>>> +tgt_fsid f_fsid;
>>> +long f_namelen;
>>> +long f_frsize;
>>> +long f_spare[5];
>>> +} tgt_statfs;
>>> +
>>>  static const int TGT_SIGHUP = 0x01;
>>>  static const int TGT_SIGINT = 0x02;
>>>  static const int TGT_SIGQUIT= 0x03;
>>> diff -r 104a404d426e -r deaf82fd2e7c src/arch/x86/linux/process.cc
>>> --- a/src/arch/x86/linux/process.ccThu Dec 15 13:14:41 2016 -0500
>>> +++ b/src/arch/x86/linux/process.ccThu Dec 15 13:16:03 2016 -0500
>>> @@ -355,7 +355,7 @@
>>>  /* 134 */ SyscallDesc("uselib", unimplementedFunc),
>>>  /* 135 */ SyscallDesc("personality", unimplementedFunc),
>>>  /* 136 */ SyscallDesc("ustat", unimplementedFunc),
>>> -/* 137 */ SyscallDesc("statfs", unimplementedFunc),
>>> +/* 137 */ SyscallDesc("statfs", statfsFunc),
>>>  /* 138 */ SyscallDesc("fstatfs", unimplementedFunc),
>>>  /* 139 */ SyscallDesc("sysfs", unimplementedFunc),
>>>  /* 140 */

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2017-01-13 Thread Cron Daemon

* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: CHANGED!
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing: CHANGED!
* build/ALPHA/tests/opt/quick/se/01.hello-2T-smt/alpha/linux/o3-timing-mt: 
CHANGED!
* build/MIPS/tests/opt/quick/se/00.hello/mips/linux/o3-timing: CHANGED!
* build/POWER/tests/opt/quick/se/00.hello/power/linux/o3-timing: CHANGED!
* build/SPARC/tests/opt/quick/se/02.insttest/sparc/linux/o3-timing: CHANGED!
* 
build/SPARC/tests/opt/quick/se/40.m5threads-test-atomic/sparc/linux/o3-timing-mp:
 CHANGED!
* build/X86/tests/opt/quick/se/00.hello/x86/linux/o3-timing: CHANGED!
* build/ARM/tests/opt/quick/se/00.hello/arm/linux/minor-timing: CHANGED!
* build/ARM/tests/opt/quick/se/00.hello/arm/linux/o3-timing: CHANGED!
* build/ARM/tests/opt/quick/se/00.hello/arm/linux/o3-timing-checker: 
CHANGED!
* build/RISCV/tests/opt/quick/se/00.hello/riscv/linux/o3-timing: CHANGED!
* build/RISCV/tests/opt/quick/se/00.hello/riscv/linux/minor-timing: CHANGED!
* 
build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64a/minor-timing: 
CHANGED!
* 
build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64d/minor-timing: 
CHANGED!
* 
build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64f/minor-timing: 
CHANGED!
* build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64f/o3-timing: 
CHANGED!
* 
build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64i/minor-timing: 
CHANGED!
* 
build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64i/simple-timing: 
CHANGED!
* 
build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64i/simple-timing-ruby:
 CHANGED!
* 
build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64m/minor-timing: 
CHANGED!
* build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64m/o3-timing: 
CHANGED!
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby: 
passed.
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-atomic: passed.
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing: passed.
* 
build/ALPHA/tests/opt/quick/se/03.learning-gem5/alpha/linux/learning-gem5-p1-simple:
 passed.
* 
build/ALPHA/tests/opt/quick/se/03.learning-gem5/alpha/linux/learning-gem5-p1-two-level:
 passed.
* 
build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-atomic: 
passed.
* 
build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-atomic-dual:
 passed.
* 
build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-timing: 
passed.
* 
build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-timing-dual:
 passed.
* build/ALPHA/tests/opt/quick/se/50.memtest/alpha/linux/memtest-ruby: 
passed.
* 
build/ALPHA/tests/opt/quick/fs/80.netperf-stream/alpha/linux/twosys-tsunami-simple-atomic:
 passed.
* build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-atomic: passed.
 * build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-timing: passed.
* build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-timing-ruby: 
passed.
* 
build/MIPS/tests/opt/quick/se/03.learning-gem5/mips/linux/learning-gem5-p1-simple:
 passed.
* 
build/MIPS/tests/opt/quick/se/03.learning-gem5/mips/linux/learning-gem5-p1-two-level:
 passed.
* build/NULL/tests/opt/quick/se/60.rubytest/null/none/rubytest-ruby: passed.
* build/NULL/tests/opt/quick/se/50.memtest/null/none/memtest: passed.
* build/NULL/tests/opt/quick/se/70.tgen/null/none/tgen-dram-ctrl: passed.
* build/NULL/tests/opt/quick/se/50.memtest/null/none/memtest-filter: passed.
* build/NULL/tests/opt/quick/se/51.memcheck/null/none/memcheck: passed.
* build/NULL/tests/opt/quick/se/70.tgen/null/none/tgen-simple-mem: passed.
* 
build/NULL_MOESI_hammer/tests/opt/quick/se/60.rubytest/null/none/rubytest-ruby-MOESI_hammer:
 passed.
* 
build/NULL_MESI_Two_Level/tests/opt/quick/se/60.rubytest/null/none/rubytest-ruby-MESI_Two_Level:
 passed.
* 
build/NULL_MOESI_CMP_directory/tests/opt/quick/se/60.rubytest/null/none/rubytest-ruby-MOESI_CMP_directory:
 passed.
* 
build/NULL_MOESI_CMP_token/tests/opt/quick/se/60.rubytest/null/none/rubytest-ruby-MOESI_CMP_token:
 passed.
* build/POWER/tests/opt/quick/se/00.hello/power/linux/simple-atomic: passed.
* build/SPARC/tests/opt/quick/se/00.hello/sparc/linux/simple-timing: passed.
* build/SPARC/tests/opt/quick/se/02.insttest/sparc/linux/simple-timing: 
passed.
* build/SPARC/tests/opt/quick/se/00.hello/sparc/linux/simple-timing-ruby: 
passed.* build/SPARC/tests/opt/quick/se/00.hello/sparc/linux/simple-atomic: 
passed.
* 
build/SPARC/tests/opt/quick/se/03.learning-gem5/sparc/linux/learning-gem5-p1-two-level:
 passed.
* build/SPARC/tests/opt/quick/se/02.insttest/sparc/linux/simple-atomic: 
passed.
* 
build/SPARC/tests/opt/quick/se/03.learning-gem5/sparc/linux/learning-gem5-p1-simple:
 passed.
*

Re: [gem5-dev] changeset in gem5: syscall_emul: add support for x86 statfs syst...

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2 matches

Site Navigation

Mail list logo

Footer information