Re: [gem5-dev] Review Request 3809: imported patch rr_arbiter_fix
> On Feb. 12, 2017, 4:50 a.m., Jieming Yin wrote: > > We also observed long packet delay in heavy-traffic workloads. Just > > curious, how much does this fix improve? I noticed the problem when the deadlock threshold that was added recently started getting triggered at very high injection rates (post-saturation) with the synthetic network traffic. It seemed odd to me that a NI could not inject for 1 cycles, however congested the network may be, as round-robin should ensure that eventually every VC at every input port should get a chance to leave the router (in the absence of a true deadlock). I didn't measure how the overall stats change now, but the deadlock counter does not trigger now even if I (try to) inject 1-flit every cycle showing that this fix works. - Tushar --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3809/#review9418 --- On Feb. 12, 2017, 4:36 a.m., Tushar Krishna wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3809/ > --- > > (Updated Feb. 12, 2017, 4:36 a.m.) > > > Review request for Default, Brad Beckmann, Jieming Yin, Matthew Poremba, and > Onur Kayiran. > > > Repository: gem5 > > > Description > --- > > ruby: fix round robin arbiter in garnet2.0 > The rr arbiter pointer in garnet was getting updated on every request, > even if there is no grant. This was leading to a huge variance in wait > time at a router at high injection rates. > This patch corrects it to update upon a grant. > > > Diffs > - > > src/mem/ruby/network/garnet2.0/SwitchAllocator.cc 79c3f6a60392 > > Diff: http://reviews.gem5.org/r/3809/diff/ > > > Testing > --- > > > Thanks, > > Tushar Krishna > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Review Request 3809: imported patch rr_arbiter_fix
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3809/ --- Review request for Default, Brad Beckmann, Jieming Yin, Matthew Poremba, and Onur Kayiran. Repository: gem5 Description --- ruby: fix round robin arbiter in garnet2.0 The rr arbiter pointer in garnet was getting updated on every request, even if there is no grant. This was leading to a huge variance in wait time at a router at high injection rates. This patch corrects it to update upon a grant. Diffs - src/mem/ruby/network/garnet2.0/SwitchAllocator.cc 79c3f6a60392 Diff: http://reviews.gem5.org/r/3809/diff/ Testing --- Thanks, Tushar Krishna ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3777: misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3777/#review9417 --- This no longer applies cleanly. I think it's probably something I screwed up when pushing all of the patches. I tried to go through and manually fix the rejections, but I'm not confident in how to do it. Could you update this diff on top of the current mainline? I'll commit it immediately once you do. Sorry for the inconvenience. - Jason Lowe-Power On Feb. 5, 2017, 1:15 p.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3777/ > --- > > (Updated Feb. 5, 2017, 1:15 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11815:357f61d007cd > --- > misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10] > > The current TLM bridge only provides a Slave Port that allows the gem5 world > to > send request to the SystemC world. This patch series refractors and cleans up > the existing code, and adds a Master Port that allows the SystemC world to > send > requests to the gem5 world. > > This patch: > * Update the README > > > Diffs > - > > util/tlm/README c10c50cb8ac9 > > Diff: http://reviews.gem5.org/r/3777/diff/ > > > Testing > --- > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3777: misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10]
> On Feb. 11, 2017, 5:43 p.m., Andreas Hansson wrote: > > I think this one did not get committed. Is that right? Oops. That was an accidental oversight. Thanks for pointing it out. - Jason --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3777/#review9415 --- On Feb. 5, 2017, 1:15 p.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3777/ > --- > > (Updated Feb. 5, 2017, 1:15 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11815:357f61d007cd > --- > misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10] > > The current TLM bridge only provides a Slave Port that allows the gem5 world > to > send request to the SystemC world. This patch series refractors and cleans up > the existing code, and adds a Master Port that allows the SystemC world to > send > requests to the gem5 world. > > This patch: > * Update the README > > > Diffs > - > > util/tlm/README c10c50cb8ac9 > > Diff: http://reviews.gem5.org/r/3777/diff/ > > > Testing > --- > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3777: misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3777/#review9415 --- Ship it! I think this one did not get committed. Is that right? - Andreas Hansson On Feb. 5, 2017, 1:15 p.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3777/ > --- > > (Updated Feb. 5, 2017, 1:15 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11815:357f61d007cd > --- > misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10] > > The current TLM bridge only provides a Slave Port that allows the gem5 world > to > send request to the SystemC world. This patch series refractors and cleans up > the existing code, and adds a Master Port that allows the SystemC world to > send > requests to the gem5 world. > > This patch: > * Update the README > > > Diffs > - > > util/tlm/README c10c50cb8ac9 > > Diff: http://reviews.gem5.org/r/3777/diff/ > > > Testing > --- > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
