Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Andreas Hansson
Great! Thanks Jason.

On 15/02/2017, 21:06, "gem5-dev on behalf of Jason Lowe-Power"
 wrote:

>I just pushed the other patch.
>
>Cheers,
>Jason
>
>On Wed, Feb 15, 2017 at 2:48 PM Brandon Potter 
>wrote:
>
>> This is an automatically generated e-mail. To reply, visit:
>> http://reviews.gem5.org/r/3813/
>>
>> On February 15th, 2017, 8:46 p.m. UTC, *Jason Lowe-Power* wrote:
>>
>> Same as http://reviews.gem5.org/r/3801?
>>
>> Thanks for pointing that out; I hadn't noticed the other review.
>>
>> I'll close this one, but can we ship the other patch now that it has
>>several ShipIts?
>>
>>
>> - Brandon
>>
>> On February 15th, 2017, 8:43 p.m. UTC, Brandon Potter wrote:
>> Review request for Default.
>> By Brandon Potter.
>>
>> *Updated Feb. 15, 2017, 8:43 p.m.*
>> *Repository: * gem5
>> Description
>>
>> Changeset 11834:8623109df37d
>> ---
>> mem: add M5_VAR_USED to comm_monitor function vars
>>
>> Diffs
>>
>>- src/mem/comm_monitor.cc (0e73ec98b6bc0758e43d0bc2cb46228acfa47313)
>>
>> View Diff 
>>
>___
>gem5-dev mailing list
>gem5-dev@gem5.org
>http://m5sim.org/mailman/listinfo/gem5-dev

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Jason Lowe-Power
I just pushed the other patch.

Cheers,
Jason

On Wed, Feb 15, 2017 at 2:48 PM Brandon Potter 
wrote:

> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3813/
>
> On February 15th, 2017, 8:46 p.m. UTC, *Jason Lowe-Power* wrote:
>
> Same as http://reviews.gem5.org/r/3801?
>
> Thanks for pointing that out; I hadn't noticed the other review.
>
> I'll close this one, but can we ship the other patch now that it has several 
> ShipIts?
>
>
> - Brandon
>
> On February 15th, 2017, 8:43 p.m. UTC, Brandon Potter wrote:
> Review request for Default.
> By Brandon Potter.
>
> *Updated Feb. 15, 2017, 8:43 p.m.*
> *Repository: * gem5
> Description
>
> Changeset 11834:8623109df37d
> ---
> mem: add M5_VAR_USED to comm_monitor function vars
>
> Diffs
>
>- src/mem/comm_monitor.cc (0e73ec98b6bc0758e43d0bc2cb46228acfa47313)
>
> View Diff 
>
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


[gem5-dev] changeset in gem5: mem, stats: fix typos in CommMonitor and Stats

2017-02-15 Thread Pierre-Yves Péneau
changeset f438fcbab00e in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=f438fcbab00e
description:
mem, stats: fix typos in CommMonitor and Stats

Signed-off-by: Pierre-Yves Péneau 
Reviewed-by: Tony Gutierrez 
Reviewed-by: Jason Lowe-Power 
Signed-off-by: Jason Lowe-Power 

Reviewed at http://reviews.gem5.org/r/3802/

diffstat:

 src/base/statistics.hh  |  4 ++--
 src/mem/comm_monitor.cc |  2 +-
 src/mem/comm_monitor.hh |  2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diffs (45 lines):

diff -r 22d08b519cb0 -r f438fcbab00e src/base/statistics.hh
--- a/src/base/statistics.hhWed Feb 15 14:56:54 2017 -0600
+++ b/src/base/statistics.hhWed Feb 15 14:59:06 2017 -0600
@@ -1359,7 +1359,7 @@
 };
 
 /**
- * Templatized storage and interface for a distrbution stat.
+ * Templatized storage and interface for a distribution stat.
  */
 class DistStor
 {
@@ -1894,7 +1894,7 @@
 }
 
 /**
- *  Add the argument distribution to the this distibution.
+ *  Add the argument distribution to the this distribution.
  */
 void add(DistBase ) { data()->add(d.data()); }
 
diff -r 22d08b519cb0 -r f438fcbab00e src/mem/comm_monitor.cc
--- a/src/mem/comm_monitor.cc   Wed Feb 15 14:56:54 2017 -0600
+++ b/src/mem/comm_monitor.cc   Wed Feb 15 14:59:06 2017 -0600
@@ -490,7 +490,7 @@
 stats.writeTransHist
 .init(params()->transaction_bins)
 .name(name() + ".writeTransHist")
-.desc("Histogram of read transactions per sample period")
+.desc("Histogram of write transactions per sample period")
 .flags(stats.disableTransactionHists ? nozero : pdf);
 
 stats.readAddrDist
diff -r 22d08b519cb0 -r f438fcbab00e src/mem/comm_monitor.hh
--- a/src/mem/comm_monitor.hh   Wed Feb 15 14:56:54 2017 -0600
+++ b/src/mem/comm_monitor.hh   Wed Feb 15 14:59:06 2017 -0600
@@ -271,7 +271,7 @@
 struct MonitorStats
 {
 
-/** Disable flag for burst length historgrams **/
+/** Disable flag for burst length histograms **/
 bool disableBurstLengthHists;
 
 /** Histogram of read burst lengths */
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


[gem5-dev] changeset in gem5: mem, misc: fix building issue with CommMonito...

2017-02-15 Thread Pierre-Yves Péneau
changeset 22d08b519cb0 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=22d08b519cb0
description:
mem, misc: fix building issue with CommMonitor (unused variables)

Signed-off-by: Pierre-Yves Péneau 
Reviewed-by: Andreas Hansson 
Reviewed-by: Jason Lowe-Power 
Signed-off-by: Jason Lowe-Power 

Reviewed at http://reviews.gem5.org/r/3801/

diffstat:

 src/mem/comm_monitor.cc |  12 
 1 files changed, 4 insertions(+), 8 deletions(-)

diffs (43 lines):

diff -r b9436a49 -r 22d08b519cb0 src/mem/comm_monitor.cc
--- a/src/mem/comm_monitor.cc   Wed Feb 15 09:28:44 2017 -0600
+++ b/src/mem/comm_monitor.cc   Wed Feb 15 14:56:54 2017 -0600
@@ -248,8 +248,6 @@
 // or even deleted when sendTiming() is called.
 const ProbePoints::PacketInfo pkt_info(pkt);
 
-const bool is_read = pkt->isRead();
-const bool is_write = pkt->isWrite();
 const bool expects_response(pkt->needsResponse() &&
 !pkt->cacheResponding());
 
@@ -274,8 +272,8 @@
 }
 
 if (successful) {
-DPRINTF(CommMonitor, "Forwarded %s request\n",
-(is_read ? "read" : (is_write ? "write" : "non read/write")));
+DPRINTF(CommMonitor, "Forwarded %s request\n", pkt->isRead() ? "read" :
+pkt->isWrite() ? "write" : "non read/write");
 stats.updateReqStats(pkt_info, false, expects_response);
 }
 return successful;
@@ -291,8 +289,6 @@
 // or even deleted when sendTiming() is called.
 const ProbePoints::PacketInfo pkt_info(pkt);
 
-bool is_read = pkt->isRead();
-bool is_write = pkt->isWrite();
 Tick latency = 0;
 CommMonitorSenderState* received_state =
 dynamic_cast(pkt->senderState);
@@ -325,8 +321,8 @@
 
 if (successful) {
 ppPktResp->notify(pkt_info);
-DPRINTF(CommMonitor, "Received %s response\n",
-(is_read ? "Read" : (is_write ? "Write" : "non read/write")));
+DPRINTF(CommMonitor, "Received %s response\n", pkt->isRead() ? "read" :
+pkt->isWrite() ?  "write" : "non read/write");
 stats.updateRespStats(pkt_info, latency, false);
 }
 return successful;
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Brandon Potter


> On Feb. 15, 2017, 8:46 p.m., Jason Lowe-Power wrote:
> > Same as http://reviews.gem5.org/r/3801?

Thanks for pointing that out; I hadn't noticed the other review.

I'll close this one, but can we ship the other patch now that it has several 
ShipIts?


- Brandon


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3813/#review9429
---


On Feb. 15, 2017, 8:43 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3813/
> ---
> 
> (Updated Feb. 15, 2017, 8:43 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11834:8623109df37d
> ---
> mem: add M5_VAR_USED to comm_monitor function vars
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.cc 0e73ec98b6bc0758e43d0bc2cb46228acfa47313 
> 
> Diff: http://reviews.gem5.org/r/3813/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Andreas Hansson


> On Feb. 15, 2017, 8:46 p.m., Andreas Hansson wrote:
> > It's not the third time this is resolved :-)
> > 
> > http://reviews.gem5.org/r/3801/
> > 
> > Jason, is there any chance you could push the aforementioned patch?

s/not/now/


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3813/#review9430
---


On Feb. 15, 2017, 8:43 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3813/
> ---
> 
> (Updated Feb. 15, 2017, 8:43 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11834:8623109df37d
> ---
> mem: add M5_VAR_USED to comm_monitor function vars
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.cc 0e73ec98b6bc0758e43d0bc2cb46228acfa47313 
> 
> Diff: http://reviews.gem5.org/r/3813/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Andreas Hansson

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3813/#review9430
---


It's not the third time this is resolved :-)

http://reviews.gem5.org/r/3801/

Jason, is there any chance you could push the aforementioned patch?

- Andreas Hansson


On Feb. 15, 2017, 8:43 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3813/
> ---
> 
> (Updated Feb. 15, 2017, 8:43 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11834:8623109df37d
> ---
> mem: add M5_VAR_USED to comm_monitor function vars
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.cc 0e73ec98b6bc0758e43d0bc2cb46228acfa47313 
> 
> Diff: http://reviews.gem5.org/r/3813/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Jason Lowe-Power

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3813/#review9429
---


Same as http://reviews.gem5.org/r/3801?

- Jason Lowe-Power


On Feb. 15, 2017, 8:43 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3813/
> ---
> 
> (Updated Feb. 15, 2017, 8:43 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11834:8623109df37d
> ---
> mem: add M5_VAR_USED to comm_monitor function vars
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.cc 0e73ec98b6bc0758e43d0bc2cb46228acfa47313 
> 
> Diff: http://reviews.gem5.org/r/3813/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


[gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Brandon Potter

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3813/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11834:8623109df37d
---
mem: add M5_VAR_USED to comm_monitor function vars


Diffs
-

  src/mem/comm_monitor.cc 0e73ec98b6bc0758e43d0bc2cb46228acfa47313 

Diff: http://reviews.gem5.org/r/3813/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request 3806: sparc: fix bugs caused by cd7f3a1dbf55

2017-02-15 Thread Tony Gutierrez

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3806/#review9428
---

Ship it!


Ship It!

- Tony Gutierrez


On Feb. 10, 2017, 12:31 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3806/
> ---
> 
> (Updated Feb. 10, 2017, 12:31 p.m.)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, and Steve Reinhardt.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11803:0ab0146d777a
> ---
> sparc: fix bugs caused by cd7f3a1dbf55
> 
> Turns out that SPARC SE mode relied on M5_pid being "0" in
> all cases. The entries in the SPARC TLBs are accessed with
> M5_pid as their context. This is buggy in the sense that it
> will never work with more than one process or any
> initialization that doesn't have the M5_pid value passed in
> as "0".
> 
> cd7f3a1dbf55 broke the SPARC build because it deletes M5_pid
> and uses a _pid with a default of "100" instead. This caused
> the SPARC TLB to never return any valid lookups for any
> request; the program never moved past the first instruction
> with SPARC SE in the regression tester.
> 
> The solution proposed in this changeset is to initialize
> the address space identification register with the PID value
> that is passed into the process class as a parameter from
> Python. This should return the correct responses from the TLB
> since the insertions and lookups into the page table will be
> using the same PID.
> 
> Furthermore, there are corner cases in the code which elevate
> privileges and revert to using context "0" as the context in
> the TLB. I believe that these are related to kernel level
> traps and hypervisor privilege escalations, but I'm not
> completely sure. I've tried to address the corner cases
> properly, but it would be beneficial to have someone who is
> familiar with the SPARC architecture to take a look at this
> fix.
> 
> 
> Diffs
> -
> 
>   src/arch/sparc/process.cc cd7f3a1dbf55bfa03b436c8cde51ebda515fbdbc 
>   src/arch/sparc/faults.cc cd7f3a1dbf55bfa03b436c8cde51ebda515fbdbc 
> 
> Diff: http://reviews.gem5.org/r/3806/diff/
> 
> 
> Testing
> ---
> 
> util/regress all
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


[gem5-dev] changeset in gem5: mem: fix assertion in respondEvent

2017-02-15 Thread Wendy Elsasser
changeset b9436a49 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=b9436a49
description:
mem: fix assertion in respondEvent

Assertion in the respondEvent erroneously fired.
The assertion verifies that the controller has not moved to a low-power
state prior to receiving read data from the memory.
The original assertion triggered if the state was not:
PWR_IDLE or PWR_ACT.

In the case that failed, a periodic refresh event occurred around the
read.  The REF is stalled until the final read burst is issued
and the subsequent PRE closes the bank.  While the PRE will temporarily
move the state to PWR_IDLE, state will immediately transition to PWR_REF
due to the pending refresh operation.  This state does not match the
assertion, which is subsequently triggered.

Fixed the assertion by explicitly checking that the state is not a low
power state
!PWR_SREF && !PWR_PRE_PDN && !PWR_ACT_PDN


Change-Id: I82921a733bbeac2bcb5a487c2f981448d41ed50b
Reviewed-by: Radhika Jagtap 

diffstat:

 src/mem/dram_ctrl.cc |  16 +---
 1 files changed, 9 insertions(+), 7 deletions(-)

diffs (37 lines):

diff -r afd6aaee268e -r b9436a49 src/mem/dram_ctrl.cc
--- a/src/mem/dram_ctrl.cc  Tue Feb 14 15:36:15 2017 -0600
+++ b/src/mem/dram_ctrl.cc  Wed Feb 15 09:28:44 2017 -0600
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010-2016 ARM Limited
+ * Copyright (c) 2010-2017 ARM Limited
  * All rights reserved
  *
  * The license below extends only to copyright in the software and shall
@@ -678,18 +678,20 @@
 // read response received, decrement count
 --dram_pkt->rankRef.outstandingEvents;
 
-// at this moment should be either ACT or IDLE depending on
-// if PRE has occurred to close all banks
-assert((dram_pkt->rankRef.pwrState == PWR_ACT) ||
-   (dram_pkt->rankRef.pwrState == PWR_IDLE));
+// at this moment should not have transitioned to a low-power state
+assert((dram_pkt->rankRef.pwrState != PWR_SREF) &&
+   (dram_pkt->rankRef.pwrState != PWR_PRE_PDN) &&
+   (dram_pkt->rankRef.pwrState != PWR_ACT_PDN));
 
 // track if this is the last packet before idling
 // and that there are no outstanding commands to this rank
-if (dram_pkt->rankRef.lowPowerEntryReady()) {
+// if REF in progress, transition to LP state should not occur
+// until REF completes
+if ((dram_pkt->rankRef.refreshState == REF_IDLE) &&
+(dram_pkt->rankRef.lowPowerEntryReady())) {
 // verify that there are no events scheduled
 assert(!dram_pkt->rankRef.activateEvent.scheduled());
 assert(!dram_pkt->rankRef.prechargeEvent.scheduled());
-assert(dram_pkt->rankRef.refreshState == REF_IDLE);
 
 // if coming from active state, schedule power event to
 // active power-down else go to precharge power-down
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Thoughts On Project Using C++14

2017-02-15 Thread Jason Lowe-Power
Hi Brandon,

I agree with Andreas. It seems to me that it is a little too soon to
require GCC 6.1. Until we're confident most people's IT infrastructure is
using more recent Linuxes, it's going to be hard to go beyond C++11.

Do you have any suggestions on how to make it simple for all of our users
to get a hold of current GCC versions? I know Docker solves this problem,
but many of us have systems that we don't have sudo privileges on.
Additionally, many compute clusters are even further behind than our
workstations in terms of Linux versions. Our cluster is still running RHEL6.

Jason

On Wed, Feb 15, 2017 at 4:22 AM Andreas Hansson 
wrote:

> Hi Brandon,
>
> I suggest we stick to a compiler/stdlib version that is already part of
> shipping LTS distros and RHE or similar. If I’m not mistaken, for Ubuntu
> that means gcc 5.3, and for RHE7 that means gcc 4.8.5.
>
> Andreas
>
> On 14/02/2017, 23:40, "gem5-dev on behalf of Potter, Brandon"
>  wrote:
>
> >Hello all,
> >
> >What is the general feeling behind bumping to C++14 instead of keeping
> >the top-level SConstruct flag at C++11? I would like to use generic
> >lambdas in some of my code, but cannot do so because it's not available
> >until C++14.
> >
> >Both GCC and clang support a full implementation of C++14 now: GCC became
> >fully compliant as of GCC 6.1 (04/27/16); clang was compliant with clang
> >3.4 (01/01/14).
> >
> >https://gcc.gnu.org/projects/cxx-status.html#cxx14
> >https://gcc.gnu.org/gcc-6/
> >https://clang.llvm.org/cxx_status.html
> >http://releases.llvm.org
> >
> >Regards,
> >Brandon
> >___
> >gem5-dev mailing list
> >gem5-dev@gem5.org
> >http://m5sim.org/mailman/listinfo/gem5-dev
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
> ___
> gem5-dev mailing list
> gem5-dev@gem5.org
> http://m5sim.org/mailman/listinfo/gem5-dev
>
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev