[gem5-dev] Change in gem5/gem5[hotfix-memorysize-division]: configs: Fix MemorySize division
Daniel Carvalho has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/37255 ) Change subject: configs: Fix MemorySize division .. configs: Fix MemorySize division The memory size is expected to be an integer. Jira: https://gem5.atlassian.net/browse/GEM5-806 Change-Id: I44b2d423a3478d2598950779222151f09970cbd8 Signed-off-by: Daniel R. Carvalho Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/37255 Maintainer: Bobby R. Bruce Tested-by: kokoro Reviewed-by: Srikant Bharadwaj --- M configs/topologies/MeshDirCorners_XY.py M configs/topologies/Mesh_XY.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Srikant Bharadwaj: Looks good to me, approved Bobby R. Bruce: Looks good to me, approved kokoro: Regressions pass diff --git a/configs/topologies/MeshDirCorners_XY.py b/configs/topologies/MeshDirCorners_XY.py index 7d065de..e0aea52 100644 --- a/configs/topologies/MeshDirCorners_XY.py +++ b/configs/topologies/MeshDirCorners_XY.py @@ -218,6 +218,6 @@ for n in numa_nodes: if n: FileSystemConfig.register_node(n, -MemorySize(options.mem_size) / num_numa_nodes, i) +MemorySize(options.mem_size) // num_numa_nodes, i) i += 1 diff --git a/configs/topologies/Mesh_XY.py b/configs/topologies/Mesh_XY.py index 64a8506..faec1e3 100644 --- a/configs/topologies/Mesh_XY.py +++ b/configs/topologies/Mesh_XY.py @@ -178,4 +178,4 @@ def registerTopology(self, options): for i in range(options.num_cpus): FileSystemConfig.register_node([i], -MemorySize(options.mem_size) / options.num_cpus, i) +MemorySize(options.mem_size) // options.num_cpus, i) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/37255 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: hotfix-memorysize-division Gerrit-Change-Id: I44b2d423a3478d2598950779222151f09970cbd8 Gerrit-Change-Number: 37255 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Carvalho Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Srikant Bharadwaj Gerrit-Reviewer: kokoro Gerrit-MessageType: merged ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
[gem5-dev] Change in gem5/gem5[develop]: misc: Updated MAINTAINERS.yaml
Bobby R. Bruce has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/37356 ) Change subject: misc: Updated MAINTAINERS.yaml .. misc: Updated MAINTAINERS.yaml Change-Id: Ibda441858a22c9e8bb22e132c165e7724aaf7539 --- M MAINTAINERS.yaml 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS.yaml b/MAINTAINERS.yaml index 8a2bf75..068da7f 100644 --- a/MAINTAINERS.yaml +++ b/MAINTAINERS.yaml @@ -63,7 +63,10 @@ - Giacomo Travaglini arch-gcn3: - status: orphaned + status: maintained + maintainers: +- Matt Poremba +- Matt Sinclair arch-mips: status: orphaned @@ -90,6 +93,7 @@ status: maintained maintainers: - Bobby Bruce +- Daniel Carvalho base-stats: status: orphaned @@ -132,7 +136,9 @@ - Gabe Black dev-hsa: - status: orphaned + status: maintained + maintainers: +- Matt Poremba dev-virtio: status: maintained @@ -175,6 +181,7 @@ status: maintained maintainers: - Matt Poremba +- Matt Sinclair learning-gem5: desc: >- @@ -196,6 +203,7 @@ status: maintained maintainers: - Nikos Nikoleris +- Daniel Carvalho mem-dram: status: maintained @@ -215,6 +223,7 @@ status: maintained maintainers: - Jason Lowe-Power +- Matt Sinclair misc: desc: >- -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/37356 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ibda441858a22c9e8bb22e132c165e7724aaf7539 Gerrit-Change-Number: 37356 Gerrit-PatchSet: 1 Gerrit-Owner: Bobby R. Bruce Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
[gem5-dev] Change in gem5/gem5[develop]: dev-arm,misc: Added missing override to scmi_platform functions
Bobby R. Bruce has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/37355 ) Change subject: dev-arm,misc: Added missing override to scmi_platform functions .. dev-arm,misc: Added missing override to scmi_platform functions The missing overrides on the "raiseInterrupt" and "clearInterrupt" resulted in compilation failures when using Clang. Change-Id: Ic77e8587cd622f8f0cb819c3230893a1b169a2a2 --- M src/dev/arm/css/scmi_platform.hh 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dev/arm/css/scmi_platform.hh b/src/dev/arm/css/scmi_platform.hh index b46cfb0..567e548 100644 --- a/src/dev/arm/css/scmi_platform.hh +++ b/src/dev/arm/css/scmi_platform.hh @@ -292,8 +292,8 @@ Port& getPort(const std::string _name, PortID idx) override; -void raiseInterrupt(const Doorbell *doorbell); -void clearInterrupt(const Doorbell *doorbell); +void raiseInterrupt(const Doorbell *doorbell) override; +void clearInterrupt(const Doorbell *doorbell) override; static uint32_t protocolID(const Message ) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/37355 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ic77e8587cd622f8f0cb819c3230893a1b169a2a2 Gerrit-Change-Number: 37355 Gerrit-PatchSet: 1 Gerrit-Owner: Bobby R. Bruce Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
[gem5-dev] Change in gem5/gem5[develop]: arch-power: Implement mcrxr
Boris Shingarov has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/37295 )
Change subject: arch-power: Implement mcrxr
..
arch-power: Implement mcrxr
Implement the mcrxr instruction (Move to Condition Register from XER
X-form) as defined on p.132 of the green-cloth book:
The contents of XER<0:3> are copied into the Condition Register field
designated by BF. XER<0:3> are set to zero.
Change-Id: I82ae3d98e1eaf9182e90c0c86afe0f13d4a052e4
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/37295
Reviewed-by: Gabe Black
Reviewed-by: Boris Shingarov
Maintainer: Gabe Black
Tested-by: kokoro
---
M src/arch/power/isa/decoder.isa
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Boris Shingarov: Looks good to me, approved
Gabe Black: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/power/isa/decoder.isa b/src/arch/power/isa/decoder.isa
index 475ddcc..f32861b 100644
--- a/src/arch/power/isa/decoder.isa
+++ b/src/arch/power/isa/decoder.isa
@@ -278,6 +278,10 @@
0x100: mtlr({{ LR = Rs; }});
0x120: mtctr({{ CTR = Rs; }});
}
+512: mcrxr({{
+CR = insertCRField(CR, BF, XER<31:28>);
+XER = XER<27:0>;
+}});
}
// All loads with an index register. The non-update versions
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/37295
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I82ae3d98e1eaf9182e90c0c86afe0f13d4a052e4
Gerrit-Change-Number: 37295
Gerrit-PatchSet: 4
Gerrit-Owner: Boris Shingarov
Gerrit-Reviewer: Boris Shingarov
Gerrit-Reviewer: Gabe Black
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-Reviewer: kokoro
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
