[gem5-dev] Change in gem5/gem5[develop]: mem: Fix Best Offset Prefetcher (BOP) learning phase code.

[a p (Gerrit) via gem5-dev]

a p has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/46259 )



Change subject: mem: Fix Best Offset Prefetcher (BOP) learning phase code.
..

mem: Fix Best Offset Prefetcher (BOP) learning phase code.

According to the DPC paper : "If the best score is less
than or equal to a fixed value BADSCORE, we turn prefetchoff
during the next phase"

However, the current code will turn prefetch off if the best
*offset* of the learning phase is less than BADSCORE, which
is incorrect.

Change-Id: Ib5790fe1341f2dd6328ec3b018bc52012e376723
---
M src/mem/cache/prefetch/bop.cc
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/mem/cache/prefetch/bop.cc b/src/mem/cache/prefetch/bop.cc
index 255b2f8..9a4afd2 100644
--- a/src/mem/cache/prefetch/bop.cc
+++ b/src/mem/cache/prefetch/bop.cc
@@ -217,7 +217,7 @@
 phaseBestOffset = 0;
 resetScores();
 issuePrefetchRequests = true;
-} else if (phaseBestOffset <= badScore) {
+} else if (bestScore <= badScore) {
 issuePrefetchRequests = false;
 }
 }

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/46259
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib5790fe1341f2dd6328ec3b018bc52012e376723
Gerrit-Change-Number: 46259
Gerrit-PatchSet: 1
Gerrit-Owner: a p 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Jenkins build is back to normal : compiler-checks #79

[jenkins-no-reply--- via gem5-dev]

See 
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s