[gem5-dev] Change in gem5/gem5[develop]: tests: Add '-vv' verbose flags to Kokoro/Nightly/Weekly tests

2021-11-28 Thread Bobby R. Bruce (Gerrit) via gem5-dev
Bobby R. Bruce has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/53305 )



Change subject: tests: Add '-vv' verbose flags to Kokoro/Nightly/Weekly  
tests

..

tests: Add '-vv' verbose flags to Kokoro/Nightly/Weekly tests

Without this verbose flag, there is no information output on the tests
currently running. Output is only given on the pass/fail status of a
test after completion. This is unhelpful if the tests fail due to a
timeout (e.g., a test has stalled).

The '-vv' verbose flags sets up the TestLib package to output when a
test has started execution. This information can help in figuring out
which test caused a timeout event to occur.

Change-Id: I14e6752d40a7c8d7189211584073ba79c88ed7d5
---
M tests/weekly.sh
M tests/jenkins/presubmit-stage2.sh
M tests/nightly.sh
3 files changed, 21 insertions(+), 3 deletions(-)



diff --git a/tests/jenkins/presubmit-stage2.sh  
b/tests/jenkins/presubmit-stage2.sh

index d4d5841..6e73394 100755
--- a/tests/jenkins/presubmit-stage2.sh
+++ b/tests/jenkins/presubmit-stage2.sh
@@ -46,5 +46,5 @@
 # Look for tests in the gem5 subdirectory
 # Once complete, run the Google Tests
 cd tests
-./main.py run -j4 -t4 gem5 && scons -C .. --no-compress-debug \
+./main.py run -j4 -t4 gem5 -vv && scons -C .. --no-compress-debug \
 build/ARM/unittests.opt
diff --git a/tests/nightly.sh b/tests/nightly.sh
index 9f69eb1..b785d55 100755
--- a/tests/nightly.sh
+++ b/tests/nightly.sh
@@ -78,7 +78,7 @@
 # Run the gem5 long tests.
 docker run -u $UID:$GID --volume "${gem5_root}":"${gem5_root}" -w \
 "${gem5_root}"/tests --rm  
gcr.io/gem5-test/ubuntu-20.04_all-dependencies \

-./main.py run --length long -j${threads} -t${threads}
+./main.py run --length long -j${threads} -t${threads} -vv

 # Run the GPU tests.
 # For the GPU tests we compile and run GCN3_X86 inside a gcn-gpu container.
diff --git a/tests/weekly.sh b/tests/weekly.sh
index 172d955..d65ee40 100755
--- a/tests/weekly.sh
+++ b/tests/weekly.sh
@@ -42,7 +42,7 @@
 # Run the gem5 very-long tests.
 docker run -u $UID:$GID --volume "${gem5_root}":"${gem5_root}" -w \
 "${gem5_root}"/tests --rm  
gcr.io/gem5-test/ubuntu-20.04_all-dependencies \

-./main.py run --length very-long -j${threads} -t${threads}
+./main.py run --length very-long -j${threads} -t${threads} -vv

 mkdir -p tests/testing-results


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/53305
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I14e6752d40a7c8d7189211584073ba79c88ed7d5
Gerrit-Change-Number: 53305
Gerrit-PatchSet: 1
Gerrit-Owner: Bobby R. Bruce 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: stdlib: Removing SingleChannelMemory

2021-11-28 Thread Mahyar Samani (Gerrit) via gem5-dev
Mahyar Samani has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/53304 )



Change subject: stdlib: Removing SingleChannelMemory
..

stdlib: Removing SingleChannelMemory

This change removes the code base for SingleChannelMemory and
replaces it with MultiChannelMemory. muli_channel defines all
the classes that were defined by single_channel. Basically any
SingleChannelMemory could be thought of as a MultiChannelMemory
with 1 channel.

Change-Id: If96079d5f77be5a3ba26d2c2ddb98f5c60375cd8
---
M configs/example/gem5_library/riscv-fs.py
M configs/example/gem5_library/arm-hello.py
M tests/gem5/configs/boot_kvm_fork_run.py
M tests/gem5/configs/parsec_disk_run.py
M tests/gem5/configs/boot_kvm_switch_exit.py
M src/python/SConscript
M configs/example/gem5_library/x86-ubuntu-run.py
M tests/gem5/configs/simple_binary_run.py
D src/python/gem5/components/memory/single_channel.py
M tests/gem5/traffic_gen/test_memory_traffic_gen.py
10 files changed, 22 insertions(+), 153 deletions(-)



diff --git a/configs/example/gem5_library/arm-hello.py  
b/configs/example/gem5_library/arm-hello.py

index 540a96b..8be714d 100644
--- a/configs/example/gem5_library/arm-hello.py
+++ b/configs/example/gem5_library/arm-hello.py
@@ -49,7 +49,7 @@
 from gem5.resources.resource import Resource
 from gem5.components.boards.simple_board import SimpleBoard
 from gem5.components.cachehierarchies.classic.no_cache import NoCache
-from gem5.components.memory.single_channel import SingleChannelDDR3_1600
+from gem5.components.memory.multi_channel import SingleChannelDDR3_1600
 from gem5.components.processors.simple_processor import SimpleProcessor
 from gem5.components.processors.cpu_types import CPUTypes

diff --git a/configs/example/gem5_library/riscv-fs.py  
b/configs/example/gem5_library/riscv-fs.py

index f46a345..d79e3bf 100644
--- a/configs/example/gem5_library/riscv-fs.py
+++ b/configs/example/gem5_library/riscv-fs.py
@@ -43,7 +43,7 @@
 from m5.objects import Root

 from gem5.components.boards.riscv_board import RiscvBoard
-from gem5.components.memory.single_channel import SingleChannelDDR3_1600
+from gem5.components.memory.multi_channel import SingleChannelDDR3_1600
 from gem5.components.processors.simple_processor import SimpleProcessor
 from gem5.components.cachehierarchies.classic.\
 private_l1_private_l2_cache_hierarchy import (
diff --git a/configs/example/gem5_library/x86-ubuntu-run.py  
b/configs/example/gem5_library/x86-ubuntu-run.py

index 1ab9f3a..95b1acd 100644
--- a/configs/example/gem5_library/x86-ubuntu-run.py
+++ b/configs/example/gem5_library/x86-ubuntu-run.py
@@ -46,7 +46,7 @@

 from gem5.utils.requires import requires
 from gem5.components.boards.x86_board import X86Board
-from gem5.components.memory.single_channel import SingleChannelDDR3_1600
+from gem5.components.memory.multi_channel import SingleChannelDDR3_1600
 from gem5.components.processors.simple_switchable_processor import (
 SimpleSwitchableProcessor,
 )
diff --git a/src/python/SConscript b/src/python/SConscript
index d210960..d457cf4 100644
--- a/src/python/SConscript
+++ b/src/python/SConscript
@@ -117,7 +117,6 @@
 PySource('gem5.components.memory', 'gem5/components/memory/__init__.py')
  
PySource('gem5.components.memory', 'gem5/components/memory/abstract_memory_system.py')

 PySource('gem5.components.memory', 'gem5/components/memory/dramsim_3.py')
-PySource('gem5.components.memory', 'gem5/components/memory/single_channel.py')
 PySource('gem5.components.memory', 'gem5/components/memory/simple.py')
  
PySource('gem5.components.memory', 'gem5/components/memory/multi_channel.py')

 PySource('gem5.components.memory.dram_interfaces',
diff --git a/src/python/gem5/components/memory/single_channel.py  
b/src/python/gem5/components/memory/single_channel.py

deleted file mode 100644
index 11a0b15..000
--- a/src/python/gem5/components/memory/single_channel.py
+++ /dev/null
@@ -1,136 +0,0 @@
-# Copyright (c) 2021 The Regents of the University of California
-# All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions are
-# met: redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer;
-# redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in the
-# documentation and/or other materials provided with the distribution;
-# neither the name of the copyright holders nor the names of its
-# contributors may be used to endorse or promote products derived from
-# this software without specific prior written permission.
-#
-# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-# LIMITED TO, THE IMPLIED WARRANTIES OF 

[gem5-dev] Change in gem5/gem5[develop]: base-stats: HDF5 calls with better compatibility

2021-11-28 Thread Chen Zou (Gerrit) via gem5-dev
Chen Zou has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/53283 )



Change subject: base-stats: HDF5 calls with better compatibility
..

base-stats: HDF5 calls with better compatibility

H5Object.getObjName() is added at HDF5 V1.8.13.
obj.getObjnameByIdx(obj.getId()) would work with older versions.

Change-Id: I104eaac050db7501ab3a1aa3ad6dc1ee8b8d7e22
---
M src/base/stats/hdf5.cc
1 file changed, 13 insertions(+), 1 deletion(-)



diff --git a/src/base/stats/hdf5.cc b/src/base/stats/hdf5.cc
index d5b7f1e..03574b2 100644
--- a/src/base/stats/hdf5.cc
+++ b/src/base/stats/hdf5.cc
@@ -257,7 +257,7 @@
 fspace = H5::DataSpace(rank, dims, max_dims.data());
 try {
 DPRINTF(Stats, "Creating dataset %s in group %s\n",
-info.name, group.getObjName());
+info.name, group.getObjnameByIdx(group.getId()));
 data_set = group.createDataSet(info.name,
 H5::PredType::NATIVE_DOUBLE, fspace, props);
 } catch (const H5::Exception ) {

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/53283
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I104eaac050db7501ab3a1aa3ad6dc1ee8b8d7e22
Gerrit-Change-Number: 53283
Gerrit-PatchSet: 1
Gerrit-Owner: Chen Zou 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s