[gem5-dev] [S] Change in gem5/gem5[develop]: stdlib: Add missing ()s in get_supported_isas.

2022-04-15 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/58929 )



Change subject: stdlib: Add missing ()s in get_supported_isas.
..

stdlib: Add missing ()s in get_supported_isas.

A function was used directly instead of being called when interating
through ISA names.

Change-Id: I9dc53259a766a68070e0b79bb55f721a93fcdeed
---
M src/python/gem5/runtime.py
1 file changed, 13 insertions(+), 1 deletion(-)



diff --git a/src/python/gem5/runtime.py b/src/python/gem5/runtime.py
index 108dfc4..0984f6f 100644
--- a/src/python/gem5/runtime.py
+++ b/src/python/gem5/runtime.py
@@ -48,7 +48,7 @@
 if "TARGET_ISA" in buildEnv.keys():
 supported_isas.add(get_isa_from_str(buildEnv["TARGET_ISA"]))
 else:
-for key in get_isas_str_set:
+for key in get_isas_str_set():
 if buildEnv[f"USE_{key.upper()}_ISA"]:
 supported_isas.add(get_isa_from_str(key))
 return supported_isas

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/58929
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I9dc53259a766a68070e0b79bb55f721a93fcdeed
Gerrit-Change-Number: 58929
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Re: Build failed in Jenkins: nightly #194

2022-04-15 Thread Jason Lowe-Power via gem5-dev
It looks successful to me. Supposedly
test-gem5-library-example-x86-gapbs-benchmarks-X86-aarch64-opt-MESI_Two_Level
failed, but everything looks fine:
https://jenkins.gem5.org/job/nightly/194/artifact/tests/testing-results/SuiteUID%3Atest-gem5-library-example-x86-gapbs-benchmarks-X86-aarch64-opt-MESI_Two_Level/TestUID%3Atest-gem5-library-example-x86-gapbs-benchmarks-X86-aarch64-opt-MESI_Two_Level/

Let's hope that it's just a bump and things are back to normal tonight.

Cheers,
Jason

On Fri, Apr 15, 2022 at 3:53 PM jenkins-no-reply--- via gem5-dev <
gem5-dev@gem5.org> wrote:

> See <
> https://jenkins.gem5.org/job/nightly/194/display/redirect?page=changes>
>
> Changes:
>
> [hoanguyen] stdlib, configs: Fix riscv-ubuntu-run error
>
>
> --
> [...truncated 1.66 MB...]
> Checking for C header file fenv.h... (cached) yes
> Checking for C header file png.h... (cached) yes
> Checking for clock_nanosleep(0,0,NULL,NULL) in C library None... (cached)
> yes
> Checking for C header file valgrind/valgrind.h... (cached) no
> Warning: Deprecated namespaces are not supported by this compiler.
>  Please make sure to check the mailing list for deprecation
>  announcements.
> Checking for pkg-config package hdf5-serial... (cached) yes
> Checking for H5Fcreate("", 0, 0, 0) in C library hdf5... (cached) yes
> Checking for H5::H5File("", 0) in C++ library hdf5_cpp... (cached) yes
> Checking for C header file linux/kvm.h... (cached) yes
> Checking for timer_create(CLOCK_MONOTONIC, NULL, NULL) in C library
> None... (cached) no
> Checking for timer_create(CLOCK_MONOTONIC, NULL, NULL) in C library rt...
> (cached) yes
> Checking size of struct kvm_xsave ... (cached) yes
> Checking for member exclude_host in struct perf_event_attr...(cached) yes
> Checking for shm_open("/test", 0, 0) in C library None... (cached) yes
> Checking for char temp; backtrace_symbols_fd((void *)&temp, 0, 0) in C
> library None... (cached) yes
> Checking for pkg-config package protobuf... (cached) yes
> Checking for GOOGLE_PROTOBUF_VERIFY_VERSION in C++ library protobuf...
> (cached) yes
> Checking for C header file linux/if_tun.h... (cached) yes
> Checking whether __i386__ is declared... (cached) no
> Checking whether __x86_64__ is declared... (cached) yes
> Checking for compiler -Wno-self-assign-overloaded support... (cached) yes
> Checking for compiler -Wno-free-nonheap-object support... (cached) yes
> scons: done reading SConscript files.
> scons: Building targets ...
>  [VER TAGS]  -> GCN3_X86/sim/tags.cc
> scons: `build/GCN3_X86/gem5.opt' is up to date.
> scons: done building targets.
> *** Summary of Warnings ***
> Warning: Deprecated namespaces are not supported by this compiler.
>  Please make sure to check the mailing list for deprecation
>  announcements.
> Building the following targets. This may take a while.
> /nobackup/jenkins/workspace/nightly/build/X86_MI_example/gem5.opt
> You may want to run with only a single ISA(--isa=), use --skip-build, or
> use 'rerun'.
> Logging call to command: scons -C /nobackup/jenkins/workspace/nightly -j
> 16 --ignore-style --no-compress-debug
> /nobackup/jenkins/workspace/nightly/build/X86_MI_example/gem5.opt
> --default=X86 PROTOCOL=MI_example
> scons: Entering directory `/nobackup/jenkins/workspace/nightly'
> scons: Reading SConscript files ...
>
> Mkdir("/nobackup/jenkins/workspace/nightly/build/X86_MI_example/gem5.build")
> Checking for linker -Wl,--as-needed support... (cached) yes
> Checking for compiler -Wno-free-nonheap-object support... (cached) yes
> Info: Using Python config: python3-config
> Checking for C header file Python.h... (cached) yes
> Checking Python version... (cached) 3.8.10
> Checking for accept(0,0,0) in C++ library None... (cached) yes
> Checking for zlibVersion() in C++ library z... (cached) yes
> Checking for C library tcmalloc... (cached) yes
> Building in /nobackup/jenkins/workspace/nightly/build/X86_MI_example
> Using saved variables file(s)
> /nobackup/jenkins/workspace/nightly/build/X86_MI_example/gem5.build/variables
> Checking for C header file fenv.h... (cached) yes
> Checking for C header file png.h... (cached) yes
> Checking for clock_nanosleep(0,0,NULL,NULL) in C library None... (cached)
> yes
> Checking for C header file valgrind/valgrind.h... (cached) no
> Warning: Deprecated namespaces are not supported by this compiler.
>  Please make sure to check the mailing list for deprecation
>  announcements.
> Checking for pkg-config package hdf5-serial... (cached) yes
> Checking for H5Fcreate("", 0, 0, 0) in C library hdf5... (cached) yes
> Checking for H5::H5File("", 0) in C++ library hdf5_cpp... (cached) yes
> Checking for C header file linux/kvm.h... (cached) yes
> Checking for timer_create(CLOCK_MONOTONIC, NULL, NULL) in C library
> None... (cached) no
> Checking for timer_create(CLOCK_MONOTONIC, NULL, NULL) in C library rt...
> (cached) yes
> Checking size of struct kvm_xsave ... (ca

[gem5-dev] Build failed in Jenkins: nightly #194

2022-04-15 Thread jenkins-no-reply--- via gem5-dev
See 

Changes:

[hoanguyen] stdlib, configs: Fix riscv-ubuntu-run error


--
[...truncated 1.66 MB...]
Checking for C header file fenv.h... (cached) yes
Checking for C header file png.h... (cached) yes
Checking for clock_nanosleep(0,0,NULL,NULL) in C library None... (cached) yes
Checking for C header file valgrind/valgrind.h... (cached) no
Warning: Deprecated namespaces are not supported by this compiler.
 Please make sure to check the mailing list for deprecation
 announcements.
Checking for pkg-config package hdf5-serial... (cached) yes
Checking for H5Fcreate("", 0, 0, 0) in C library hdf5... (cached) yes
Checking for H5::H5File("", 0) in C++ library hdf5_cpp... (cached) yes
Checking for C header file linux/kvm.h... (cached) yes
Checking for timer_create(CLOCK_MONOTONIC, NULL, NULL) in C library None... 
(cached) no
Checking for timer_create(CLOCK_MONOTONIC, NULL, NULL) in C library rt... 
(cached) yes
Checking size of struct kvm_xsave ... (cached) yes
Checking for member exclude_host in struct perf_event_attr...(cached) yes
Checking for shm_open("/test", 0, 0) in C library None... (cached) yes
Checking for char temp; backtrace_symbols_fd((void *)&temp, 0, 0) in C library 
None... (cached) yes
Checking for pkg-config package protobuf... (cached) yes
Checking for GOOGLE_PROTOBUF_VERIFY_VERSION in C++ library protobuf... (cached) 
yes
Checking for C header file linux/if_tun.h... (cached) yes
Checking whether __i386__ is declared... (cached) no
Checking whether __x86_64__ is declared... (cached) yes
Checking for compiler -Wno-self-assign-overloaded support... (cached) yes
Checking for compiler -Wno-free-nonheap-object support... (cached) yes
scons: done reading SConscript files.
scons: Building targets ...
 [VER TAGS]  -> GCN3_X86/sim/tags.cc
scons: `build/GCN3_X86/gem5.opt' is up to date.
scons: done building targets.
*** Summary of Warnings ***
Warning: Deprecated namespaces are not supported by this compiler.
 Please make sure to check the mailing list for deprecation
 announcements.
Building the following targets. This may take a while.
/nobackup/jenkins/workspace/nightly/build/X86_MI_example/gem5.opt
You may want to run with only a single ISA(--isa=), use --skip-build, or use 
'rerun'.
Logging call to command: scons -C /nobackup/jenkins/workspace/nightly -j 16 
--ignore-style --no-compress-debug 
/nobackup/jenkins/workspace/nightly/build/X86_MI_example/gem5.opt --default=X86 
PROTOCOL=MI_example
scons: Entering directory `/nobackup/jenkins/workspace/nightly'
scons: Reading SConscript files ...
Mkdir("/nobackup/jenkins/workspace/nightly/build/X86_MI_example/gem5.build")
Checking for linker -Wl,--as-needed support... (cached) yes
Checking for compiler -Wno-free-nonheap-object support... (cached) yes
Info: Using Python config: python3-config
Checking for C header file Python.h... (cached) yes
Checking Python version... (cached) 3.8.10
Checking for accept(0,0,0) in C++ library None... (cached) yes
Checking for zlibVersion() in C++ library z... (cached) yes
Checking for C library tcmalloc... (cached) yes
Building in /nobackup/jenkins/workspace/nightly/build/X86_MI_example
Using saved variables file(s) 
/nobackup/jenkins/workspace/nightly/build/X86_MI_example/gem5.build/variables
Checking for C header file fenv.h... (cached) yes
Checking for C header file png.h... (cached) yes
Checking for clock_nanosleep(0,0,NULL,NULL) in C library None... (cached) yes
Checking for C header file valgrind/valgrind.h... (cached) no
Warning: Deprecated namespaces are not supported by this compiler.
 Please make sure to check the mailing list for deprecation
 announcements.
Checking for pkg-config package hdf5-serial... (cached) yes
Checking for H5Fcreate("", 0, 0, 0) in C library hdf5... (cached) yes
Checking for H5::H5File("", 0) in C++ library hdf5_cpp... (cached) yes
Checking for C header file linux/kvm.h... (cached) yes
Checking for timer_create(CLOCK_MONOTONIC, NULL, NULL) in C library None... 
(cached) no
Checking for timer_create(CLOCK_MONOTONIC, NULL, NULL) in C library rt... 
(cached) yes
Checking size of struct kvm_xsave ... (cached) yes
Checking for member exclude_host in struct perf_event_attr...(cached) yes
Checking for shm_open("/test", 0, 0) in C library None... (cached) yes
Checking for char temp; backtrace_symbols_fd((void *)&temp, 0, 0) in C library 
None... (cached) yes
Checking for pkg-config package protobuf... (cached) yes
Checking for GOOGLE_PROTOBUF_VERIFY_VERSION in C++ library protobuf... (cached) 
yes
Checking for C header file linux/if_tun.h... (cached) yes
Checking whether __i386__ is declared... (cached) no
Checking whether __x86_64__ is declared... (cached) yes
Checking for compiler -Wno-self-assign-overloaded support... (cached) yes
Checking for compiler -Wno-free-nonheap-object support... (cached) yes
scons: done reading SConscript files

[gem5-dev] Re: gem5 v22.0 to be released in early May. Staging branch to be created by the end of April

2022-04-15 Thread Jason Lowe-Power via gem5-dev
Hi all,

I would like to merge in my multi-Ruby protocol changes:
https://gem5-review.googlesource.com/c/public/gem5/+/58469
Outstanding issues:
  - I'm still working on the one WIP change to update scons. This should be
ready to review in a couple of days. The other changesets are ready to
review now.

Cheers,
Jason

On Fri, Apr 15, 2022 at 9:13 AM Jason Lowe-Power 
wrote:

> Hi all,
>
> Please respond to this message with a pointer to the gerrit review links
> for changesets that you would like to prioritize for 22.0. This way the
> community can work together to make this another great release with lots of
> new features!
>
> There's a list of issues open in jira here
> .
> There's currently 65 issues that are "to do", "in progress", or "in
> review". We almost certainly will not be able to get to all of these in the
> next 2 weeks, but if there's something that's important to you, please let
> the community know, and we can try to work together to prioritize that.
>
> Cheers,
> Jason
>
> On Thu, Apr 14, 2022 at 11:39 AM Bobby Bruce via gem5-dev <
> gem5-dev@gem5.org> wrote:
>
>> Dear all,
>>
>> We intend to create the staging branch on April 28th, with the intent of
>> releasing gem5 v22.0 in early May. This is a two week warning. Please
>> ensure all your patches you wish to be part of v22.0 are submitted to the
>> develop branch prior to April 28th.
>>
>> Kind regards,
>> Bobby
>> --
>> Dr. Bobby R. Bruce
>> Room 3050,
>> Kemper Hall, UC Davis
>> Davis,
>> CA, 95616
>>
>> web: https://www.bobbybruce.net
>>
>>
>> On Mon, Apr 4, 2022 at 10:28 AM Bobby Bruce  wrote:
>>
>>> Dear all,
>>>
>>> In line with our policy of having three major releases a year, we're
>>> aiming to have v22.0 of gem5 released in early May.  This means we'll be
>>> creating a staging branch from the develop branch by the end of April. The
>>> staging branch will be intensely tested to ensure it is suitable for
>>> general community use before being merged into the stable branch.
>>>
>>> We understand there's a backlog of patches to be reviewed. We'll try to
>>> ensure everyone who puts in the effort to submit for this release, and
>>> responds promptly to feedback, makes it into the v22.0 release. If you feel
>>> your patches have been ignored, please ping us on the relevant Gerrit
>>> submission (if you have not already added reviewers, remember to add them).
>>> Help with reviewing over the next month would also be greatly appreciated.
>>>
>>> Kind regards,
>>> Bobby
>>> --
>>> Dr. Bobby R. Bruce
>>> Room 3050,
>>> Kemper Hall, UC Davis
>>> Davis,
>>> CA, 95616
>>>
>>> web: https://www.bobbybruce.net
>>>
>> ___
>> gem5-dev mailing list -- gem5-dev@gem5.org
>> To unsubscribe send an email to gem5-dev-le...@gem5.org
>> %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
>
>
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Re: gem5 v22.0 to be released in early May. Staging branch to be created by the end of April

2022-04-15 Thread Jason Lowe-Power via gem5-dev
Hi all,

Please respond to this message with a pointer to the gerrit review links
for changesets that you would like to prioritize for 22.0. This way the
community can work together to make this another great release with lots of
new features!

There's a list of issues open in jira here
.
There's currently 65 issues that are "to do", "in progress", or "in
review". We almost certainly will not be able to get to all of these in the
next 2 weeks, but if there's something that's important to you, please let
the community know, and we can try to work together to prioritize that.

Cheers,
Jason

On Thu, Apr 14, 2022 at 11:39 AM Bobby Bruce via gem5-dev 
wrote:

> Dear all,
>
> We intend to create the staging branch on April 28th, with the intent of
> releasing gem5 v22.0 in early May. This is a two week warning. Please
> ensure all your patches you wish to be part of v22.0 are submitted to the
> develop branch prior to April 28th.
>
> Kind regards,
> Bobby
> --
> Dr. Bobby R. Bruce
> Room 3050,
> Kemper Hall, UC Davis
> Davis,
> CA, 95616
>
> web: https://www.bobbybruce.net
>
>
> On Mon, Apr 4, 2022 at 10:28 AM Bobby Bruce  wrote:
>
>> Dear all,
>>
>> In line with our policy of having three major releases a year, we're
>> aiming to have v22.0 of gem5 released in early May.  This means we'll be
>> creating a staging branch from the develop branch by the end of April. The
>> staging branch will be intensely tested to ensure it is suitable for
>> general community use before being merged into the stable branch.
>>
>> We understand there's a backlog of patches to be reviewed. We'll try to
>> ensure everyone who puts in the effort to submit for this release, and
>> responds promptly to feedback, makes it into the v22.0 release. If you feel
>> your patches have been ignored, please ping us on the relevant Gerrit
>> submission (if you have not already added reviewers, remember to add them).
>> Help with reviewing over the next month would also be greatly appreciated.
>>
>> Kind regards,
>> Bobby
>> --
>> Dr. Bobby R. Bruce
>> Room 3050,
>> Kemper Hall, UC Davis
>> Davis,
>> CA, 95616
>>
>> web: https://www.bobbybruce.net
>>
> ___
> gem5-dev mailing list -- gem5-dev@gem5.org
> To unsubscribe send an email to gem5-dev-le...@gem5.org
> %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] [S] Change in gem5/gem5[develop]: scons: Remove old support for building with a batch processor.

2022-04-15 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/58891 )



Change subject: scons: Remove old support for building with a batch  
processor.

..

scons: Remove old support for building with a batch processor.

Other systems like distcc and ccache exist for this purpose. The SCons
CacheDir mechanism relies on multiple developers having read/write
access to a central caching directory, and for them to use each other's
build output. I expect there is only a relatively narrow window where
that would be useful, where there are multiple developers working on a
very similar version of gem5, and where security considerations would
still allow them to build in mostly unvalidated intermediate build
products supplied by other developers.

Change-Id: I45dc31b68c68906401fb1cd9e9ed658f2ba1dd6c
---
M SConstruct
M src/Kconfig
2 files changed, 18 insertions(+), 27 deletions(-)



diff --git a/SConstruct b/SConstruct
index 87a8b3e..6900d2f 100755
--- a/SConstruct
+++ b/SConstruct
@@ -828,20 +828,6 @@

 kconfig.update_env(env, kconfig_file.abspath, config_file.abspath)

-# Do this after we save setting back, or else we'll tack on an
-# extra 'qdo' every time we run scons.
-if env['CONF']['BATCH']:
-env['CC'] = env['CONF']['BATCH_CMD'] + ' ' + env['CC']
-env['CXX']= env['CONF']['BATCH_CMD'] + ' ' + env['CXX']
-env['AS'] = env['CONF']['BATCH_CMD'] + ' ' + env['AS']
-env['AR'] = env['CONF']['BATCH_CMD'] + ' ' + env['AR']
-env['RANLIB'] = env['CONF']['BATCH_CMD'] + ' ' + env['RANLIB']
-
-# Cache build files in the supplied directory.
-if env['CONF']['M5_BUILD_CACHE']:
-print('Using build cache located at',  
env['CONF']['M5_BUILD_CACHE'])

-CacheDir(env['CONF']['M5_BUILD_CACHE'])
-

 env.Append(CCFLAGS='$CCFLAGS_EXTRA')
 env.Append(LINKFLAGS='$LINKFLAGS_EXTRA')
diff --git a/src/Kconfig b/src/Kconfig
index fff5ea3..67089ea 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -25,19 +25,6 @@

 mainmenu "$(MAIN_MENU_TEXT)"

-config BATCH
-bool "Use batch pool for build and test"
-default n
-
-config BATCH_CMD
-string "Batch pool submission command name"
-default "qdo"
-depends on BATCH
-
-config M5_BUILD_CACHE
-string "Cache built objects in this directory"
-default ""
-
 config USE_EFENCE
 bool "Link with Electric Fence malloc debugger"
 default n

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/58891
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I45dc31b68c68906401fb1cd9e9ed658f2ba1dd6c
Gerrit-Change-Number: 58891
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s