[gem5-dev] [XS] Change in gem5/gem5[release-staging-v23-0]: configs: Fix SPEC benchmarks example scripts
Ayaz Akram has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/71718?usp=email )
Change subject: configs: Fix SPEC benchmarks example scripts
..
configs: Fix SPEC benchmarks example scripts
This small change fixes the gem5_library example
scripts for SPEC benchmarks to make them compatible
with the latest version of the std library.
Change-Id: I3da9745f0ee6b253871e32082e135e0fa4040108
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/71718
Maintainer: Jason Lowe-Power
Tested-by: kokoro
Reviewed-by: Jason Lowe-Power
---
M configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
M configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
index 60d93eb..10d5da0 100644
--- a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
@@ -262,7 +262,7 @@
kernel=Resource("x86-linux-kernel-4.19.83"),
# The location of the x86 SPEC CPU 2017 image
disk_image=CustomDiskImageResource(
-args.image, disk_root_partition=args.partition
+args.image, root_partition=args.partition
),
readfile_contents=command,
)
diff --git a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
index c491c9b..cb5f5d1 100644
--- a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
@@ -278,7 +278,7 @@
kernel=Resource("x86-linux-kernel-4.19.83"),
# The location of the x86 SPEC CPU 2017 image
disk_image=CustomDiskImageResource(
-args.image, disk_root_partition=args.partition
+args.image, root_partition=args.partition
),
readfile_contents=command,
)
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/71718?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: public/gem5
Gerrit-Branch: release-staging-v23-0
Gerrit-Change-Id: I3da9745f0ee6b253871e32082e135e0fa4040108
Gerrit-Change-Number: 71718
Gerrit-PatchSet: 3
Gerrit-Owner: Ayaz Akram
Gerrit-Reviewer: Ayaz Akram
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-Reviewer: kokoro
Gerrit-CC: kokoro
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
[gem5-dev] [M] Change in gem5/gem5[develop]: misc: update gem5 links
Maryam Babaie has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/71719?usp=email ) Change subject: misc: update gem5 links .. misc: update gem5 links This change updates all of the gerrit links to use github. Change-Id: I2a020dafac0bd2ba99b26c6a9cd4f0c585e253f8 --- M CONTRIBUTING.md M util/dockerfiles/gem5-all-min-dependencies/Dockerfile M util/gem5art/artifact/README.md M util/gem5art/artifact/setup.py M util/gem5art/run/setup.py M util/gem5art/tasks/setup.py 6 files changed, 28 insertions(+), 112 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ae771d3..95c4206 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -67,8 +67,8 @@ | Submit code | +-+ -After creating your change to gem5, you can post a review on our Gerrit -code-review site: https://gem5-review.googlesource.com. Before being able to +After creating your change to gem5, you can post a review to git +via a pull request at: https://github.com/gem5/gem5/pulls/. Before being able to submit your code to the mainline of gem5, the code is reviewed by others in the community. Additionally, the maintainer for that part of the code must sign off on it. @@ -77,13 +77,13 @@ === If you plan on contributing, it is strongly encouraged for you to clone the -repository directly, and checkout the `develop` branch from our gerrit instance -at https://gem5.googlesource.com/. +repository directly, and checkout the `develop` branch from our git instance +at https://github.com/gem5/gem5/. To clone the gem5 repository: ``` - git clone https://gem5.googlesource.com/public/gem5 + git clone https://github.com/gem5/gem5/ ``` By default, the stable branch is checked out. The stable branch contains the @@ -156,7 +156,7 @@ When you run a `git commit` command the pre-commit hook will run checks on your committed code. The commit will be blocked if a check fails. -The same checks are run as part of Gerrit's CI tests (those required to obtain +The same checks are run as part of github actions CI tests (those required to obtain a Verified label, necessary for a change to be accepted to the develop branch). Therefore setting up pre-commit in your local gem5 development environment is recommended. @@ -187,8 +187,7 @@ less. Leave a blank line between the first short summary line and this detailed description. * Tags describing patch metadata. You are highly recommended to use - tags to acknowledge reviewers for their work. Gerrit will automatically add - most tags. + tags to acknowledge reviewers for their work. Tags are an optional mechanism to store additional metadata about a patch and acknowledge people who reported a bug or reviewed that patch. Tags are @@ -243,7 +242,7 @@ up-to-date when you make further changes to files which already have your copyright but with older dates. -Note: If you do not follow these guidelines, the gerrit review site will +Note: If you do not follow these guidelines, the github actions will automatically reject your patch. If this happens, update your changeset descriptions to match the required style and resubmit. The following is a useful git command to update the most recent @@ -263,20 +262,18 @@ Posting a review -If you have not signed up for an account on the Gerrit review site -(https://gem5-review.googlesource.com), you first have to create an account. +If you have not signed up for an account on the github +(https://github.com/), you first have to create an account. Setting up an account - - 1. Go to https://gem5.googlesource.com/ - 2. Click "Sign In" in the upper right corner. Note: You will need a Google - account to contribute. - 3. After signing in, click "Generate Password" and follow the instructions. + 1. Go to https://github.com/ + 2. Click "Sign up" in the upper right corner. Submitting a change --- -In gerrit, to submit a review request, you can simply push your git commits to +In github, to submit a review request, you can simply push your git commits to a special named branch. For more information on git push see https://git-scm.com/docs/git-push. @@ -284,94 +281,13 @@ Push change to gerrit review +1. Fork the gem5 repository on GitHub. +2. Create a new branch in your forked repository for your feature or bug fix. +3. Commit your changes to the new branch. +4. Push the branch to your forked repository. +5. Open a pull request from your branch in your forked repository to the main gem5 repository. -``` - git push origin HEAD:refs/for/develop -``` - -Assuming origin is https://gem5.googlesource.com/public/gem5 and you want to -push the changeset at HEAD, this will create a new review request on top of the -develop branch. More generally,
[gem5-dev] [XS] Change in gem5/gem5[develop]: configs: Fix SPEC benchmarks example scripts
Jason Lowe-Power has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/71738?usp=email )
Change subject: configs: Fix SPEC benchmarks example scripts
..
configs: Fix SPEC benchmarks example scripts
This small change fixes the gem5_library example
scripts for SPEC benchmarks to make them compatible
with the latest version of the std library.
Change-Id: I3da9745f0ee6b253871e32082e135e0fa4040108
---
M configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
M configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
index 60d93eb..10d5da0 100644
--- a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
@@ -262,7 +262,7 @@
kernel=Resource("x86-linux-kernel-4.19.83"),
# The location of the x86 SPEC CPU 2017 image
disk_image=CustomDiskImageResource(
-args.image, disk_root_partition=args.partition
+args.image, root_partition=args.partition
),
readfile_contents=command,
)
diff --git a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
index c491c9b..cb5f5d1 100644
--- a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
@@ -278,7 +278,7 @@
kernel=Resource("x86-linux-kernel-4.19.83"),
# The location of the x86 SPEC CPU 2017 image
disk_image=CustomDiskImageResource(
-args.image, disk_root_partition=args.partition
+args.image, root_partition=args.partition
),
readfile_contents=command,
)
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/71738?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I3da9745f0ee6b253871e32082e135e0fa4040108
Gerrit-Change-Number: 71738
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Lowe-Power
Gerrit-CC: Ayaz Akram
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
[gem5-dev] [XS] Change in gem5/gem5[release-staging-v23-0]: configs: Fix SPEC example scripts
Ayaz Akram has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/71718?usp=email )
Change subject: configs: Fix SPEC example scripts
..
configs: Fix SPEC example scripts
Change-Id: I3da9745f0ee6b253871e32082e135e0fa4040108
---
M configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
M configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
index 60d93eb..10d5da0 100644
--- a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
@@ -262,7 +262,7 @@
kernel=Resource("x86-linux-kernel-4.19.83"),
# The location of the x86 SPEC CPU 2017 image
disk_image=CustomDiskImageResource(
-args.image, disk_root_partition=args.partition
+args.image, root_partition=args.partition
),
readfile_contents=command,
)
diff --git a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
index c491c9b..cb5f5d1 100644
--- a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
@@ -278,7 +278,7 @@
kernel=Resource("x86-linux-kernel-4.19.83"),
# The location of the x86 SPEC CPU 2017 image
disk_image=CustomDiskImageResource(
-args.image, disk_root_partition=args.partition
+args.image, root_partition=args.partition
),
readfile_contents=command,
)
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/71718?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: public/gem5
Gerrit-Branch: release-staging-v23-0
Gerrit-Change-Id: I3da9745f0ee6b253871e32082e135e0fa4040108
Gerrit-Change-Number: 71718
Gerrit-PatchSet: 1
Gerrit-Owner: Ayaz Akram
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
[gem5-dev] Re: [gem5-users] Assistance Required - Assertion Failure in RegFile
Hi, I believe this has been fixed by the following patch [1] which is currently merged on the develop branch and will be part of v23.0. Let me know if it fixes your problem Kind Regards Giacomo [1]: https://gem5-review.googlesource.com/c/public/gem5/+/70697 From: Alexandra-Nicoleta DAVID via gem5-users Sent: 14 June 2023 11:41 To: gem5-users ; gem5-dev ; 429442672 <429442...@qq.com> Cc: Alexandra-Nicoleta DAVID Subject: [gem5-users] Assistance Required - Assertion Failure in RegFile Dear gem5 Community, I am currently using the gem5 simulator version 22.1.0.0, compiled on June 14, 2023, for my research work and I have encountered an issue that I need help with. During the simulation, the program aborts with an assertion failure in the register file. The error message is: cCopy code gem5.opt: build/ARM/cpu/regfile.hh:75: const Reg& gem5::RegFile::reg(size_t) const [with Reg = long unsigned int; size_t = long unsigned int]: Assertion `sizeof(Reg) == _regBytes && idx < _size' failed. Program aborted at tick 94517000 The command that I used to run the simulation is: bashCopy code ./build/ARM/gem5.opt --debug-flags=MinorExecuteOp --debug-file=fadd1.txt configs/example/arm/starter_se.py --cpu="hpi" --num-cores=1 "/home/david1136/ARM/se-benchmarks/FloatMM" I have tried to diagnose the problem myself, but I haven't been able to identify the root cause. I believe this issue might be related to an incorrect register access, although I am not entirely certain. I have checked my configuration and my setup, and everything appears to be correct. Could you provide me with some guidance on how to troubleshoot this problem, or indicate whether this is a known issue that could be resolved with a patch or an update to the gem5 version I am using? Any help you can provide would be greatly appreciated. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org
[gem5-users] Assistance Required - Assertion Failure in RegFile
Dear gem5 Community, I am currently using the gem5 simulator version 22.1.0.0, compiled on June 14, 2023, for my research work and I have encountered an issue that I need help with. During the simulation, the program aborts with an assertion failure in the register file. The error message is: cCopy code gem5.opt: build/ARM/cpu/regfile.hh:75: const Reg& gem5::RegFile::reg(size_t) const [with Reg = long unsigned int; size_t = long unsigned int]: Assertion `sizeof(Reg) == _regBytes && idx < _size' failed. Program aborted at tick 94517000 The command that I used to run the simulation is: bashCopy code ./build/ARM/gem5.opt --debug-flags=MinorExecuteOp --debug-file=fadd1.txt configs/example/arm/starter_se.py --cpu="hpi" --num-cores=1 "/home/david1136/ARM/se-benchmarks/FloatMM" I have tried to diagnose the problem myself, but I haven't been able to identify the root cause. I believe this issue might be related to an incorrect register access, although I am not entirely certain. I have checked my configuration and my setup, and everything appears to be correct. Could you provide me with some guidance on how to troubleshoot this problem, or indicate whether this is a known issue that could be resolved with a patch or an update to the gem5 version I am using? Any help you can provide would be greatly appreciated. ___ gem5-users mailing list -- gem5-us...@gem5.org To unsubscribe send an email to gem5-users-le...@gem5.org
[gem5-users] Extract Instructions
I tried to extract the fmul type instructions and display them in the
format:
[image: image.png]
I have these functions in execute.cc
// Cod adaugat
std::string disassembledInst =
inst->staticInst->disassemble(inst->pc->instAddr(),
&loader::debugSymbolTable);
if(inst->staticInst->opClass()==FloatMultOp){
if (disassembledInst.find("fmul") != std::string::npos) {
// Instruction details
DPRINTF(MinorExecuteOp, "Exec inst: %s\n", *inst);
// Op Class
DPRINTF(MinorExecuteOp, " Op Class inst: %s\n",
enums::OpClassStrings[inst->staticInst->opClass()]);
// Op Dissasembled
DPRINTF(MinorExecuteOp, "Dissasembled: %s\n",
inst->staticInst->disassemble(inst->pc->instAddr(),
&loader::debugSymbolTable));
// Cast from StaticInstPtr to StaticInst
StaticInst* leInst = inst->staticInst.get();
// Print source register values
for (int i = 0; i < leInst->numSrcRegs(); i++) {
RegId regId = leInst->srcRegIdx(i);
float regValue;
context.getFloatRegOperand(leInst, i, ®Value);
DPRINTF(MinorExecuteOp, " SrcReg%d=%d (%s)\n",/*i,
regValue,*/ printRegName(regId));
}
// Print destination register values
for (int i = 0; i < leInst->numDestRegs(); i++) {
RegId regId = leInst->destRegIdx(i);
float regValue;
context.getFloatRegOperand(leInst, i, ®Value);
DPRINTF(MinorExecuteOp, " DestReg%d=%d (%s)\n", /*i,
regValue,*/ printRegName(regId));
}
}
}
fault = inst->staticInst->execute(&context,
inst->traceData);
/*Set the predicate for tracing and dump*/
if(inst->traceData){
inst->traceData->setPredicate(context.readPredicate());
}
// Cod adaugat
// Print destination register values
if(inst->staticInst->opClass()==FloatMultOp){
if (disassembledInst.find("fmul") != std::string::npos) {
// Cast from StaticInstPtr to StaticInst
StaticInst* leInst = inst->staticInst.get();
for (int i = 0; i < leInst->numDestRegs(); i++) {
RegId regId = leInst->destRegIdx(i);
float regValue;
context.getFloatRegOperand(leInst, i, ®Value);
DPRINTF(MinorExecuteOp, " DestReg%d=%d (%s)\n", /*i,
regValue,*/ printRegName(regId));
}
}
}
// Cod adaugat
and the getFloatRegOperand looks like this
[image: image.png]
has anyone tried to do this before and can help me?
Thank you very much! Have a nice day!
___
gem5-users mailing list -- gem5-us...@gem5.org
To unsubscribe send an email to gem5-users-le...@gem5.org
