[gem5-dev] [S] Change in gem5/gem5[develop]: configs: Set CPU vendor to M5 Simulator in apu_se.py

2022-11-28 Thread Matthew Poremba (Gerrit) via gem5-dev
Matthew Poremba has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/65991?usp=email )


Change subject: configs: Set CPU vendor to M5 Simulator in apu_se.py
..

configs: Set CPU vendor to M5 Simulator in apu_se.py

Other vendor strings causes, for some reason, bad addresses to be
computed when running the GPU model. This change reverts back to M5
Simulator only for apu_se.py.

Change-Id: I5992b4e31569f5c0e5e49e523908c8fa0602f845
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65991
Tested-by: kokoro 
Reviewed-by: Matt Sinclair 
Maintainer: Matt Sinclair 
Reviewed-by: Jason Lowe-Power 
---
M configs/example/apu_se.py
1 file changed, 23 insertions(+), 0 deletions(-)

Approvals:
  kokoro: Regressions pass
  Matt Sinclair: Looks good to me, but someone else must approve; Looks  
good to me, approved

  Jason Lowe-Power: Looks good to me, approved




diff --git a/configs/example/apu_se.py b/configs/example/apu_se.py
index 39def02..8e8bc60 100644
--- a/configs/example/apu_se.py
+++ b/configs/example/apu_se.py
@@ -757,6 +757,11 @@
 (cpu_list[i], future_cpu_list[i]) for i in range(args.num_cpus)
 ]

+# Other CPU strings cause bad addresses in ROCm. Revert back to M5  
Simulator.

+for (i, cpu) in enumerate(cpu_list):
+for j in range(len(cpu)):
+cpu.isa[j].vendor_string = "M5 Simulator"
+
 # Full list of processing cores in the system.
 cpu_list = cpu_list + [shader] + cp_list


--
To view, visit  
https://gem5-review.googlesource.com/c/public/gem5/+/65991?usp=email
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I5992b4e31569f5c0e5e49e523908c8fa0602f845
Gerrit-Change-Number: 65991
Gerrit-PatchSet: 2
Gerrit-Owner: Matthew Poremba 
Gerrit-Reviewer: Bobby Bruce 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Matt Sinclair 
Gerrit-Reviewer: Matthew Poremba 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org


[gem5-dev] [S] Change in gem5/gem5[develop]: configs: Set CPU vendor to M5 Simulator in apu_se.py

2022-11-23 Thread Matthew Poremba (Gerrit) via gem5-dev
Matthew Poremba has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/65991?usp=email )



Change subject: configs: Set CPU vendor to M5 Simulator in apu_se.py
..

configs: Set CPU vendor to M5 Simulator in apu_se.py

Other vendor strings causes, for some reason, bad addresses to be
computed when running the GPU model. This change reverts back to M5
Simulator only for apu_se.py.

Change-Id: I5992b4e31569f5c0e5e49e523908c8fa0602f845
---
M configs/example/apu_se.py
1 file changed, 18 insertions(+), 0 deletions(-)



diff --git a/configs/example/apu_se.py b/configs/example/apu_se.py
index 39def02..8e8bc60 100644
--- a/configs/example/apu_se.py
+++ b/configs/example/apu_se.py
@@ -757,6 +757,11 @@
 (cpu_list[i], future_cpu_list[i]) for i in range(args.num_cpus)
 ]

+# Other CPU strings cause bad addresses in ROCm. Revert back to M5  
Simulator.

+for (i, cpu) in enumerate(cpu_list):
+for j in range(len(cpu)):
+cpu.isa[j].vendor_string = "M5 Simulator"
+
 # Full list of processing cores in the system.
 cpu_list = cpu_list + [shader] + cp_list


--
To view, visit  
https://gem5-review.googlesource.com/c/public/gem5/+/65991?usp=email
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I5992b4e31569f5c0e5e49e523908c8fa0602f845
Gerrit-Change-Number: 65991
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Poremba 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org