Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/69157?usp=email )
Change subject: base: Flip the default for ListenSocket::accept(bool
nodelay).
..
base: Flip the default for ListenSocket::accept(bool nodelay).
This option was almost always overridden from false to true anyway,
except in one place (in the ethertap device) which was likely just by
accident.
This will give external users a chance to remove the option without
changing behavior, so that the option can be removed entirely in a
later change.
Change-Id: I77add40b8131b91997b2aecbfff6c7de0ee9ead9
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69157
Reviewed-by: Yu-hsin Wang
Tested-by: kokoro
Maintainer: Gabe Black
---
M src/base/socket.hh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
Yu-hsin Wang: Looks good to me, approved
diff --git a/src/base/socket.hh b/src/base/socket.hh
index f3b2760..af4a651 100644
--- a/src/base/socket.hh
+++ b/src/base/socket.hh
@@ -104,7 +104,7 @@
ListenSocket();
virtual ~ListenSocket();
-virtual int accept(bool nodelay = false);
+virtual int accept(bool nodelay = true);
virtual bool listen(int port, bool reuse = true);
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/69157?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I77add40b8131b91997b2aecbfff6c7de0ee9ead9
Gerrit-Change-Number: 69157
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black
Gerrit-Reviewer: Bobby Bruce
Gerrit-Reviewer: Daniel Carvalho
Gerrit-Reviewer: Gabe Black
Gerrit-Reviewer: Yu-hsin Wang
Gerrit-Reviewer: kokoro
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
