[gem5-dev] [XS] Change in gem5/gem5[develop]: configs: GPUFS: Only use parallel eventqs for KVM

2023-06-08 Thread Matthew Poremba (Gerrit) via gem5-dev
Matthew Poremba has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/71419?usp=email )


Change subject: configs: GPUFS: Only use parallel eventqs for KVM
..

configs: GPUFS: Only use parallel eventqs for KVM

This is turned on by default with multiple CPUs in the GPUFS configs,
which causes other CPU types (e.g., AtomicSimpleCPU) to assert. Only
enable parallel event queues for KVM CPUs to avoid this issue.

Change-Id: Ic8235437caf0150560e2b360a4544d82dfc26c36
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/71419
Maintainer: Matt Sinclair 
Tested-by: kokoro 
Reviewed-by: Matt Sinclair 
---
M configs/example/gpufs/runfs.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Matt Sinclair: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass




diff --git a/configs/example/gpufs/runfs.py b/configs/example/gpufs/runfs.py
index 01203bb..b045b80 100644
--- a/configs/example/gpufs/runfs.py
+++ b/configs/example/gpufs/runfs.py
@@ -162,7 +162,8 @@
 # GPUFS is primarily designed to use the X86 KVM CPU. This model needs  
to
 # use multiple event queues when more than one CPU is simulated. Force  
it

 # on if that is the case.
-args.host_parallel = True if args.num_cpus > 1 else False
+if ObjectList.is_kvm_cpu(ObjectList.cpu_list.get(args.cpu_type)):
+args.host_parallel = True if args.num_cpus > 1 else False

 # These are used by the protocols. They should not be set by the user.
 n_cu = args.num_compute_units

--
To view, visit  
https://gem5-review.googlesource.com/c/public/gem5/+/71419?usp=email
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings?usp=email


Gerrit-MessageType: merged
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic8235437caf0150560e2b360a4544d82dfc26c36
Gerrit-Change-Number: 71419
Gerrit-PatchSet: 2
Gerrit-Owner: Matthew Poremba 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Matt Sinclair 
Gerrit-Reviewer: Matthew Poremba 
Gerrit-Reviewer: kokoro 
Gerrit-CC: kokoro 
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org


[gem5-dev] [XS] Change in gem5/gem5[develop]: configs: GPUFS: Only use parallel eventqs for KVM

2023-06-08 Thread Matthew Poremba (Gerrit) via gem5-dev
Matthew Poremba has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/71419?usp=email )



Change subject: configs: GPUFS: Only use parallel eventqs for KVM
..

configs: GPUFS: Only use parallel eventqs for KVM

This is turned on by default with multiple CPUs in the GPUFS configs,
which causes other CPU types (e.g., AtomicSimpleCPU) to assert. Only
enable parallel event queues for KVM CPUs to avoid this issue.

Change-Id: Ic8235437caf0150560e2b360a4544d82dfc26c36
---
M configs/example/gpufs/runfs.py
1 file changed, 2 insertions(+), 1 deletion(-)



diff --git a/configs/example/gpufs/runfs.py b/configs/example/gpufs/runfs.py
index 01203bb..b045b80 100644
--- a/configs/example/gpufs/runfs.py
+++ b/configs/example/gpufs/runfs.py
@@ -162,7 +162,8 @@
 # GPUFS is primarily designed to use the X86 KVM CPU. This model needs  
to
 # use multiple event queues when more than one CPU is simulated. Force  
it

 # on if that is the case.
-args.host_parallel = True if args.num_cpus > 1 else False
+if ObjectList.is_kvm_cpu(ObjectList.cpu_list.get(args.cpu_type)):
+args.host_parallel = True if args.num_cpus > 1 else False

 # These are used by the protocols. They should not be set by the user.
 n_cu = args.num_compute_units

--
To view, visit  
https://gem5-review.googlesource.com/c/public/gem5/+/71419?usp=email
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings?usp=email


Gerrit-MessageType: newchange
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic8235437caf0150560e2b360a4544d82dfc26c36
Gerrit-Change-Number: 71419
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Poremba 
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org