[gem5-dev] Change in gem5/gem5[develop]: arch-power: Add fields for DX form instructions

2021-06-28 Thread Boris Shingarov (Gerrit) via gem5-dev
Boris Shingarov has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/40901 )


Change subject: arch-power: Add fields for DX form instructions
..

arch-power: Add fields for DX form instructions

This introduces the extended opcode field for DS form
instructions and the fields d0, d1 and d2 which are
concatenated for specifying a signed integer immediate
operand.

Change-Id: Id60e85d79f9157d680f813bf90ab6e1e064253a9
Signed-off-by: Sandipan Das 
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40901
Reviewed-by: Boris Shingarov 
Maintainer: Jason Lowe-Power 
Tested-by: kokoro 
---
M src/arch/power/isa/bitfields.isa
M src/arch/power/types.hh
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Boris Shingarov: Looks good to me, approved
  Jason Lowe-Power: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/arch/power/isa/bitfields.isa  
b/src/arch/power/isa/bitfields.isa

index 771a822..84a3a2c 100644
--- a/src/arch/power/isa/bitfields.isa
+++ b/src/arch/power/isa/bitfields.isa
@@ -37,6 +37,7 @@
 def bitfield PO<31:26>;
 def bitfield A_XO  <5:1>;
 def bitfield DS_XO <1:0>;
+def bitfield DX_XO <5:1>;
 def bitfield X_XO  <10:1>;
 def bitfield XFL_XO<10:1>;
 def bitfield XFX_XO<10:1>;
diff --git a/src/arch/power/types.hh b/src/arch/power/types.hh
index 354da59..6f55821 100644
--- a/src/arch/power/types.hh
+++ b/src/arch/power/types.hh
@@ -55,6 +55,9 @@
 Bitfield<15,  0> ui;
 Bitfield<15,  0> d;
 Bitfield<15,  2> ds;
+Bitfield<15,  6> d0;
+Bitfield<20, 16> d1;
+Bitfield< 1,  0> d2;

 // Special purpose register identifier
 Bitfield<20, 11> spr;

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40901
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id60e85d79f9157d680f813bf90ab6e1e064253a9
Gerrit-Change-Number: 40901
Gerrit-PatchSet: 7
Gerrit-Owner: Sandipan Das 
Gerrit-Reviewer: Boris Shingarov 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: arch-power: Add fields for DX form instructions

2021-02-07 Thread Sandipan Das (Gerrit) via gem5-dev
Sandipan Das has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/40901 )



Change subject: arch-power: Add fields for DX form instructions
..

arch-power: Add fields for DX form instructions

This introduces the extended opcode field for DS form
instructions and the fields d0, d1 and d2 which are
concatenated for specifying a signed integer immediate
operand.

Change-Id: Id60e85d79f9157d680f813bf90ab6e1e064253a9
Signed-off-by: Sandipan Das 
---
M src/arch/power/isa/bitfields.isa
M src/arch/power/types.hh
2 files changed, 4 insertions(+), 0 deletions(-)



diff --git a/src/arch/power/isa/bitfields.isa  
b/src/arch/power/isa/bitfields.isa

index 771a822..84a3a2c 100644
--- a/src/arch/power/isa/bitfields.isa
+++ b/src/arch/power/isa/bitfields.isa
@@ -37,6 +37,7 @@
 def bitfield PO<31:26>;
 def bitfield A_XO  <5:1>;
 def bitfield DS_XO <1:0>;
+def bitfield DX_XO <5:1>;
 def bitfield X_XO  <10:1>;
 def bitfield XFL_XO<10:1>;
 def bitfield XFX_XO<10:1>;
diff --git a/src/arch/power/types.hh b/src/arch/power/types.hh
index 910c5f5..ef9b35f 100644
--- a/src/arch/power/types.hh
+++ b/src/arch/power/types.hh
@@ -53,6 +53,9 @@
 Bitfield<15,  0> si;
 Bitfield<15,  0> d;
 Bitfield<15,  2> ds;
+Bitfield<15,  6> d0;
+Bitfield<20, 16> d1;
+Bitfield< 1,  0> d2;

 // Special purpose register identifier
 Bitfield<20, 11> spr;

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40901
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id60e85d79f9157d680f813bf90ab6e1e064253a9
Gerrit-Change-Number: 40901
Gerrit-PatchSet: 1
Gerrit-Owner: Sandipan Das 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s