Hoa Nguyen has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/40675 )
Change subject: dev,dev-arm: Remove units from stats description
..
dev,dev-arm: Remove units from stats description
A recent change https://gem5-review.googlesource.com/c/public/gem5/+/40622
allows units to be shown in stats dump; the units in stats
descriptions are nolonger necessary. This change removes units
from stats descriptions. However, for units that are multiples
of a supported unit (e.g. MegaBytes), the units in the descriptions
are kept until unit prefixes are supported.
Change-Id: I199afbf29fee13b08eeb323c4cb56c8a974dbe94
Signed-off-by: Hoa Nguyen
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40675
Tested-by: kokoro
Reviewed-by: Daniel Carvalho
Maintainer: Gabe Black
---
M src/dev/arm/ufs_device.cc
M src/dev/net/etherdevice.cc
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Daniel Carvalho: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/dev/arm/ufs_device.cc b/src/dev/arm/ufs_device.cc
index f7b6d82..830b841 100644
--- a/src/dev/arm/ufs_device.cc
+++ b/src/dev/arm/ufs_device.cc
@@ -778,11 +778,11 @@
/** Average bandwidth for reads and writes */
ADD_STAT(averageReadSSDBW,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Average read bandwidth (bytes/s)",
+ "Average read bandwidth",
totalReadSSD / simSeconds),
ADD_STAT(averageWriteSSDBW,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Average write bandwidth (bytes/s)",
+ "Average write bandwidth",
totalWrittenSSD / simSeconds),
ADD_STAT(averageSCSIQueue,
UNIT_RATE(Stats::Units::Count, Stats::Units::Tick),
diff --git a/src/dev/net/etherdevice.cc b/src/dev/net/etherdevice.cc
index 7c817f4..9def479 100644
--- a/src/dev/net/etherdevice.cc
+++ b/src/dev/net/etherdevice.cc
@@ -38,10 +38,10 @@
ADD_STAT(txPackets, UNIT_COUNT, "Number of Packets Transmitted"),
ADD_STAT(rxPackets, UNIT_COUNT, "Number of Packets Received"),
ADD_STAT(txBandwidth, UNIT_RATE(Stats::Units::Bit,
Stats::Units::Second),
- "Transmit Bandwidth (bits/s)",
+ "Transmit Bandwidth",
txBytes * Stats::constant(8) / simSeconds),
ADD_STAT(rxBandwidth, UNIT_RATE(Stats::Units::Bit,
Stats::Units::Second),
- "Receive Bandwidth (bits/s)",
+ "Receive Bandwidth",
rxBytes * Stats::constant(8) / simSeconds),
ADD_STAT(txIpChecksums, UNIT_COUNT,
"Number of tx IP Checksums done by device"),
@@ -65,7 +65,7 @@
"Number of descriptor bytes write w/ DMA"),
ADD_STAT(totBandwidth,
UNIT_RATE(Stats::Units::Bit, Stats::Units::Second),
- "Total Bandwidth (bits/s)",
+ "Total Bandwidth",
txBandwidth + rxBandwidth),
ADD_STAT(totPackets, UNIT_COUNT, "Total Packets", txPackets +
rxPackets),
ADD_STAT(totBytes, UNIT_BYTE, "Total Bytes", txBytes + rxBytes),
The change was submitted with unreviewed changes in the following files:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40675
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I199afbf29fee13b08eeb323c4cb56c8a974dbe94
Gerrit-Change-Number: 40675
Gerrit-PatchSet: 11
Gerrit-Owner: Hoa Nguyen
Gerrit-Reviewer: Andreas Sandberg
Gerrit-Reviewer: Daniel Carvalho
Gerrit-Reviewer: Gabe Black
Gerrit-Reviewer: Giacomo Travaglini
Gerrit-Reviewer: Hoa Nguyen
Gerrit-Reviewer: kokoro
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
