[gem5-dev] Change in gem5/gem5[develop]: sim-power: Addition of PowerDomains
Nikos Nikoleris has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/28051 ) Change subject: sim-power: Addition of PowerDomains .. sim-power: Addition of PowerDomains PowerDomains group multiple objects together to regulate their power state. There are 2 types of objects in a PowerDomain: leaders and followers. The power state of a PowerDomain is the most performant power state of any of the leaders. The power state of the followers is determined by the power state of the PowerDomain they belong to: they need to be in a power state which is more or equally performant to the power state of the PowerDomain. Leaders can be ClockedObjects or other PowerDomains. Followers can only be ClockedObjects. PowerDomains can be be nested but a PowerDomain can only be a leader of another PowerDomain, NOT a follower. PowerDomains are not present in the hierarchy by default, the user needs to create and configure them in the configuration file. The user can add an hierachy by setting the led_by parameter. gem5 will then create leaders and followers for each domain and calculate the allowed power states for the domain. Objects in a PowerDomain need to have at least the ON state in the possible_states. An example of a powerDomain config is: pd = PowerDomain() cpu0 = BaseCPU() cpu1 = BaseCPU() shared_cache = BaseCache() cache.power_state.led_by = pd pd.led_by = [cpu0, cpu1] This will create a PowerDomain, where the CPUs determine their own power states and the shared cache (via the PowerDomain) follows those power states (when possible). Change-Id: I4c4cd01f06d45476c6e0fb2afeb778613733e2ff Reviewed-by: Andreas Sandberg Reviewed-by: Sascha Bischoff Signed-off-by: Nikos Nikoleris Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/28051 Reviewed-by: Bobby R. Bruce Maintainer: Jason Lowe-Power Tested-by: kokoro --- A src/sim/PowerDomain.py M src/sim/PowerState.py M src/sim/SConscript A src/sim/power_domain.cc A src/sim/power_domain.hh M src/sim/power_state.cc M src/sim/power_state.hh 7 files changed, 587 insertions(+), 2 deletions(-) Approvals: Bobby R. Bruce: Looks good to me, approved Jason Lowe-Power: Looks good to me, approved kokoro: Regressions pass diff --git a/src/sim/PowerDomain.py b/src/sim/PowerDomain.py new file mode 100644 index 000..9d45252 --- /dev/null +++ b/src/sim/PowerDomain.py @@ -0,0 +1,49 @@ +# Copyright (c) 2017, 2019-2020 ARM Limited +# All rights reserved. +# +# The license below extends only to copyright in the software and shall +# not be construed as granting a license to any other intellectual +# property including but not limited to intellectual property relating +# to a hardware implementation of the functionality of the software +# licensed hereunder. You may use the software subject to the license +# terms below provided that you ensure that this notice is replicated +# unmodified and in its entirety in all distributions of the software, +# modified or unmodified, in source code or in binary form. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are +# met: redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer; +# redistributions in binary form must reproduce the above copyright +# notice, this list of conditions and the following disclaimer in the +# documentation and/or other materials provided with the distribution; +# neither the name of the copyright holders nor the names of its +# contributors may be used to endorse or promote products derived from +# this software without specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +# + +import sys + +from m5.params import * +from m5.objects.PowerState import PowerState + +# A power domain groups multiple ClockedObjects and creates a +# hierarchy in which follower ClockedObjects (caches for example) can +# change power state depeding on what the leader objects (CPUs for +# example) do. The power domain is the link between these. +class PowerDomain(PowerState): +type =
[gem5-dev] Change in gem5/gem5[develop]: sim-power: Addition of PowerDomains
Hello Andreas Sandberg, Anouk Van Laer, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/28051 to review the following change. Change subject: sim-power: Addition of PowerDomains .. sim-power: Addition of PowerDomains PowerDomains group multiple objects together to regulate their power state. There are 2 types of objects in a PowerDomain: leaders and followers. The power state of a PowerDomain is the most performant power state of any of the leaders. The power state of the followers is determined by the power state of the PowerDomain they belong to: they need to be in a power state which is more or equally performant to the power state of the PowerDomain. Leaders can be ClockedObjects or other PowerDomains. Followers can only be ClockedObjects. PowerDomains can be be nested but a PowerDomain can only be a leader of another PowerDomain, NOT a follower. PowerDomains are not present in the hierarchy by default, the user needs to create and configure them in the configuration file. The user can add an hierachy by setting the led_by parameter. gem5 will then create leaders and followers for each domain and calculate the allowed power states for the domain. Objects in a PowerDomain need to have at least the ON state in the possible_states. An example of a powerDomain config is: pd = PowerDomain() cpu0 = BaseCPU() cpu1 = BaseCPU() shared_cache = BaseCache() cache.power_state.led_by = pd pd.led_by = [cpu0, cpu1] This will create a PowerDomain, where the CPUs determine their own power states and the shared cache (via the PowerDomain) follows those power states (when possible). Change-Id: I4c4cd01f06d45476c6e0fb2afeb778613733e2ff Reviewed-by: Andreas Sandberg Reviewed-by: Sascha Bischoff Signed-off-by: Nikos Nikoleris --- A src/sim/PowerDomain.py M src/sim/PowerState.py M src/sim/SConscript A src/sim/power_domain.cc A src/sim/power_domain.hh M src/sim/power_state.cc M src/sim/power_state.hh 7 files changed, 585 insertions(+), 2 deletions(-) diff --git a/src/sim/PowerDomain.py b/src/sim/PowerDomain.py new file mode 100644 index 000..9d45252 --- /dev/null +++ b/src/sim/PowerDomain.py @@ -0,0 +1,49 @@ +# Copyright (c) 2017, 2019-2020 ARM Limited +# All rights reserved. +# +# The license below extends only to copyright in the software and shall +# not be construed as granting a license to any other intellectual +# property including but not limited to intellectual property relating +# to a hardware implementation of the functionality of the software +# licensed hereunder. You may use the software subject to the license +# terms below provided that you ensure that this notice is replicated +# unmodified and in its entirety in all distributions of the software, +# modified or unmodified, in source code or in binary form. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are +# met: redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer; +# redistributions in binary form must reproduce the above copyright +# notice, this list of conditions and the following disclaimer in the +# documentation and/or other materials provided with the distribution; +# neither the name of the copyright holders nor the names of its +# contributors may be used to endorse or promote products derived from +# this software without specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +# + +import sys + +from m5.params import * +from m5.objects.PowerState import PowerState + +# A power domain groups multiple ClockedObjects and creates a +# hierarchy in which follower ClockedObjects (caches for example) can +# change power state depeding on what the leader objects (CPUs for +# example) do. The power domain is the link between these. +class PowerDomain(PowerState): +type = 'PowerDomain' +cxx_header = 'sim/power_domain.hh' + diff --git a/src/sim/PowerState.py b/src/sim/PowerState.py index bfa53e2..30f62e0 100644 --- a/src/sim/PowerState.py +++ b/src/sim/PowerState.py @@ -70,3
