[gem5-dev] Change in gem5/gem5[develop]: tests: Re-enable 'Hello World' 32-bit tests

2021-10-14 Thread Bobby R. Bruce (Gerrit) via gem5-dev
Bobby R. Bruce has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/51612 )


Change subject: tests: Re-enable 'Hello World' 32-bit tests
..

tests: Re-enable 'Hello World' 32-bit tests

Due to a faul recorded here:
https://gem5.atlassian.net/browse/GEM5-1074, running 32-bit binaries in
SE mode was causing a segfault to occur. These tests were therefore
disabled until a fix could be developed. A fix was submitted here:
https://gem5-review.googlesource.com/c/public/gem5/+/51489, and, as-such
the tests should be re-enabled.

Change-Id: Id01a6d85fb5e30319e53dda97f6247bcc5302477
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/51612
Reviewed-by: Gabe Black 
Maintainer: Gabe Black 
Tested-by: kokoro 
---
M tests/gem5/hello_se/test_hello_se.py
1 file changed, 22 insertions(+), 4 deletions(-)

Approvals:
  Gabe Black: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass




diff --git a/tests/gem5/hello_se/test_hello_se.py  
b/tests/gem5/hello_se/test_hello_se.py

index 4d3fb22..03ffd49 100644
--- a/tests/gem5/hello_se/test_hello_se.py
+++ b/tests/gem5/hello_se/test_hello_se.py
@@ -49,13 +49,11 @@
 static_progs = {
 constants.gcn3_x86_tag: (
 "x86-hello64-static",
-# "x86-hello32-static", # Running 32-bit binaries on gem5 is  
broken:
-#  
https://gem5.atlassian.net/browse/GEM5-1074

+"x86-hello32-static",
 ),
 constants.arm_tag: (
 "arm-hello64-static",
-# "arm-hello32-static", # Running 32-bit binaries on gem5 is  
broken.
-#  
https://gem5.atlassian.net/browse/GEM5-1074

+"arm-hello32-static",
 ),
 constants.mips_tag: ("mips-hello",),
 constants.riscv_tag: ("riscv-hello",),

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/51612
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id01a6d85fb5e30319e53dda97f6247bcc5302477
Gerrit-Change-Number: 51612
Gerrit-PatchSet: 2
Gerrit-Owner: Bobby R. Bruce 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: tests: Re-enable 'Hello World' 32-bit tests

2021-10-13 Thread Bobby R. Bruce (Gerrit) via gem5-dev
Bobby R. Bruce has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/51612 )



Change subject: tests: Re-enable 'Hello World' 32-bit tests
..

tests: Re-enable 'Hello World' 32-bit tests

Due to a faul recorded here:
https://gem5.atlassian.net/browse/GEM5-1074, running 32-bit binaries in
SE mode was causing a segfault to occur. These tests were therefore
disabled until a fix could be developed. A fix was submitted here:
https://gem5-review.googlesource.com/c/public/gem5/+/51489, and, as-such
the tests should be re-enabled.

Change-Id: Id01a6d85fb5e30319e53dda97f6247bcc5302477
---
M tests/gem5/hello_se/test_hello_se.py
1 file changed, 18 insertions(+), 4 deletions(-)



diff --git a/tests/gem5/hello_se/test_hello_se.py  
b/tests/gem5/hello_se/test_hello_se.py

index 4d3fb22..03ffd49 100644
--- a/tests/gem5/hello_se/test_hello_se.py
+++ b/tests/gem5/hello_se/test_hello_se.py
@@ -49,13 +49,11 @@
 static_progs = {
 constants.gcn3_x86_tag: (
 "x86-hello64-static",
-# "x86-hello32-static", # Running 32-bit binaries on gem5 is  
broken:
-#  
https://gem5.atlassian.net/browse/GEM5-1074

+"x86-hello32-static",
 ),
 constants.arm_tag: (
 "arm-hello64-static",
-# "arm-hello32-static", # Running 32-bit binaries on gem5 is  
broken.
-#  
https://gem5.atlassian.net/browse/GEM5-1074

+"arm-hello32-static",
 ),
 constants.mips_tag: ("mips-hello",),
 constants.riscv_tag: ("riscv-hello",),

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/51612
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id01a6d85fb5e30319e53dda97f6247bcc5302477
Gerrit-Change-Number: 51612
Gerrit-PatchSet: 1
Gerrit-Owner: Bobby R. Bruce 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s