[gem5-dev] Change in gem5/gem5[master]: arch-mips: added missing override specifier (o3)

2019-04-03 Thread Andrea Mondelli (Gerrit) 
Andrea Mondelli has submitted this change and it was merged. (  
https://gem5-review.googlesource.com/c/public/gem5/+/17648 )


Change subject: arch-mips: added missing override specifier (o3)
..

arch-mips: added missing override specifier (o3)

Change-Id: Ic538825a2964fd62def672b933a83067a15bd12a
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/17648
Reviewed-by: Jason Lowe-Power 
Maintainer: Jason Lowe-Power 
---
M src/cpu/o3/dyn_inst.hh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved



diff --git a/src/cpu/o3/dyn_inst.hh b/src/cpu/o3/dyn_inst.hh
index 640ebf8..24c59a2 100644
--- a/src/cpu/o3/dyn_inst.hh
+++ b/src/cpu/o3/dyn_inst.hh
@@ -432,14 +432,14 @@

 #if THE_ISA == MIPS_ISA
 RegVal
-readRegOtherThread(const RegId& misc_reg, ThreadID tid)
+readRegOtherThread(const RegId& misc_reg, ThreadID tid) override
 {
 panic("MIPS MT not defined for O3 CPU.\n");
 return 0;
 }

 void
-setRegOtherThread(const RegId& misc_reg, RegVal val, ThreadID tid)
+setRegOtherThread(const RegId& misc_reg, RegVal val, ThreadID tid)  
override

 {
 panic("MIPS MT not defined for O3 CPU.\n");
 }

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/17648
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ic538825a2964fd62def672b933a83067a15bd12a
Gerrit-Change-Number: 17648
Gerrit-PatchSet: 5
Gerrit-Owner: Andrea Mondelli 
Gerrit-Reviewer: Andrea Mondelli 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[master]: arch-mips: added missing override specifier (o3)

2019-03-25 Thread Andrea Mondelli (Gerrit) 
Andrea Mondelli has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/17648



Change subject: arch-mips: added missing override specifier (o3)
..

arch-mips: added missing override specifier (o3)

Change-Id: Ic538825a2964fd62def672b933a83067a15bd12a
---
M src/cpu/o3/dyn_inst.hh
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/src/cpu/o3/dyn_inst.hh b/src/cpu/o3/dyn_inst.hh
index 640ebf8..24c59a2 100644
--- a/src/cpu/o3/dyn_inst.hh
+++ b/src/cpu/o3/dyn_inst.hh
@@ -432,14 +432,14 @@

 #if THE_ISA == MIPS_ISA
 RegVal
-readRegOtherThread(const RegId& misc_reg, ThreadID tid)
+readRegOtherThread(const RegId& misc_reg, ThreadID tid) override
 {
 panic("MIPS MT not defined for O3 CPU.\n");
 return 0;
 }

 void
-setRegOtherThread(const RegId& misc_reg, RegVal val, ThreadID tid)
+setRegOtherThread(const RegId& misc_reg, RegVal val, ThreadID tid)  
override

 {
 panic("MIPS MT not defined for O3 CPU.\n");
 }

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/17648
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ic538825a2964fd62def672b933a83067a15bd12a
Gerrit-Change-Number: 17648
Gerrit-PatchSet: 1
Gerrit-Owner: Andrea Mondelli 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev