[gem5-dev] Change in gem5/gem5[master]: base: Fix ucontext compilation error for macOS
Giacomo Travaglini has submitted this change and it was merged. ( https://gem5-review.googlesource.com/11729 ) Change subject: base: Fix ucontext compilation error for macOS .. base: Fix ucontext compilation error for macOS ucontext functions (like getcontext, setcontext etc) have been marked as deprecated and are hence hidden in latest macOS releases. This patch uncovers them; warnings wil be produced but compilation won't fail since -Wno-error=deprecated-declarations flag is currently used. Change-Id: Ic10e6f77a38875828b1891eaed2f0626ec67 Signed-off-by: Giacomo Travaglini Reviewed-on: https://gem5-review.googlesource.com/11729 Reviewed-by: Jason Lowe-Power Maintainer: Jason Lowe-Power --- M src/base/fiber.hh 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved diff --git a/src/base/fiber.hh b/src/base/fiber.hh index b9f0683..5f7285b 100644 --- a/src/base/fiber.hh +++ b/src/base/fiber.hh @@ -30,7 +30,16 @@ #ifndef __BASE_FIBER_HH__ #define __BASE_FIBER_HH__ +// ucontext functions (like getcontext, setcontext etc) have been marked +// as deprecated and are hence hidden in latest macOS releases. +// By defining _XOPEN_SOURCE we make them available at compilation time. +#if defined(__APPLE__) && defined(__MACH__) +#define _XOPEN_SOURCE 600 #include +#undef _XOPEN_SOURCE +#else +#include +#endif #include #include -- To view, visit https://gem5-review.googlesource.com/11729 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Ic10e6f77a38875828b1891eaed2f0626ec67 Gerrit-Change-Number: 11729 Gerrit-PatchSet: 3 Gerrit-Owner: Giacomo Travaglini Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Giacomo Travaglini Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Matteo Andreozzi Gerrit-Reviewer: Matthias Jung Gerrit-MessageType: merged ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: base: Fix ucontext compilation error for macOS
Hello Gabe Black, Matthias Jung, Jason Lowe-Power, Matteo Andreozzi, Andreas Sandberg, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/11729 to look at the new patch set (#2). Change subject: base: Fix ucontext compilation error for macOS .. base: Fix ucontext compilation error for macOS ucontext functions (like getcontext, setcontext etc) have been marked as deprecated and are hence hidden in latest macOS releases. This patch uncovers them; warnings wil be produced but compilation won't fail since -Wno-error=deprecated-declarations flag is currently used. Change-Id: Ic10e6f77a38875828b1891eaed2f0626ec67 Signed-off-by: Giacomo Travaglini --- M src/base/fiber.hh 1 file changed, 9 insertions(+), 0 deletions(-) -- To view, visit https://gem5-review.googlesource.com/11729 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Ic10e6f77a38875828b1891eaed2f0626ec67 Gerrit-Change-Number: 11729 Gerrit-PatchSet: 2 Gerrit-Owner: Giacomo Travaglini Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Giacomo Travaglini Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Matteo Andreozzi Gerrit-Reviewer: Matthias Jung Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: base: Fix ucontext compilation error for macOS
Giacomo Travaglini has uploaded this change for review. ( https://gem5-review.googlesource.com/11729 Change subject: base: Fix ucontext compilation error for macOS .. base: Fix ucontext compilation error for macOS ucontext functions (like getcontext, setcontext etc) have been marked as deprecated and are hence hidden in latest macOS releases. This patch uncovers them; warnings wil be produced but compilation won't fail since -Wno-error=deprecated-declarations flag is currently used. Change-Id: Ic10e6f77a38875828b1891eaed2f0626ec67 Signed-off-by: Giacomo Travaglini --- M src/base/fiber.hh 1 file changed, 8 insertions(+), 0 deletions(-) diff --git a/src/base/fiber.hh b/src/base/fiber.hh index b9f0683..a09807a 100644 --- a/src/base/fiber.hh +++ b/src/base/fiber.hh @@ -30,7 +30,15 @@ #ifndef __BASE_FIBER_HH__ #define __BASE_FIBER_HH__ +// ucontext functions (like getcontext, setcontext etc) have been marked +// as deprecated and are hence hidden in latest macOS releases. +// By defining _XOPEN_SOURCE we make them available at compilation time. +#if defined(__APPLE__) && defined(__MACH__) +#define _XOPEN_SOURCE 600 #include +#else +#include +#endif #include #include -- To view, visit https://gem5-review.googlesource.com/11729 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Ic10e6f77a38875828b1891eaed2f0626ec67 Gerrit-Change-Number: 11729 Gerrit-PatchSet: 1 Gerrit-Owner: Giacomo Travaglini Gerrit-MessageType: newchange ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
