[gem5-dev] Change in gem5/gem5[master]: cpu-minor: Remove redundant thread startup call

2018-06-14 Thread Andreas Sandberg (Gerrit) 
Andreas Sandberg has submitted this change and it was merged. (  
https://gem5-review.googlesource.com/11037 )


Change subject: cpu-minor: Remove redundant thread startup call
..

cpu-minor: Remove redundant thread startup call

Don't call startup() twice on each of the threads.

Change-Id: Ibe3d1f25c4fdff291ee310abb9bcad3b184bab20
Signed-off-by: Andreas Sandberg 
Reviewed-by: Giacomo Travaglini 
Reviewed-on: https://gem5-review.googlesource.com/11037
---
M src/cpu/minor/cpu.cc
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Giacomo Travaglini: Looks good to me, approved
  Andreas Sandberg: Looks good to me, approved



diff --git a/src/cpu/minor/cpu.cc b/src/cpu/minor/cpu.cc
index 68c0767..63efde2 100644
--- a/src/cpu/minor/cpu.cc
+++ b/src/cpu/minor/cpu.cc
@@ -183,9 +183,6 @@

 BaseCPU::startup();

-for (auto i = threads.begin(); i != threads.end(); i ++)
-(*i)->startup();
-
 for (ThreadID tid = 0; tid < numThreads; tid++) {
 threads[tid]->startup();
 pipeline->wakeupFetch(tid);

--
To view, visit https://gem5-review.googlesource.com/11037
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ibe3d1f25c4fdff291ee310abb9bcad3b184bab20
Gerrit-Change-Number: 11037
Gerrit-PatchSet: 2
Gerrit-Owner: Andreas Sandberg 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[master]: cpu-minor: Remove redundant thread startup call

2018-06-11 Thread Andreas Sandberg (Gerrit) 

Hello Giacomo Travaglini,

I'd like you to do a code review. Please visit

https://gem5-review.googlesource.com/11037

to review the following change.


Change subject: cpu-minor: Remove redundant thread startup call
..

cpu-minor: Remove redundant thread startup call

Don't call startup() twice on each of the threads.

Change-Id: Ibe3d1f25c4fdff291ee310abb9bcad3b184bab20
Signed-off-by: Andreas Sandberg 
Reviewed-by: Giacomo Travaglini 
---
M src/cpu/minor/cpu.cc
1 file changed, 0 insertions(+), 3 deletions(-)



diff --git a/src/cpu/minor/cpu.cc b/src/cpu/minor/cpu.cc
index 68c0767..63efde2 100644
--- a/src/cpu/minor/cpu.cc
+++ b/src/cpu/minor/cpu.cc
@@ -183,9 +183,6 @@

 BaseCPU::startup();

-for (auto i = threads.begin(); i != threads.end(); i ++)
-(*i)->startup();
-
 for (ThreadID tid = 0; tid < numThreads; tid++) {
 threads[tid]->startup();
 pipeline->wakeupFetch(tid);

--
To view, visit https://gem5-review.googlesource.com/11037
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ibe3d1f25c4fdff291ee310abb9bcad3b184bab20
Gerrit-Change-Number: 11037
Gerrit-PatchSet: 1
Gerrit-Owner: Andreas Sandberg 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev