[gem5-dev] Change in gem5/gem5[master]: scons: Disable PyTrafficGen module on Mac OS

2018-12-20 Thread Andrea Mondelli (Gerrit)

Hello Gabe Black, Jason Lowe-Power, Andreas Sandberg,

I'd like you to reexamine a change. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/15175

to look at the new patch set (#2).

Change subject: scons: Disable PyTrafficGen module on Mac OS
..

scons: Disable PyTrafficGen module on Mac OS

PyBind hides a part of a public symbol adding the hidden attribute to
the pybind11 namespace. This cause a linking conflict in SimObject on MacOS
because part of them become hidden.
The MacOS linker does not allow to compile any target, making gem5 not
usable out-of-the-box on OSX.

This patch is a temporary workaround to allow mac users to compile and run
the examples in the gem5 books and in the ASPLOS tutorial.

Change-Id: I5d3af95de491e1d50481bda7d63c4b4e969864fa
---
M src/cpu/testers/traffic_gen/SConscript
1 file changed, 6 insertions(+), 0 deletions(-)


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/15175
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I5d3af95de491e1d50481bda7d63c4b4e969864fa
Gerrit-Change-Number: 15175
Gerrit-PatchSet: 2
Gerrit-Owner: Andrea Mondelli 
Gerrit-Reviewer: Andrea Mondelli 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-CC: Giacomo Gabrielli 
Gerrit-MessageType: newpatchset
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[master]: scons: Disable PyTrafficGen module on Mac OS

2018-12-20 Thread Andrea Mondelli (Gerrit)
Andrea Mondelli has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/15175



Change subject: scons: Disable PyTrafficGen module on Mac OS
..

scons: Disable PyTrafficGen module on Mac OS

PyBind hides a part of a public symbol adding the hidden attribute to the  
pybind11 namespace.
This cause a linking conflict in SimObject on MacOS because part of them  
become hidden.
The MacOS linker does not allow to compile any target, making gem5 not  
usable out-of-the-box on OSX.


This patch is a temporary workaround to allow mac users to compile and run  
the examples in the gem5 books and in the ASPLOS tutorial.


Change-Id: I5d3af95de491e1d50481bda7d63c4b4e969864fa
---
M src/cpu/testers/traffic_gen/SConscript
1 file changed, 6 insertions(+), 0 deletions(-)



diff --git a/src/cpu/testers/traffic_gen/SConscript  
b/src/cpu/testers/traffic_gen/SConscript

index 700676a..55f2537 100644
--- a/src/cpu/testers/traffic_gen/SConscript
+++ b/src/cpu/testers/traffic_gen/SConscript
@@ -39,6 +39,8 @@

 Import('*')

+from m5.util import compareVersions
+from m5.util.terminal import termcap

 Source('base.cc')
 Source('base_gen.cc')
@@ -54,6 +56,10 @@
 SimObject('BaseTrafficGen.py')

 if env['USE_PYTHON']:
+if env['PLATFORM'] == 'darwin':
+print(termcap.Yellow + termcap.Bold +
+  'Warning: Skip PyTrafficGen module on Mac OS.' + termcap.Normal)
+Return()
 Source('pygen.cc', add_tags='python')
 SimObject('PyTrafficGen.py')


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/15175
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I5d3af95de491e1d50481bda7d63c4b4e969864fa
Gerrit-Change-Number: 15175
Gerrit-PatchSet: 1
Gerrit-Owner: Andrea Mondelli 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev