[gem5-dev] Change in gem5/gem5[master]: systemc: Add a nonstandard sc_signal constructor.

2018-08-21 Thread Gabe Black (Gerrit) 
Gabe Black has submitted this change and it was merged. (  
https://gem5-review.googlesource.com/c/public/gem5/+/11266 )


Change subject: systemc: Add a nonstandard sc_signal constructor.
..

systemc: Add a nonstandard sc_signal constructor.

This constructor takes an initial value to set the sc_signal to, and
is used in the tests.

Change-Id: I197218846d9a79f9237238c78b1bbd8a7f55443f
Reviewed-on: https://gem5-review.googlesource.com/11266
Reviewed-by: Gabe Black 
Maintainer: Gabe Black 
---
M src/systemc/ext/channel/sc_signal.hh
1 file changed, 19 insertions(+), 0 deletions(-)

Approvals:
  Gabe Black: Looks good to me, approved; Looks good to me, approved



diff --git a/src/systemc/ext/channel/sc_signal.hh  
b/src/systemc/ext/channel/sc_signal.hh

index e1ed619..de571b2 100644
--- a/src/systemc/ext/channel/sc_signal.hh
+++ b/src/systemc/ext/channel/sc_signal.hh
@@ -53,6 +53,12 @@
 explicit sc_signal(const char *name) : sc_signal_inout_if(),
sc_prim_channel(name)
 {}
+explicit sc_signal(const char *name, const T _value) :
+sc_signal_inout_if(), sc_prim_channel(name)
+{
+// Need to consume initial_value.
+sc_channel_warn_unimpl(__PRETTY_FUNCTION__);
+}
 virtual ~sc_signal() {}

 virtual void
@@ -162,6 +168,12 @@
 {
 sc_channel_warn_unimpl(__PRETTY_FUNCTION__);
 }
+explicit sc_signal(const char *name, const bool _value) :
+sc_signal_inout_if(), sc_prim_channel(name)
+{
+// Need to consume initial_value.
+sc_channel_warn_unimpl(__PRETTY_FUNCTION__);
+}
 virtual ~sc_signal()
 {
 sc_channel_warn_unimpl(__PRETTY_FUNCTION__);
@@ -292,6 +304,13 @@
 {
 sc_channel_warn_unimpl(__PRETTY_FUNCTION__);
 }
+explicit sc_signal(const char *name,
+const sc_dt::sc_logic _value) :
+sc_signal_inout_if(), sc_prim_channel(name)
+{
+// Need to consume initial_value.
+sc_channel_warn_unimpl(__PRETTY_FUNCTION__);
+}
 virtual ~sc_signal()
 {
 sc_channel_warn_unimpl(__PRETTY_FUNCTION__);

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/11266
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I197218846d9a79f9237238c78b1bbd8a7f55443f
Gerrit-Change-Number: 11266
Gerrit-PatchSet: 5
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Matthias Jung 
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[master]: systemc: Add a nonstandard sc_signal constructor.

2018-06-29 Thread Gabe Black (Gerrit) 

Hello Jason Lowe-Power, Matthias Jung, Giacomo Travaglini, Andreas Sandberg,

I'd like you to reexamine a change. Please visit

https://gem5-review.googlesource.com/11266

to look at the new patch set (#2).

Change subject: systemc: Add a nonstandard sc_signal constructor.
..

systemc: Add a nonstandard sc_signal constructor.

This constructor takes an initial value to set the sc_signal to, and
is used in the tests.

Change-Id: I197218846d9a79f9237238c78b1bbd8a7f55443f
---
M src/systemc/ext/channel/sc_signal.hh
1 file changed, 19 insertions(+), 0 deletions(-)


--
To view, visit https://gem5-review.googlesource.com/11266
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I197218846d9a79f9237238c78b1bbd8a7f55443f
Gerrit-Change-Number: 11266
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Matthias Jung 
Gerrit-MessageType: newpatchset
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[master]: systemc: Add a nonstandard sc_signal constructor.

2018-06-16 Thread Gabe Black (Gerrit) 
Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/11266



Change subject: systemc: Add a nonstandard sc_signal constructor.
..

systemc: Add a nonstandard sc_signal constructor.

This constructor takes an initial value to set the sc_signal to, and
is used in the tests.

Change-Id: I197218846d9a79f9237238c78b1bbd8a7f55443f
---
M src/systemc/ext/channel/sc_signal.hh
1 file changed, 6 insertions(+), 0 deletions(-)



diff --git a/src/systemc/ext/channel/sc_signal.hh  
b/src/systemc/ext/channel/sc_signal.hh

index e1ed619..a0b12b6 100644
--- a/src/systemc/ext/channel/sc_signal.hh
+++ b/src/systemc/ext/channel/sc_signal.hh
@@ -53,6 +53,12 @@
 explicit sc_signal(const char *name) : sc_signal_inout_if(),
sc_prim_channel(name)
 {}
+explicit sc_signal(const char *name, const T _value) :
+sc_signal_inout_if(), sc_prim_channel(name)
+{
+// Need to consume initial_value.
+sc_channel_warn_unimpl(__PRETTY_FUNCTION__);
+}
 virtual ~sc_signal() {}

 virtual void

--
To view, visit https://gem5-review.googlesource.com/11266
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I197218846d9a79f9237238c78b1bbd8a7f55443f
Gerrit-Change-Number: 11266
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev