[gem5-dev] Change in gem5/gem5[master]: systemc: Add an sc_event_finder::find_event method.

2018-08-28 Thread Gabe Black (Gerrit) 
Gabe Black has submitted this change and it was merged. (  
https://gem5-review.googlesource.com/c/public/gem5/+/11274 )


Change subject: systemc: Add an sc_event_finder::find_event method.
..

systemc: Add an sc_event_finder::find_event method.

The guts of sc_event_finder are supposed to be implementation defined,
but the tests reach in and call this particular method on that class.

Change-Id: I21c18fa68ccce7bc1a13122ee3b452ecb81b713a
Reviewed-on: https://gem5-review.googlesource.com/11274
Reviewed-by: Gabe Black 
Maintainer: Gabe Black 
---
M src/systemc/ext/core/sc_event.hh
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Gabe Black: Looks good to me, approved; Looks good to me, approved



diff --git a/src/systemc/ext/core/sc_event.hh  
b/src/systemc/ext/core/sc_event.hh

index 8eb1283..0b901ff 100644
--- a/src/systemc/ext/core/sc_event.hh
+++ b/src/systemc/ext/core/sc_event.hh
@@ -40,6 +40,7 @@
 class sc_event;
 class sc_event_and_expr;
 class sc_event_or_expr;
+class sc_interface;
 class sc_object;
 class sc_port_base;

@@ -47,6 +48,10 @@
 {
   protected:
 void warn_unimpl(const char *func) const;
+
+  public:
+// Should be "implementation defined" but used in the tests.
+virtual const sc_event _event(sc_interface *if_p=NULL) const = 0;
 };

 template 
@@ -58,6 +63,13 @@
 {
 warn_unimpl(__PRETTY_FUNCTION__);
 }
+
+const sc_event &
+find_event(sc_interface *if_p=NULL) const override
+{
+warn_unimpl(__PRETTY_FUNCTION__);
+return *(const sc_event *)nullptr;
+}
 };

 class sc_event_and_list

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/11274
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I21c18fa68ccce7bc1a13122ee3b452ecb81b713a
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 7
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Matthias Jung 
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[master]: systemc: Add an sc_event_finder::find_event method.

2018-08-21 Thread Gabe Black (Gerrit) 

Hello Jason Lowe-Power, Matthias Jung, Giacomo Travaglini, Andreas Sandberg,

I'd like you to reexamine a change. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/11274

to look at the new patch set (#6).

Change subject: systemc: Add an sc_event_finder::find_event method.
..

systemc: Add an sc_event_finder::find_event method.

The guts of sc_event_finder are supposed to be implementation defined,
but the tests reach in and call this particular method on that class.

Change-Id: I21c18fa68ccce7bc1a13122ee3b452ecb81b713a
---
M src/systemc/ext/core/sc_event.hh
1 file changed, 12 insertions(+), 0 deletions(-)


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/11274
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I21c18fa68ccce7bc1a13122ee3b452ecb81b713a
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 6
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Matthias Jung 
Gerrit-MessageType: newpatchset
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[master]: systemc: Add an sc_event_finder::find_event method.

2018-06-16 Thread Gabe Black (Gerrit) 
Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/11274



Change subject: systemc: Add an sc_event_finder::find_event method.
..

systemc: Add an sc_event_finder::find_event method.

The guts of sc_event_finder are supposed to be implementation defined,
but the tests reach in and call this particular method on that class.

Change-Id: I21c18fa68ccce7bc1a13122ee3b452ecb81b713a
---
M src/systemc/ext/core/sc_event.hh
1 file changed, 12 insertions(+), 0 deletions(-)



diff --git a/src/systemc/ext/core/sc_event.hh  
b/src/systemc/ext/core/sc_event.hh

index 8eb1283..0b901ff 100644
--- a/src/systemc/ext/core/sc_event.hh
+++ b/src/systemc/ext/core/sc_event.hh
@@ -40,6 +40,7 @@
 class sc_event;
 class sc_event_and_expr;
 class sc_event_or_expr;
+class sc_interface;
 class sc_object;
 class sc_port_base;

@@ -47,6 +48,10 @@
 {
   protected:
 void warn_unimpl(const char *func) const;
+
+  public:
+// Should be "implementation defined" but used in the tests.
+virtual const sc_event _event(sc_interface *if_p=NULL) const = 0;
 };

 template 
@@ -58,6 +63,13 @@
 {
 warn_unimpl(__PRETTY_FUNCTION__);
 }
+
+const sc_event &
+find_event(sc_interface *if_p=NULL) const override
+{
+warn_unimpl(__PRETTY_FUNCTION__);
+return *(const sc_event *)nullptr;
+}
 };

 class sc_event_and_list

--
To view, visit https://gem5-review.googlesource.com/11274
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I21c18fa68ccce7bc1a13122ee3b452ecb81b713a
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev