[gem5-dev] Change in gem5/gem5[master]: systemc: Add some deprecated sc_module constructors.

2018-08-28 Thread Gabe Black (Gerrit) 
Gabe Black has submitted this change and it was merged. (  
https://gem5-review.googlesource.com/c/public/gem5/+/11278 )


Change subject: systemc: Add some deprecated sc_module constructors.
..

systemc: Add some deprecated sc_module constructors.

Change-Id: Ibe2bfe63536af33fca6040f4aef999ee928d876b
Reviewed-on: https://gem5-review.googlesource.com/11278
Reviewed-by: Gabe Black 
Maintainer: Gabe Black 
---
M src/systemc/core/sc_module.cc
M src/systemc/ext/core/sc_module.hh
2 files changed, 14 insertions(+), 0 deletions(-)

Approvals:
  Gabe Black: Looks good to me, approved; Looks good to me, approved



diff --git a/src/systemc/core/sc_module.cc b/src/systemc/core/sc_module.cc
index a461022..b4fd292 100644
--- a/src/systemc/core/sc_module.cc
+++ b/src/systemc/core/sc_module.cc
@@ -155,6 +155,16 @@
 warn("%s not implemented.\n", __PRETTY_FUNCTION__);
 }

+sc_module::sc_module(const char *)
+{
+warn("%s not implemented.\n", __PRETTY_FUNCTION__);
+}
+
+sc_module::sc_module(const std::string &)
+{
+warn("%s not implemented.\n", __PRETTY_FUNCTION__);
+}
+
 void
 sc_module::reset_signal_is(const sc_in &, bool)
 {
diff --git a/src/systemc/ext/core/sc_module.hh  
b/src/systemc/ext/core/sc_module.hh

index 25053df..ffb1a3c 100644
--- a/src/systemc/ext/core/sc_module.hh
+++ b/src/systemc/ext/core/sc_module.hh
@@ -148,6 +148,10 @@
 sc_module(const sc_module_name &);
 sc_module();

+// Deprecated
+sc_module(const char *);
+sc_module(const std::string &);
+
 /* Deprecated, but used in the regression tests. */
 void end_module() {}


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/11278
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ibe2bfe63536af33fca6040f4aef999ee928d876b
Gerrit-Change-Number: 11278
Gerrit-PatchSet: 7
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Matthias Jung 
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[master]: systemc: Add some deprecated sc_module constructors.

2018-08-21 Thread Gabe Black (Gerrit) 

Hello Jason Lowe-Power, Matthias Jung, Giacomo Travaglini, Andreas Sandberg,

I'd like you to reexamine a change. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/11278

to look at the new patch set (#6).

Change subject: systemc: Add some deprecated sc_module constructors.
..

systemc: Add some deprecated sc_module constructors.

Change-Id: Ibe2bfe63536af33fca6040f4aef999ee928d876b
---
M src/systemc/core/sc_module.cc
M src/systemc/ext/core/sc_module.hh
2 files changed, 14 insertions(+), 0 deletions(-)


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/11278
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ibe2bfe63536af33fca6040f4aef999ee928d876b
Gerrit-Change-Number: 11278
Gerrit-PatchSet: 6
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Matthias Jung 
Gerrit-MessageType: newpatchset
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[master]: systemc: Add some deprecated sc_module constructors.

2018-06-16 Thread Gabe Black (Gerrit) 
Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/11278



Change subject: systemc: Add some deprecated sc_module constructors.
..

systemc: Add some deprecated sc_module constructors.

Change-Id: Ibe2bfe63536af33fca6040f4aef999ee928d876b
---
M src/systemc/core/sc_module.cc
M src/systemc/ext/core/sc_module.hh
2 files changed, 14 insertions(+), 0 deletions(-)



diff --git a/src/systemc/core/sc_module.cc b/src/systemc/core/sc_module.cc
index a461022..b4fd292 100644
--- a/src/systemc/core/sc_module.cc
+++ b/src/systemc/core/sc_module.cc
@@ -155,6 +155,16 @@
 warn("%s not implemented.\n", __PRETTY_FUNCTION__);
 }

+sc_module::sc_module(const char *)
+{
+warn("%s not implemented.\n", __PRETTY_FUNCTION__);
+}
+
+sc_module::sc_module(const std::string &)
+{
+warn("%s not implemented.\n", __PRETTY_FUNCTION__);
+}
+
 void
 sc_module::reset_signal_is(const sc_in &, bool)
 {
diff --git a/src/systemc/ext/core/sc_module.hh  
b/src/systemc/ext/core/sc_module.hh

index 25053df..ffb1a3c 100644
--- a/src/systemc/ext/core/sc_module.hh
+++ b/src/systemc/ext/core/sc_module.hh
@@ -148,6 +148,10 @@
 sc_module(const sc_module_name &);
 sc_module();

+// Deprecated
+sc_module(const char *);
+sc_module(const std::string &);
+
 /* Deprecated, but used in the regression tests. */
 void end_module() {}


--
To view, visit https://gem5-review.googlesource.com/11278
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ibe2bfe63536af33fca6040f4aef999ee928d876b
Gerrit-Change-Number: 11278
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev