[gem5-dev] Change in gem5/gem5[master]: systemc: Add the nonstandard sc_trace_params and sc_trace_params_vec.
Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/11283 )
Change subject: systemc: Add the nonstandard sc_trace_params and
sc_trace_params_vec.
..
systemc: Add the nonstandard sc_trace_params and sc_trace_params_vec.
These two types are supposedly only for internal use in the Accellera
implementation based on a big warning in all caps, but they still
appear in the tests and examples in that version of systemc.
Change-Id: Icfb3ffdf1e78988def5dac145172bf28f93d7d38
Reviewed-on: https://gem5-review.googlesource.com/11283
Reviewed-by: Gabe Black
Maintainer: Gabe Black
---
M src/systemc/ext/channel/sc_signal.hh
1 file changed, 18 insertions(+), 0 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
diff --git a/src/systemc/ext/channel/sc_signal.hh
b/src/systemc/ext/channel/sc_signal.hh
index de571b2..b41af56 100644
--- a/src/systemc/ext/channel/sc_signal.hh
+++ b/src/systemc/ext/channel/sc_signal.hh
@@ -31,6 +31,8 @@
#define __SYSTEMC_EXT_CHANNEL_SC_SIGNAL_HH__
#include
+#include
+#include
#include "../core/sc_module.hh" // for sc_gen_unique_name
#include "../core/sc_prim.hh"
@@ -41,6 +43,22 @@
{
class sc_port_base;
+class sc_trace_file;
+
+// Nonstandard
+// Despite having a warning "FOR INTERNAL USE ONLY!" in all caps above this
+// class definition in the Accellera implementation, it appears in their
+// examples and test programs, and so we need to have it here as well.
+struct sc_trace_params
+{
+sc_trace_file *tf;
+std::string name;
+
+sc_trace_params(sc_trace_file *tf, const std::string ) :
+tf(tf), name(name)
+{}
+};
+typedef std::vector sc_trace_params_vec;
template
class sc_signal : public sc_signal_inout_if,
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/11283
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Icfb3ffdf1e78988def5dac145172bf28f93d7d38
Gerrit-Change-Number: 11283
Gerrit-PatchSet: 7
Gerrit-Owner: Gabe Black
Gerrit-Reviewer: Andreas Sandberg
Gerrit-Reviewer: Gabe Black
Gerrit-Reviewer: Giacomo Travaglini
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-Reviewer: Matthias Jung
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: systemc: Add the nonstandard sc_trace_params and sc_trace_params_vec.
Hello Jason Lowe-Power, Matthias Jung, Giacomo Travaglini, Andreas Sandberg, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/11283 to look at the new patch set (#6). Change subject: systemc: Add the nonstandard sc_trace_params and sc_trace_params_vec. .. systemc: Add the nonstandard sc_trace_params and sc_trace_params_vec. These two types are supposedly only for internal use in the Accellera implementation based on a big warning in all caps, but they still appear in the tests and examples in that version of systemc. Change-Id: Icfb3ffdf1e78988def5dac145172bf28f93d7d38 --- M src/systemc/ext/channel/sc_signal.hh 1 file changed, 18 insertions(+), 0 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/11283 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Icfb3ffdf1e78988def5dac145172bf28f93d7d38 Gerrit-Change-Number: 11283 Gerrit-PatchSet: 6 Gerrit-Owner: Gabe Black Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Giacomo Travaglini Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Matthias Jung Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: systemc: Add the nonstandard sc_trace_params and sc_trace_params_vec.
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/11283
Change subject: systemc: Add the nonstandard sc_trace_params and
sc_trace_params_vec.
..
systemc: Add the nonstandard sc_trace_params and sc_trace_params_vec.
These two types are supposedly only for internal use in the Accellera
implementation based on a big warning in all caps, but they still
appear in the tests and examples in that version of systemc.
Change-Id: Icfb3ffdf1e78988def5dac145172bf28f93d7d38
---
M src/systemc/ext/channel/sc_signal.hh
1 file changed, 18 insertions(+), 0 deletions(-)
diff --git a/src/systemc/ext/channel/sc_signal.hh
b/src/systemc/ext/channel/sc_signal.hh
index a0b12b6..dea01a2 100644
--- a/src/systemc/ext/channel/sc_signal.hh
+++ b/src/systemc/ext/channel/sc_signal.hh
@@ -31,6 +31,8 @@
#define __SYSTEMC_EXT_CHANNEL_SC_SIGNAL_HH__
#include
+#include
+#include
#include "../core/sc_module.hh" // for sc_gen_unique_name
#include "../core/sc_prim.hh"
@@ -41,6 +43,22 @@
{
class sc_port_base;
+class sc_trace_file;
+
+// Nonstandard
+// Despite having a warning "FOR INTERNAL USE ONLY!" in all caps above this
+// class definition in the Accellera implementation, it appears in their
+// examples and test programs, and so we need to have it here as well.
+struct sc_trace_params
+{
+sc_trace_file *tf;
+std::string name;
+
+sc_trace_params(sc_trace_file *tf, const std::string ) :
+tf(tf), name(name)
+{}
+};
+typedef std::vector sc_trace_params_vec;
template
class sc_signal : public sc_signal_inout_if,
--
To view, visit https://gem5-review.googlesource.com/11283
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Icfb3ffdf1e78988def5dac145172bf28f93d7d38
Gerrit-Change-Number: 11283
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
