[gem5-dev] Change in gem5/gem5[master]: systemc: Disable a few more tests that aren't going to work.
Gabe Black has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/11287 ) Change subject: systemc: Disable a few more tests that aren't going to work. .. systemc: Disable a few more tests that aren't going to work. One would never have worked as far as I can tell, and the others depend on a feature that breaks building the systemc library. Change-Id: Ia3db31a15675ca6df2db16362ee2d9c8700cd0af Reviewed-on: https://gem5-review.googlesource.com/11287 Reviewed-by: Gabe Black Maintainer: Gabe Black --- M src/systemc/tests/working.filt 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Gabe Black: Looks good to me, approved; Looks good to me, approved diff --git a/src/systemc/tests/working.filt b/src/systemc/tests/working.filt index 75cc837..9604768 100644 --- a/src/systemc/tests/working.filt +++ b/src/systemc/tests/working.filt @@ -33,6 +33,16 @@ # This test declares a constructor it never defines, so it's not clear how # it would ever work? "systemc/misc/stars/star104726", + +# Another test which calls an undefined function. +"systemc/misc/gnats/pr-480", + +# These tests rely on implicit FXVAL constructors based on primitive types, +# but enabling that makes other operator overloads ambiguous so things +# don't compile. It also seems dangerous to change what the headers look +# like between the backing implementation and the consuming application. +"systemc/datatypes/fx/fast_constructors", +"systemc/datatypes/fx/constructors", ), ]) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/11287 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Ia3db31a15675ca6df2db16362ee2d9c8700cd0af Gerrit-Change-Number: 11287 Gerrit-PatchSet: 9 Gerrit-Owner: Gabe Black Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Giacomo Travaglini Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Matthias Jung Gerrit-MessageType: merged ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: systemc: Disable a few more tests that aren't going to work.
Hello Jason Lowe-Power, Matthias Jung, Giacomo Travaglini, Andreas Sandberg, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/11287 to look at the new patch set (#7). Change subject: systemc: Disable a few more tests that aren't going to work. .. systemc: Disable a few more tests that aren't going to work. One would never have worked as far as I can tell, and the others depend on a feature that breaks building the systemc library. Change-Id: Ia3db31a15675ca6df2db16362ee2d9c8700cd0af --- M src/systemc/tests/working.filt 1 file changed, 10 insertions(+), 0 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/11287 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Ia3db31a15675ca6df2db16362ee2d9c8700cd0af Gerrit-Change-Number: 11287 Gerrit-PatchSet: 7 Gerrit-Owner: Gabe Black Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Giacomo Travaglini Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Matthias Jung Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: systemc: Disable a few more tests that aren't going to work.
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/11287 Change subject: systemc: Disable a few more tests that aren't going to work. .. systemc: Disable a few more tests that aren't going to work. One would never have worked as far as I can tell, and the others depend on a feature that breaks building the systemc library. Change-Id: Ia3db31a15675ca6df2db16362ee2d9c8700cd0af --- M src/systemc/tests/working.filt 1 file changed, 10 insertions(+), 0 deletions(-) diff --git a/src/systemc/tests/working.filt b/src/systemc/tests/working.filt index 75cc837..9604768 100644 --- a/src/systemc/tests/working.filt +++ b/src/systemc/tests/working.filt @@ -33,6 +33,16 @@ # This test declares a constructor it never defines, so it's not clear how # it would ever work? "systemc/misc/stars/star104726", + +# Another test which calls an undefined function. +"systemc/misc/gnats/pr-480", + +# These tests rely on implicit FXVAL constructors based on primitive types, +# but enabling that makes other operator overloads ambiguous so things +# don't compile. It also seems dangerous to change what the headers look +# like between the backing implementation and the consuming application. +"systemc/datatypes/fx/fast_constructors", +"systemc/datatypes/fx/constructors", ), ]) -- To view, visit https://gem5-review.googlesource.com/11287 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Ia3db31a15675ca6df2db16362ee2d9c8700cd0af Gerrit-Change-Number: 11287 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
