[gem5-dev] Change in gem5/gem5[master]: systemc: Disable the phase_callbacks set of tests.
Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/11285 )
Change subject: systemc: Disable the phase_callbacks set of tests.
..
systemc: Disable the phase_callbacks set of tests.
This feature is experimental, nonstandard, and would in some cases be
difficult to implement in gem5.
Change-Id: Ic7fe77e6a2e9dbc5aba06579fb85fd2f055cb6b1
Reviewed-on: https://gem5-review.googlesource.com/11285
Reviewed-by: Gabe Black
Maintainer: Gabe Black
---
M src/systemc/tests/working.filt
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
diff --git a/src/systemc/tests/working.filt b/src/systemc/tests/working.filt
index e28b74b..75cc837 100644
--- a/src/systemc/tests/working.filt
+++ b/src/systemc/tests/working.filt
@@ -12,6 +12,11 @@
# something we're not currently planning to support.
path.startswith("systemc/kernel/sc_process_b"),
+# Phase callbacks are an experimental feature. Also calling all the
interested
+# sc_objects whenever time advances would add a non-trivial amount of
+# complexity and is probably not worth implementing in general.
+path.startswith("systemc/kernel/phase_callbacks/"),
+
path in (
# Uses sc_get_curr_simcontext.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/11285
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ic7fe77e6a2e9dbc5aba06579fb85fd2f055cb6b1
Gerrit-Change-Number: 11285
Gerrit-PatchSet: 7
Gerrit-Owner: Gabe Black
Gerrit-Reviewer: Andreas Sandberg
Gerrit-Reviewer: Gabe Black
Gerrit-Reviewer: Giacomo Travaglini
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-Reviewer: Matthias Jung
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: systemc: Disable the phase_callbacks set of tests.
Hello Jason Lowe-Power, Matthias Jung, Giacomo Travaglini, Andreas Sandberg, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/11285 to look at the new patch set (#6). Change subject: systemc: Disable the phase_callbacks set of tests. .. systemc: Disable the phase_callbacks set of tests. This feature is experimental, nonstandard, and would in some cases be difficult to implement in gem5. Change-Id: Ic7fe77e6a2e9dbc5aba06579fb85fd2f055cb6b1 --- M src/systemc/tests/working.filt 1 file changed, 5 insertions(+), 0 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/11285 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Ic7fe77e6a2e9dbc5aba06579fb85fd2f055cb6b1 Gerrit-Change-Number: 11285 Gerrit-PatchSet: 6 Gerrit-Owner: Gabe Black Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Giacomo Travaglini Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Matthias Jung Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: systemc: Disable the phase_callbacks set of tests.
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/11285
Change subject: systemc: Disable the phase_callbacks set of tests.
..
systemc: Disable the phase_callbacks set of tests.
This feature is experimental, nonstandard, and would in some cases be
difficult to implement in gem5.
Change-Id: Ic7fe77e6a2e9dbc5aba06579fb85fd2f055cb6b1
---
M src/systemc/tests/working.filt
1 file changed, 5 insertions(+), 0 deletions(-)
diff --git a/src/systemc/tests/working.filt b/src/systemc/tests/working.filt
index e28b74b..75cc837 100644
--- a/src/systemc/tests/working.filt
+++ b/src/systemc/tests/working.filt
@@ -12,6 +12,11 @@
# something we're not currently planning to support.
path.startswith("systemc/kernel/sc_process_b"),
+# Phase callbacks are an experimental feature. Also calling all the
interested
+# sc_objects whenever time advances would add a non-trivial amount of
+# complexity and is probably not worth implementing in general.
+path.startswith("systemc/kernel/phase_callbacks/"),
+
path in (
# Uses sc_get_curr_simcontext.
--
To view, visit https://gem5-review.googlesource.com/11285
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ic7fe77e6a2e9dbc5aba06579fb85fd2f055cb6b1
Gerrit-Change-Number: 11285
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
