[gem5-dev] Change in gem5/gem5[master]: systemc: Make some functions static in conflict with the spec.
Gabe Black has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/11282 ) Change subject: systemc: Make some functions static in conflict with the spec. .. systemc: Make some functions static in conflict with the spec. The spec is likely wrong in this case since a lot of the other neighboring functions are static, and the Accellera implementation and the tests seem to assume they're static. Change-Id: Ia12a3735497b50f8a2419a52c83ef256416e7bc5 Reviewed-on: https://gem5-review.googlesource.com/11282 Reviewed-by: Gabe Black Maintainer: Gabe Black --- M src/systemc/ext/utils/sc_report_handler.hh 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Gabe Black: Looks good to me, approved; Looks good to me, approved diff --git a/src/systemc/ext/utils/sc_report_handler.hh b/src/systemc/ext/utils/sc_report_handler.hh index f6e32b9..33c2499 100644 --- a/src/systemc/ext/utils/sc_report_handler.hh +++ b/src/systemc/ext/utils/sc_report_handler.hh @@ -89,8 +89,11 @@ static int get_count(const char *msg_type); static int get_count(const char *msg_type, sc_severity); -int set_verbosity_level(int); -int get_verbosity_level(); +// Nonstandard +// In the spec, these aren't listed as static functions. They are static in +// the Accellera implementation and are used as such in the tests. +static int set_verbosity_level(int); +static int get_verbosity_level(); static sc_actions suppress(sc_actions); static sc_actions suppress(); -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/11282 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Ia12a3735497b50f8a2419a52c83ef256416e7bc5 Gerrit-Change-Number: 11282 Gerrit-PatchSet: 8 Gerrit-Owner: Gabe Black Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Giacomo Travaglini Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Matthias Jung Gerrit-MessageType: merged ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: systemc: Make some functions static in conflict with the spec.
Hello Jason Lowe-Power, Matthias Jung, Giacomo Travaglini, Andreas Sandberg, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/11282 to look at the new patch set (#6). Change subject: systemc: Make some functions static in conflict with the spec. .. systemc: Make some functions static in conflict with the spec. The spec is likely wrong in this case since a lot of the other neighboring functions are static, and the Accellera implementation and the tests seem to assume they're static. Change-Id: Ia12a3735497b50f8a2419a52c83ef256416e7bc5 --- M src/systemc/ext/utils/sc_report_handler.hh 1 file changed, 5 insertions(+), 2 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/11282 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Ia12a3735497b50f8a2419a52c83ef256416e7bc5 Gerrit-Change-Number: 11282 Gerrit-PatchSet: 6 Gerrit-Owner: Gabe Black Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Giacomo Travaglini Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Matthias Jung Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: systemc: Make some functions static in conflict with the spec.
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/11282 Change subject: systemc: Make some functions static in conflict with the spec. .. systemc: Make some functions static in conflict with the spec. The spec is likely wrong in this case since a lot of the other neighboring functions are static, and the Accellera implementation and the tests seem to assume they're static. Change-Id: Ia12a3735497b50f8a2419a52c83ef256416e7bc5 --- M src/systemc/ext/utils/sc_report_handler.hh 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/systemc/ext/utils/sc_report_handler.hh b/src/systemc/ext/utils/sc_report_handler.hh index f6e32b9..33c2499 100644 --- a/src/systemc/ext/utils/sc_report_handler.hh +++ b/src/systemc/ext/utils/sc_report_handler.hh @@ -89,8 +89,11 @@ static int get_count(const char *msg_type); static int get_count(const char *msg_type, sc_severity); -int set_verbosity_level(int); -int get_verbosity_level(); +// Nonstandard +// In the spec, these aren't listed as static functions. They are static in +// the Accellera implementation and are used as such in the tests. +static int set_verbosity_level(int); +static int get_verbosity_level(); static sc_actions suppress(sc_actions); static sc_actions suppress(); -- To view, visit https://gem5-review.googlesource.com/11282 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Ia12a3735497b50f8a2419a52c83ef256416e7bc5 Gerrit-Change-Number: 11282 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
