[gem5-dev] Change in public/gem5[master]: mem-cache: Remove extra numSets zero check.

[Daniel Carvalho (Gerrit)]

Daniel Carvalho merged this change by Daniel R. Carvalho. (  
https://gem5-review.googlesource.com/7901 )


Change subject: mem-cache: Remove extra numSets zero check.
..

mem-cache: Remove extra numSets zero check.

numSets is unsigned, so it cannot be lower than 0. Besides, isPowerOf2(0)
is false by definition (and implemmentation*), so there is no need for the
double check.

* As presented in base/intmath.hh

Change-Id: I3f6296694a937434feddc7ed21f11c2a6fdfc5a9
Reviewed-on: https://gem5-review.googlesource.com/7901
Reviewed-by: Andreas Sandberg 
Reviewed-by: Nikos Nikoleris 
Maintainer: Andreas Sandberg 
---
M src/mem/cache/tags/base_set_assoc.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
  Nikos Nikoleris: Looks good to me, approved



diff --git a/src/mem/cache/tags/base_set_assoc.cc  
b/src/mem/cache/tags/base_set_assoc.cc

index ea74c97..ba94475 100644
--- a/src/mem/cache/tags/base_set_assoc.cc
+++ b/src/mem/cache/tags/base_set_assoc.cc
@@ -63,7 +63,7 @@
 if (blkSize < 4 || !isPowerOf2(blkSize)) {
 fatal("Block size must be at least 4 and a power of 2");
 }
-if (numSets <= 0 || !isPowerOf2(numSets)) {
+if (!isPowerOf2(numSets)) {
 fatal("# of sets must be non-zero and a power of 2");
 }
 if (assoc <= 0) {

--
To view, visit https://gem5-review.googlesource.com/7901
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f6296694a937434feddc7ed21f11c2a6fdfc5a9
Gerrit-Change-Number: 7901
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Carvalho 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Reviewer: Daniel Carvalho 
Gerrit-Reviewer: Nikos Nikoleris 
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in public/gem5[master]: mem-cache: Remove extra numSets zero check.

[Daniel Carvalho (Gerrit)]

Daniel Carvalho has uploaded this change for review. (  
https://gem5-review.googlesource.com/7901



Change subject: mem-cache: Remove extra numSets zero check.
..

mem-cache: Remove extra numSets zero check.

numSets is unsigned, so it cannot be lower than 0. Besides, isPowerOf2(0)
is false by definition (and implemmentation*), so there is no need for the
double check.

* As presented in base/intmath.hh

Change-Id: I3f6296694a937434feddc7ed21f11c2a6fdfc5a9
---
M src/mem/cache/tags/base_set_assoc.cc
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/mem/cache/tags/base_set_assoc.cc  
b/src/mem/cache/tags/base_set_assoc.cc

index ea74c97..ba94475 100644
--- a/src/mem/cache/tags/base_set_assoc.cc
+++ b/src/mem/cache/tags/base_set_assoc.cc
@@ -63,7 +63,7 @@
 if (blkSize < 4 || !isPowerOf2(blkSize)) {
 fatal("Block size must be at least 4 and a power of 2");
 }
-if (numSets <= 0 || !isPowerOf2(numSets)) {
+if (!isPowerOf2(numSets)) {
 fatal("# of sets must be non-zero and a power of 2");
 }
 if (assoc <= 0) {

--
To view, visit https://gem5-review.googlesource.com/7901
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f6296694a937434feddc7ed21f11c2a6fdfc5a9
Gerrit-Change-Number: 7901
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Carvalho 
Gerrit-Reviewer: Daniel Carvalho 
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev