[gem5-dev] Change in public/gem5[master]: mem-cache: Remove mumBlock redundant initialiation from FALRU

[Nikos Nikoleris (Gerrit)]

Nikos Nikoleris has submitted this change and it was merged. (  
https://gem5-review.googlesource.com/8281 )


Change subject: mem-cache: Remove mumBlock redundant initialiation from  
FALRU

..

mem-cache: Remove mumBlock redundant initialiation from FALRU

Change-Id: Id3afec0a62446d6d0f44ccb655032343037637e0
Reviewed-by: Curtis Dunham 
Reviewed-on: https://gem5-review.googlesource.com/8281
Reviewed-by: Daniel Carvalho 
Maintainer: Nikos Nikoleris 
---
M src/mem/cache/tags/base.hh
M src/mem/cache/tags/fa_lru.cc
2 files changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Daniel Carvalho: Looks good to me, approved
  Nikos Nikoleris: Looks good to me, approved



diff --git a/src/mem/cache/tags/base.hh b/src/mem/cache/tags/base.hh
index 2c528a9..9714d9a 100644
--- a/src/mem/cache/tags/base.hh
+++ b/src/mem/cache/tags/base.hh
@@ -91,7 +91,7 @@
 bool warmedUp;

 /** the number of blocks in the cache */
-unsigned numBlocks;
+const unsigned numBlocks;

 // Statistics
 /**
diff --git a/src/mem/cache/tags/fa_lru.cc b/src/mem/cache/tags/fa_lru.cc
index dfd4c40..1ee34b7 100644
--- a/src/mem/cache/tags/fa_lru.cc
+++ b/src/mem/cache/tags/fa_lru.cc
@@ -73,8 +73,6 @@
 cacheMask = 0;
 }

-numBlocks = size/blkSize;
-
 blks = new FALRUBlk[numBlocks];
 head = &(blks[0]);
 tail = &(blks[numBlocks-1]);

--
To view, visit https://gem5-review.googlesource.com/8281
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Id3afec0a62446d6d0f44ccb655032343037637e0
Gerrit-Change-Number: 8281
Gerrit-PatchSet: 3
Gerrit-Owner: Nikos Nikoleris 
Gerrit-Reviewer: Curtis Dunham 
Gerrit-Reviewer: Daniel Carvalho 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Nikos Nikoleris 
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in public/gem5[master]: mem-cache: Remove mumBlock redundant initialiation from FALRU

[Nikos Nikoleris (Gerrit)]

Hello Gabe Black, Jason Lowe-Power, Daniel Carvalho, Curtis Dunham,

I'd like you to reexamine a change. Please visit

https://gem5-review.googlesource.com/8281

to look at the new patch set (#2).

Change subject: mem-cache: Remove mumBlock redundant initialiation from  
FALRU

..

mem-cache: Remove mumBlock redundant initialiation from FALRU

Change-Id: Id3afec0a62446d6d0f44ccb655032343037637e0
Reviewed-by: Curtis Dunham 
---
M src/mem/cache/tags/base.hh
M src/mem/cache/tags/fa_lru.cc
2 files changed, 1 insertion(+), 3 deletions(-)


--
To view, visit https://gem5-review.googlesource.com/8281
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Id3afec0a62446d6d0f44ccb655032343037637e0
Gerrit-Change-Number: 8281
Gerrit-PatchSet: 2
Gerrit-Owner: Nikos Nikoleris 
Gerrit-Reviewer: Curtis Dunham 
Gerrit-Reviewer: Daniel Carvalho 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Nikos Nikoleris 
Gerrit-MessageType: newpatchset
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev