[gem5-dev] Change in public/gem5[master]: scons: Build error introduced by site_tools/default.py

[Giacomo Travaglini (Gerrit)]

Giacomo Travaglini has submitted this change and it was merged. (  
https://gem5-review.googlesource.com/5941 )


Change subject: scons: Build error introduced by site_tools/default.py
..

scons: Build error introduced by site_tools/default.py

One of the latest commits affecting the build system introduced a change
in the environment setting: rather than using the ENV dictionary,
environment key-val pairs were saved directly into the class. This
patch reverts that behaviour.

Change-Id: If206ba0a34ac8c35695a493cb90654b7ec81971b
Signed-off-by: Giacomo Travaglini 
Reviewed-on: https://gem5-review.googlesource.com/5941
Reviewed-by: Andreas Sandberg 
Maintainer: Andreas Sandberg 
---
M site_scons/site_tools/default.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Andreas Sandberg: Looks good to me, approved; Looks good to me, approved



diff --git a/site_scons/site_tools/default.py  
b/site_scons/site_tools/default.py

index 73c4a9e..9d02ab7 100644
--- a/site_scons/site_tools/default.py
+++ b/site_scons/site_tools/default.py
@@ -64,7 +64,7 @@
 for key,val in sorted(os.environ.iteritems()):
 if key in use_vars or \
 any([key.startswith(prefix) for prefix in use_prefixes]):
-env[key] = val
+env['ENV'][key] = val

 # Tell scons to avoid implicit command dependencies to avoid issues
 # with the param wrappes being compiled twice (see

--
To view, visit https://gem5-review.googlesource.com/5941
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If206ba0a34ac8c35695a493cb90654b7ec81971b
Gerrit-Change-Number: 5941
Gerrit-PatchSet: 2
Gerrit-Owner: Giacomo Travaglini 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-CC: Gabe Black 
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in public/gem5[master]: scons: Build error introduced by site_tools/default.py

[Giacomo Travaglini (Gerrit)]

Giacomo Travaglini has uploaded this change for review. (  
https://gem5-review.googlesource.com/5941



Change subject: scons: Build error introduced by site_tools/default.py
..

scons: Build error introduced by site_tools/default.py

One of the latest commits affecting the build system introduced a change
in the environment setting: rather than using the ENV dictionary,
environment key-val pairs were saved directly into the class. This
patch reverts that behaviour.

Change-Id: If206ba0a34ac8c35695a493cb90654b7ec81971b
Signed-off-by: Giacomo Travaglini 
---
M site_scons/site_tools/default.py
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/site_scons/site_tools/default.py  
b/site_scons/site_tools/default.py

index 73c4a9e..9d02ab7 100644
--- a/site_scons/site_tools/default.py
+++ b/site_scons/site_tools/default.py
@@ -64,7 +64,7 @@
 for key,val in sorted(os.environ.iteritems()):
 if key in use_vars or \
 any([key.startswith(prefix) for prefix in use_prefixes]):
-env[key] = val
+env['ENV'][key] = val

 # Tell scons to avoid implicit command dependencies to avoid issues
 # with the param wrappes being compiled twice (see

--
To view, visit https://gem5-review.googlesource.com/5941
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If206ba0a34ac8c35695a493cb90654b7ec81971b
Gerrit-Change-Number: 5941
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini 
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev