Re: [gem5-dev] Kokoro Invocation Logs

2019-04-26 Thread Jason Lowe-Power
Hey Brandon,

A couple of things:
1) You shouldn't need to build any binaries for the tests. All of them are
hosted on gem5.org and automatically downloaded when you run the test.
(They are "DownloadedProgram" fixtures.) The goal of the testing framework
is that everyone should be able to run all tests easily without external
dependencies. If this is not the case, then there is a bug.

2) No one person is responsible for any part of gem5; it's a
community-developed project :). gem5's tests have gotten little love over
the years. It seems that most contributors (myself included) don't find it
enjoyable to work on the testing infrastructure. In the past two years, I
have put significant time and effort into creating a new framework that is
more scalable and extensible than the previous tests. I hope over the next
few years that this holds true. However, I'm aware that there are places
the testing infrastructure can be improved. One of the most important areas
for improvement is in the error cases.

(As an aside, it turns out this is something that is difficult to develop.
How do you test when the tester produces errors? It's less straightforward
than I would have hoped.)

Since we have laid the groundwork for improved testing, I hope to see the
community as a whole contribute to making it better going forward.
Specifically, if you have a strong use case for viewing/saving
stdout/stderr and need this feature now, it would be incredibly impactful
for you to add this feature. I was thinking the best way to do this on
Jenkins would be to zip up the output and store it as an artifact. I
believe specifying artifacts is something we can do in the presubmit.cfg
file. Though, I don't have much experience with Jenkins, so I could be
wrong.

Cheers,
Jason

On Thu, Apr 25, 2019 at 1:55 PM Potter, Brandon 
wrote:

> Hello all,
>
> The kokoro invocation logs need to include simout and simerr logs for
> individual test failures. The source.cloud.google.com hyperlink below
> shows an example where I had some test failure with no indication why the
> tests failed. It is insufficient for us to try to run the tests locally,
> because we cannot build them on our internal cluster. Our IT does not
> allows us to run docker instances so I cannot build the some of the tests
> that are part of the tester.
>
>
> https://source.cloud.google.com/results/invocations/6ff06bff-8ff7-4a07-b8cf-c951064ed2cf/log
>
> Can someone responsible for the tester please add a mechanism to view the
> standard simout and simerr output? Alternatively, can someone revise the
> tester Makefiles to remove Docker dependencies?
>
> Regards,
> Brandon
> ___
> gem5-dev mailing list
> gem5-dev@gem5.org
> http://m5sim.org/mailman/listinfo/gem5-dev
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Kokoro Invocation Logs

2019-04-25 Thread Potter, Brandon
Hello all,

The kokoro invocation logs need to include simout and simerr logs for 
individual test failures. The source.cloud.google.com hyperlink below shows an 
example where I had some test failure with no indication why the tests failed. 
It is insufficient for us to try to run the tests locally, because we cannot 
build them on our internal cluster. Our IT does not allows us to run docker 
instances so I cannot build the some of the tests that are part of the tester.

https://source.cloud.google.com/results/invocations/6ff06bff-8ff7-4a07-b8cf-c951064ed2cf/log

Can someone responsible for the tester please add a mechanism to view the 
standard simout and simerr output? Alternatively, can someone revise the tester 
Makefiles to remove Docker dependencies?

Regards,
Brandon
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev