Re: [gem5-dev] Review Request: ruby: reset timing after cache warm up
On Sept. 26, 2012, 3:24 p.m., Andreas Hansson wrote: I'm not too thrilled about this. Could you explain why we cannot rely on the global time keeping here? I'm not understanding the issue... Andreas Hansson wrote: I'm even inclined to create a ResettableClockedObject in between ClockedObject and the Ruby system. The whole idea of having a function to reset the clock makes me nervous. Is there no other way Ruby could restore the cache state without advancing time? Andreas, it is not possible to create ResettableClockedObject class. This is because the variables tick and cycles are private to class ClockedObject and hence not accessible in ResettableClockedObject. - Nilay --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1435/#review3525 --- On Oct. 4, 2012, 8:29 a.m., Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1435/ --- (Updated Oct. 4, 2012, 8:29 a.m.) Review request for Default. Description --- Changeset 9277:f576478175f1 --- ruby: reset timing after cache warm up Ruby system was recently converted to a clocked object. Such objects maintain state related to the time that has passed so far. During the cache warmup, Ruby system changes its own time and the global time. Later on, the global time is restored. So Ruby system also needs to reset its own time. Diffs - src/mem/ruby/system/System.cc a5ede748a1d9 src/sim/clocked_object.hh a5ede748a1d9 Diff: http://reviews.gem5.org/r/1435/diff/ Testing --- Thanks, Nilay Vaish ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request: ruby: reset timing after cache warm up
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1435/ --- (Updated Oct. 4, 2012, 8:29 a.m.) Review request for Default. Description (updated) --- Changeset 9277:f576478175f1 --- ruby: reset timing after cache warm up Ruby system was recently converted to a clocked object. Such objects maintain state related to the time that has passed so far. During the cache warmup, Ruby system changes its own time and the global time. Later on, the global time is restored. So Ruby system also needs to reset its own time. Diffs (updated) - src/mem/ruby/system/System.cc a5ede748a1d9 src/sim/clocked_object.hh a5ede748a1d9 Diff: http://reviews.gem5.org/r/1435/diff/ Testing --- Thanks, Nilay Vaish ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request: ruby: reset timing after cache warm up
On Sept. 26, 2012, 3:24 p.m., Andreas Hansson wrote: I'm not too thrilled about this. Could you explain why we cannot rely on the global time keeping here? I'm not understanding the issue... I'm even inclined to create a ResettableClockedObject in between ClockedObject and the Ruby system. The whole idea of having a function to reset the clock makes me nervous. Is there no other way Ruby could restore the cache state without advancing time? - Andreas --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1435/#review3525 --- On Sept. 24, 2012, 5:53 p.m., Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1435/ --- (Updated Sept. 24, 2012, 5:53 p.m.) Review request for Default. Description --- Changeset 9249:4b5ef2c0dbd4 --- ruby: reset timing after cache warm up Ruby system was recently converted to a clocked object. Such objects maintain state related to the time that has passed so far. During the cache warmup, Ruby system changes its own time and the global time. Later on, the global time is restored. So Ruby system also needs to reset its own time. Diffs - src/mem/ruby/system/System.cc 73c3eb0dd733 src/sim/clocked_object.hh 73c3eb0dd733 Diff: http://reviews.gem5.org/r/1435/diff/ Testing --- Thanks, Nilay Vaish ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request: ruby: reset timing after cache warm up
Is there no other way Ruby could restore the cache state without advancing time? No. Setting ruby state requires you to step through the necessary transient states and there is no clear way to know when all those transient states have been completely stepped through without waiting for the eventqueue to be empty. Brad - Andreas --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1435/#review3525 --- On Sept. 24, 2012, 5:53 p.m., Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1435/ --- (Updated Sept. 24, 2012, 5:53 p.m.) Review request for Default. Description --- Changeset 9249:4b5ef2c0dbd4 --- ruby: reset timing after cache warm up Ruby system was recently converted to a clocked object. Such objects maintain state related to the time that has passed so far. During the cache warmup, Ruby system changes its own time and the global time. Later on, the global time is restored. So Ruby system also needs to reset its own time. Diffs - src/mem/ruby/system/System.cc 73c3eb0dd733 src/sim/clocked_object.hh 73c3eb0dd733 Diff: http://reviews.gem5.org/r/1435/diff/ Testing --- Thanks, Nilay Vaish ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request: ruby: reset timing after cache warm up
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1435/#review3525 --- I'm not too thrilled about this. Could you explain why we cannot rely on the global time keeping here? I'm not understanding the issue... - Andreas Hansson On Sept. 24, 2012, 5:53 p.m., Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1435/ --- (Updated Sept. 24, 2012, 5:53 p.m.) Review request for Default. Description --- Changeset 9249:4b5ef2c0dbd4 --- ruby: reset timing after cache warm up Ruby system was recently converted to a clocked object. Such objects maintain state related to the time that has passed so far. During the cache warmup, Ruby system changes its own time and the global time. Later on, the global time is restored. So Ruby system also needs to reset its own time. Diffs - src/mem/ruby/system/System.cc 73c3eb0dd733 src/sim/clocked_object.hh 73c3eb0dd733 Diff: http://reviews.gem5.org/r/1435/diff/ Testing --- Thanks, Nilay Vaish ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request: ruby: reset timing after cache warm up
On Wed, 26 Sep 2012, Andreas Hansson wrote: I'm not too thrilled about this. Could you explain why we cannot rely on the global time keeping here? I'm not understanding the issue... You need to understand how ruby warms up the caches on a checkpoint restore. The checkpoint records (address,value) pairs for all the caches. On restore, before the actual simulation starts, ruby replays these recorded pairs by making timing requests for these. Thus, the global time moves ahead because of ruby's cache warm up. But since we are restoring from a checkpoint, after the warm up is over, we restore the global time. RubySystem is now a clocked object. This means it stores a tick and a cycle value, which are in the neighbourhood of the global tick value. But even after the global tick value is restored, RubySystem object will still hold the same tick and cycle values. Hence, the need for clock reset. -- Nilay ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request: ruby: reset timing after cache warm up
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1435/#review3532 --- Ship it! Ship It! - Brad Beckmann On Sept. 24, 2012, 5:53 p.m., Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1435/ --- (Updated Sept. 24, 2012, 5:53 p.m.) Review request for Default. Description --- Changeset 9249:4b5ef2c0dbd4 --- ruby: reset timing after cache warm up Ruby system was recently converted to a clocked object. Such objects maintain state related to the time that has passed so far. During the cache warmup, Ruby system changes its own time and the global time. Later on, the global time is restored. So Ruby system also needs to reset its own time. Diffs - src/mem/ruby/system/System.cc 73c3eb0dd733 src/sim/clocked_object.hh 73c3eb0dd733 Diff: http://reviews.gem5.org/r/1435/diff/ Testing --- Thanks, Nilay Vaish ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
