Re: [gem5-dev] Review Request 3248: arm: Ship Linux device trees with gem5
> On Feb. 15, 2016, 10:14 p.m., Bjoern A. Zeeb wrote: > > There are systems when you actually want to keep the pre-processed .dts > > files around; e.g. not supporting the boot loader bits I can compile the > > DT into the kernel from the DTS files. > > > > Add -P to the CPP flags to remove all the #cpp_left_behind lines. > > > > I ended up using this today (sure not the most elegant solution): > > > > --- Makefile.orig 2016-02-15 22:11:03.036374000 + > > +++ Makefile2016-02-15 14:56:23.160107000 + > > @@ -40,7 +40,7 @@ TARGETS=\ > > armv8_gem5_v1_16cpu.dtb > > > > GEN_DTS=mkdir -p .gen; \ > > - $(CPP) -x assembler-with-cpp \ > > + $(CPP) -x assembler-with-cpp -P \ > > $(DTC_CPP_FLAGS) \ > > -DCONF_PLATFORM=\"platforms/$(1)\" \ > > -DCONF_CPUS=$(2) \ > > @@ -50,9 +50,11 @@ all: $(TARGETS) > > > > .gen/armv7_gem5_v1_%cpu.dts: armv7.dts platforms/vexpress_gem5_v1.dtsi > > $(call GEN_DTS,vexpress_gem5_v1.dtsi,$*) > > + cp -p $@ . > > > > .gen/armv8_gem5_v1_%cpu.dts: armv8.dts platforms/vexpress_gem5_v1.dtsi > > $(call GEN_DTS,vexpress_gem5_v1.dtsi,$*) > > + cp -p $@ . > > > > %.dtb: .gen/%.dts > > $(DTC) -I dts -O dtb -o $@ $< > > @@ -60,4 +62,4 @@ all: $(TARGETS) > > > > clean: > > $(RM) -r .gen > > - $(RM) *.dtb > > + $(RM) *.dtb armv?_gem5_v1_*.dts > > Bjoern A. Zeeb wrote: > Ignore my changes for now. Let's get yours in. They seem to work for me > as well (the 1CPU config). And I should say with some editing due to FreeBSD FDT handling specifics. But they are clearly better than the old ones in the linux github tree. - Bjoern A. --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3248/#review8013 --- On Dec. 8, 2015, 10:59 a.m., Andreas Sandberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3248/ > --- > > (Updated Dec. 8, 2015, 10:59 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11243:68bbd5bbe86f > --- > arm: Ship Linux device trees with gem5 > > Ship aarch32 and aarch64 device trees with gem5. We currently ship > device trees as a part of the gem5 Linux kernel repository. This makes > tracking hard since device trees are supposed to be platform dependent > rather than kernel dependent (Linux considers device trees to be a > stable kernel ABI). It also makes code sharing between aarch32 and > aarch64 impossible. > > This changeset implements a set of device trees for the new > VExpress_GEM5_V1 platform. The platform is described in a shared file > that is separate from the memory/CPU description. Due to differences > in how secondary CPUs are initialized, aarch32 and aarch64 use > different base files describing CPU nodes and the machine's > compatibility property. > > > Diffs > - > > system/arm/dt/platforms/vexpress_gem5_v1.dtsi PRE-CREATION > system/arm/dt/Makefile PRE-CREATION > system/arm/dt/armv7.dts PRE-CREATION > system/arm/dt/armv8.dts PRE-CREATION > > Diff: http://reviews.gem5.org/r/3248/diff/ > > > Testing > --- > > > Thanks, > > Andreas Sandberg > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3248: arm: Ship Linux device trees with gem5
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3248/#review8018 --- Ship it! Ship It! - Bjoern A. Zeeb On Dec. 8, 2015, 10:59 a.m., Andreas Sandberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3248/ > --- > > (Updated Dec. 8, 2015, 10:59 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11243:68bbd5bbe86f > --- > arm: Ship Linux device trees with gem5 > > Ship aarch32 and aarch64 device trees with gem5. We currently ship > device trees as a part of the gem5 Linux kernel repository. This makes > tracking hard since device trees are supposed to be platform dependent > rather than kernel dependent (Linux considers device trees to be a > stable kernel ABI). It also makes code sharing between aarch32 and > aarch64 impossible. > > This changeset implements a set of device trees for the new > VExpress_GEM5_V1 platform. The platform is described in a shared file > that is separate from the memory/CPU description. Due to differences > in how secondary CPUs are initialized, aarch32 and aarch64 use > different base files describing CPU nodes and the machine's > compatibility property. > > > Diffs > - > > system/arm/dt/platforms/vexpress_gem5_v1.dtsi PRE-CREATION > system/arm/dt/Makefile PRE-CREATION > system/arm/dt/armv7.dts PRE-CREATION > system/arm/dt/armv8.dts PRE-CREATION > > Diff: http://reviews.gem5.org/r/3248/diff/ > > > Testing > --- > > > Thanks, > > Andreas Sandberg > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3248: arm: Ship Linux device trees with gem5
> On Feb. 15, 2016, 10:14 p.m., Bjoern A. Zeeb wrote: > > There are systems when you actually want to keep the pre-processed .dts > > files around; e.g. not supporting the boot loader bits I can compile the > > DT into the kernel from the DTS files. > > > > Add -P to the CPP flags to remove all the #cpp_left_behind lines. > > > > I ended up using this today (sure not the most elegant solution): > > > > --- Makefile.orig 2016-02-15 22:11:03.036374000 + > > +++ Makefile2016-02-15 14:56:23.160107000 + > > @@ -40,7 +40,7 @@ TARGETS=\ > > armv8_gem5_v1_16cpu.dtb > > > > GEN_DTS=mkdir -p .gen; \ > > - $(CPP) -x assembler-with-cpp \ > > + $(CPP) -x assembler-with-cpp -P \ > > $(DTC_CPP_FLAGS) \ > > -DCONF_PLATFORM=\"platforms/$(1)\" \ > > -DCONF_CPUS=$(2) \ > > @@ -50,9 +50,11 @@ all: $(TARGETS) > > > > .gen/armv7_gem5_v1_%cpu.dts: armv7.dts platforms/vexpress_gem5_v1.dtsi > > $(call GEN_DTS,vexpress_gem5_v1.dtsi,$*) > > + cp -p $@ . > > > > .gen/armv8_gem5_v1_%cpu.dts: armv8.dts platforms/vexpress_gem5_v1.dtsi > > $(call GEN_DTS,vexpress_gem5_v1.dtsi,$*) > > + cp -p $@ . > > > > %.dtb: .gen/%.dts > > $(DTC) -I dts -O dtb -o $@ $< > > @@ -60,4 +62,4 @@ all: $(TARGETS) > > > > clean: > > $(RM) -r .gen > > - $(RM) *.dtb > > + $(RM) *.dtb armv?_gem5_v1_*.dts Ignore my changes for now. Let's get yours in. They seem to work for me as well (the 1CPU config). - Bjoern A. --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3248/#review8013 --- On Dec. 8, 2015, 10:59 a.m., Andreas Sandberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3248/ > --- > > (Updated Dec. 8, 2015, 10:59 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11243:68bbd5bbe86f > --- > arm: Ship Linux device trees with gem5 > > Ship aarch32 and aarch64 device trees with gem5. We currently ship > device trees as a part of the gem5 Linux kernel repository. This makes > tracking hard since device trees are supposed to be platform dependent > rather than kernel dependent (Linux considers device trees to be a > stable kernel ABI). It also makes code sharing between aarch32 and > aarch64 impossible. > > This changeset implements a set of device trees for the new > VExpress_GEM5_V1 platform. The platform is described in a shared file > that is separate from the memory/CPU description. Due to differences > in how secondary CPUs are initialized, aarch32 and aarch64 use > different base files describing CPU nodes and the machine's > compatibility property. > > > Diffs > - > > system/arm/dt/platforms/vexpress_gem5_v1.dtsi PRE-CREATION > system/arm/dt/Makefile PRE-CREATION > system/arm/dt/armv7.dts PRE-CREATION > system/arm/dt/armv8.dts PRE-CREATION > > Diff: http://reviews.gem5.org/r/3248/diff/ > > > Testing > --- > > > Thanks, > > Andreas Sandberg > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3248: arm: Ship Linux device trees with gem5
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3248/#review8013 --- There are systems when you actually want to keep the pre-processed .dts files around; e.g. not supporting the boot loader bits I can compile the DT into the kernel from the DTS files. Add -P to the CPP flags to remove all the #cpp_left_behind lines. I ended up using this today (sure not the most elegant solution): --- Makefile.orig 2016-02-15 22:11:03.036374000 + +++ Makefile2016-02-15 14:56:23.160107000 + @@ -40,7 +40,7 @@ TARGETS=\ armv8_gem5_v1_16cpu.dtb GEN_DTS=mkdir -p .gen; \ - $(CPP) -x assembler-with-cpp \ + $(CPP) -x assembler-with-cpp -P \ $(DTC_CPP_FLAGS) \ -DCONF_PLATFORM=\"platforms/$(1)\" \ -DCONF_CPUS=$(2) \ @@ -50,9 +50,11 @@ all: $(TARGETS) .gen/armv7_gem5_v1_%cpu.dts: armv7.dts platforms/vexpress_gem5_v1.dtsi $(call GEN_DTS,vexpress_gem5_v1.dtsi,$*) + cp -p $@ . .gen/armv8_gem5_v1_%cpu.dts: armv8.dts platforms/vexpress_gem5_v1.dtsi $(call GEN_DTS,vexpress_gem5_v1.dtsi,$*) + cp -p $@ . %.dtb: .gen/%.dts $(DTC) -I dts -O dtb -o $@ $< @@ -60,4 +62,4 @@ all: $(TARGETS) clean: $(RM) -r .gen - $(RM) *.dtb + $(RM) *.dtb armv?_gem5_v1_*.dts - Bjoern A. Zeeb On Dec. 8, 2015, 10:59 a.m., Andreas Sandberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3248/ > --- > > (Updated Dec. 8, 2015, 10:59 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11243:68bbd5bbe86f > --- > arm: Ship Linux device trees with gem5 > > Ship aarch32 and aarch64 device trees with gem5. We currently ship > device trees as a part of the gem5 Linux kernel repository. This makes > tracking hard since device trees are supposed to be platform dependent > rather than kernel dependent (Linux considers device trees to be a > stable kernel ABI). It also makes code sharing between aarch32 and > aarch64 impossible. > > This changeset implements a set of device trees for the new > VExpress_GEM5_V1 platform. The platform is described in a shared file > that is separate from the memory/CPU description. Due to differences > in how secondary CPUs are initialized, aarch32 and aarch64 use > different base files describing CPU nodes and the machine's > compatibility property. > > > Diffs > - > > system/arm/dt/platforms/vexpress_gem5_v1.dtsi PRE-CREATION > system/arm/dt/Makefile PRE-CREATION > system/arm/dt/armv7.dts PRE-CREATION > system/arm/dt/armv8.dts PRE-CREATION > > Diff: http://reviews.gem5.org/r/3248/diff/ > > > Testing > --- > > > Thanks, > > Andreas Sandberg > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Review Request 3248: arm: Ship Linux device trees with gem5
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3248/ --- Review request for Default. Repository: gem5 Description --- Changeset 11243:68bbd5bbe86f --- arm: Ship Linux device trees with gem5 Ship aarch32 and aarch64 device trees with gem5. We currently ship device trees as a part of the gem5 Linux kernel repository. This makes tracking hard since device trees are supposed to be platform dependent rather than kernel dependent (Linux considers device trees to be a stable kernel ABI). It also makes code sharing between aarch32 and aarch64 impossible. This changeset implements a set of device trees for the new VExpress_GEM5_V1 platform. The platform is described in a shared file that is separate from the memory/CPU description. Due to differences in how secondary CPUs are initialized, aarch32 and aarch64 use different base files describing CPU nodes and the machine's compatibility property. Diffs - system/arm/dt/platforms/vexpress_gem5_v1.dtsi PRE-CREATION system/arm/dt/Makefile PRE-CREATION system/arm/dt/armv7.dts PRE-CREATION system/arm/dt/armv8.dts PRE-CREATION Diff: http://reviews.gem5.org/r/3248/diff/ Testing --- Thanks, Andreas Sandberg ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
